* [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on
@ 2014-12-12 10:18 tim.gore
2014-12-12 11:43 ` Thomas Wood
0 siblings, 1 reply; 6+ messages in thread
From: tim.gore @ 2014-12-12 10:18 UTC (permalink / raw
To: intel-gfx; +Cc: thomas.wood
From: Tim Gore <tim.gore@intel.com>
intel_sprite_on wont build on Android, due to use
of a particular API that has changed in Gmin
Signed-off-by: Tim Gore <tim.gore@intel.com>
---
demos/Android.mk | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/demos/Android.mk b/demos/Android.mk
index 6227e06..be7f3c2 100644
--- a/demos/Android.mk
+++ b/demos/Android.mk
@@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
include $(CLEAR_VARS)
-LOCAL_SRC_FILES := intel_sprite_on.c
+# This demo wont build on android (from Gmin on).
+#LOCAL_SRC_FILES := intel_sprite_on.c
+
LOCAL_CFLAGS += -DHAVE_TERMIOS_H
LOCAL_CFLAGS += -DANDROID -UNDEBUG
-LOCAL_CFLAGS += -std=c99
+LOCAL_CFLAGS += -std=gnu99
# Excessive complaining for established cases. Rely on the Linux version warnings.
LOCAL_CFLAGS += -Wno-sign-compare
--
2.1.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on
2014-12-12 10:18 [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on tim.gore
@ 2014-12-12 11:43 ` Thomas Wood
2014-12-15 14:41 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Wood @ 2014-12-12 11:43 UTC (permalink / raw
To: Tim Gore; +Cc: Intel Graphics Development
On 12 December 2014 at 10:18, <tim.gore@intel.com> wrote:
> From: Tim Gore <tim.gore@intel.com>
>
> intel_sprite_on wont build on Android, due to use
> of a particular API that has changed in Gmin
>
> Signed-off-by: Tim Gore <tim.gore@intel.com>
> ---
> demos/Android.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/demos/Android.mk b/demos/Android.mk
> index 6227e06..be7f3c2 100644
> --- a/demos/Android.mk
> +++ b/demos/Android.mk
> @@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
>
> include $(CLEAR_VARS)
>
> -LOCAL_SRC_FILES := intel_sprite_on.c
> +# This demo wont build on android (from Gmin on).
> +#LOCAL_SRC_FILES := intel_sprite_on.c
> +
>
> LOCAL_CFLAGS += -DHAVE_TERMIOS_H
> LOCAL_CFLAGS += -DANDROID -UNDEBUG
> -LOCAL_CFLAGS += -std=c99
> +LOCAL_CFLAGS += -std=gnu99
I think this change should have been in your previous patch
("Android.mk: replace std=c99 with std=gnu99")?
> # Excessive complaining for established cases. Rely on the Linux version warnings.
> LOCAL_CFLAGS += -Wno-sign-compare
>
> --
> 2.1.3
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on
@ 2014-12-12 14:29 tim.gore
0 siblings, 0 replies; 6+ messages in thread
From: tim.gore @ 2014-12-12 14:29 UTC (permalink / raw
To: intel-gfx; +Cc: thomas.wood
From: Tim Gore <tim.gore@intel.com>
intel_sprite_on wont build on Android. Previous
attempt to disable was just wrong!
Signed-off-by: Tim Gore <tim.gore@intel.com>
---
demos/Android.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/demos/Android.mk b/demos/Android.mk
index b20d61e..5a00116 100644
--- a/demos/Android.mk
+++ b/demos/Android.mk
@@ -4,8 +4,7 @@ LOCAL_PATH := $(call my-dir)
include $(CLEAR_VARS)
-# This demo wont build on android
-#LOCAL_SRC_FILES := intel_sprite_on.c
+LOCAL_SRC_FILES := intel_sprite_on.c
LOCAL_CFLAGS += -DHAVE_TERMIOS_H
@@ -24,6 +23,7 @@ LOCAL_STATIC_LIBRARIES := libintel_gpu_tools
LOCAL_SHARED_LIBRARIES := libdrm
-include $(BUILD_EXECUTABLE)
+# This demo (intel_sprite_on.c) wont build on android
+#include $(BUILD_EXECUTABLE)
#================#
--
2.1.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on
2014-12-12 11:43 ` Thomas Wood
@ 2014-12-15 14:41 ` Daniel Vetter
2014-12-15 14:51 ` Gore, Tim
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2014-12-15 14:41 UTC (permalink / raw
To: Thomas Wood; +Cc: Intel Graphics Development
On Fri, Dec 12, 2014 at 11:43:55AM +0000, Thomas Wood wrote:
> On 12 December 2014 at 10:18, <tim.gore@intel.com> wrote:
> > From: Tim Gore <tim.gore@intel.com>
> >
> > intel_sprite_on wont build on Android, due to use
> > of a particular API that has changed in Gmin
> >
> > Signed-off-by: Tim Gore <tim.gore@intel.com>
> > ---
> > demos/Android.mk | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/demos/Android.mk b/demos/Android.mk
> > index 6227e06..be7f3c2 100644
> > --- a/demos/Android.mk
> > +++ b/demos/Android.mk
> > @@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
> >
> > include $(CLEAR_VARS)
> >
> > -LOCAL_SRC_FILES := intel_sprite_on.c
> > +# This demo wont build on android (from Gmin on).
> > +#LOCAL_SRC_FILES := intel_sprite_on.c
> > +
> >
> > LOCAL_CFLAGS += -DHAVE_TERMIOS_H
> > LOCAL_CFLAGS += -DANDROID -UNDEBUG
> > -LOCAL_CFLAGS += -std=c99
> > +LOCAL_CFLAGS += -std=gnu99
>
> I think this change should have been in your previous patch
> ("Android.mk: replace std=c99 with std=gnu99")?
btw intel_sprite_on has been contributed by your team (Armin Reese), so
not sure why you want to disable it. Have you checked with display folks
whether they don't need it?
-Daniel
>
>
> > # Excessive complaining for established cases. Rely on the Linux version warnings.
> > LOCAL_CFLAGS += -Wno-sign-compare
> >
> > --
> > 2.1.3
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on
2014-12-15 14:41 ` Daniel Vetter
@ 2014-12-15 14:51 ` Gore, Tim
2014-12-15 15:55 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Gore, Tim @ 2014-12-15 14:51 UTC (permalink / raw
To: Daniel Vetter, Wood, Thomas; +Cc: Intel Graphics Development
> -----Original Message-----
> From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Monday, December 15, 2014 2:41 PM
> To: Wood, Thomas
> Cc: Gore, Tim; Intel Graphics Development
> Subject: Re: [Intel-gfx] [PATCH i-g-t] Demos/Android.mk: dont build
> intel_sprite_on
>
> On Fri, Dec 12, 2014 at 11:43:55AM +0000, Thomas Wood wrote:
> > On 12 December 2014 at 10:18, <tim.gore@intel.com> wrote:
> > > From: Tim Gore <tim.gore@intel.com>
> > >
> > > intel_sprite_on wont build on Android, due to use of a particular
> > > API that has changed in Gmin
> > >
> > > Signed-off-by: Tim Gore <tim.gore@intel.com>
> > > ---
> > > demos/Android.mk | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/demos/Android.mk b/demos/Android.mk index
> > > 6227e06..be7f3c2 100644
> > > --- a/demos/Android.mk
> > > +++ b/demos/Android.mk
> > > @@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
> > >
> > > include $(CLEAR_VARS)
> > >
> > > -LOCAL_SRC_FILES := intel_sprite_on.c
> > > +# This demo wont build on android (from Gmin on).
> > > +#LOCAL_SRC_FILES := intel_sprite_on.c
> > > +
> > >
> > > LOCAL_CFLAGS += -DHAVE_TERMIOS_H
> > > LOCAL_CFLAGS += -DANDROID -UNDEBUG
> > > -LOCAL_CFLAGS += -std=c99
> > > +LOCAL_CFLAGS += -std=gnu99
> >
> > I think this change should have been in your previous patch
> > ("Android.mk: replace std=c99 with std=gnu99")?
>
> btw intel_sprite_on has been contributed by your team (Armin Reese), so
> not sure why you want to disable it. Have you checked with display folks
> whether they don't need it?
> -Daniel
>
Unfortunately this test wont build, out of the box, for Android. I can patch
This locally but I don't think the patch is suitable for upstream.
Tim
> >
> >
> > > # Excessive complaining for established cases. Rely on the Linux version
> warnings.
> > > LOCAL_CFLAGS += -Wno-sign-compare
> > >
> > > --
> > > 2.1.3
> > >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on
2014-12-15 14:51 ` Gore, Tim
@ 2014-12-15 15:55 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2014-12-15 15:55 UTC (permalink / raw
To: Gore, Tim; +Cc: Intel Graphics Development, Wood, Thomas
On Mon, Dec 15, 2014 at 02:51:03PM +0000, Gore, Tim wrote:
>
>
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> > Vetter
> > Sent: Monday, December 15, 2014 2:41 PM
> > To: Wood, Thomas
> > Cc: Gore, Tim; Intel Graphics Development
> > Subject: Re: [Intel-gfx] [PATCH i-g-t] Demos/Android.mk: dont build
> > intel_sprite_on
> >
> > On Fri, Dec 12, 2014 at 11:43:55AM +0000, Thomas Wood wrote:
> > > On 12 December 2014 at 10:18, <tim.gore@intel.com> wrote:
> > > > From: Tim Gore <tim.gore@intel.com>
> > > >
> > > > intel_sprite_on wont build on Android, due to use of a particular
> > > > API that has changed in Gmin
> > > >
> > > > Signed-off-by: Tim Gore <tim.gore@intel.com>
> > > > ---
> > > > demos/Android.mk | 6 ++++--
> > > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/demos/Android.mk b/demos/Android.mk index
> > > > 6227e06..be7f3c2 100644
> > > > --- a/demos/Android.mk
> > > > +++ b/demos/Android.mk
> > > > @@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
> > > >
> > > > include $(CLEAR_VARS)
> > > >
> > > > -LOCAL_SRC_FILES := intel_sprite_on.c
> > > > +# This demo wont build on android (from Gmin on).
> > > > +#LOCAL_SRC_FILES := intel_sprite_on.c
> > > > +
> > > >
> > > > LOCAL_CFLAGS += -DHAVE_TERMIOS_H
> > > > LOCAL_CFLAGS += -DANDROID -UNDEBUG
> > > > -LOCAL_CFLAGS += -std=c99
> > > > +LOCAL_CFLAGS += -std=gnu99
> > >
> > > I think this change should have been in your previous patch
> > > ("Android.mk: replace std=c99 with std=gnu99")?
> >
> > btw intel_sprite_on has been contributed by your team (Armin Reese), so
> > not sure why you want to disable it. Have you checked with display folks
> > whether they don't need it?
> > -Daniel
> >
>
> Unfortunately this test wont build, out of the box, for Android. I can patch
> This locally but I don't think the patch is suitable for upstream.
I'm still confused ... why does it not build on Android? I've thought we
have this now all worked out wrt igt build issues. Imo better to address
whatever's upsetting your builder than to just disable stuff.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-15 15:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-12 10:18 [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on tim.gore
2014-12-12 11:43 ` Thomas Wood
2014-12-15 14:41 ` Daniel Vetter
2014-12-15 14:51 ` Gore, Tim
2014-12-15 15:55 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2014-12-12 14:29 tim.gore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.