All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] --disable-vnc broken?
@ 2015-02-09 10:14 Claudio Fontana
  2015-02-09 10:25 ` Gerd Hoffmann
  0 siblings, 1 reply; 2+ messages in thread
From: Claudio Fontana @ 2015-02-09 10:14 UTC (permalink / raw
  To: Gerd Hoffmann; +Cc: qemu-devel@nongnu.org

Hello,

is some #ifdef CONFIG_VNC missing in the latest vnc changes in mainline QEMU?

I ask because configuring with --disable-vnc and then building now gets me:

../qmp-marshal.o: In function `qmp_marshal_input_query_vnc_servers':
qemu/qmp-marshal.c:2899: undefined reference to `qmp_query_vnc_servers'

while before it was working fine.

Configuring without --disable-vnc and then building works.

I bisected this and got the following.

Thanks,

Claudio

df887684603a4b3b0c623090a6b419dc70f22c32 is the first bad commit
commit df887684603a4b3b0c623090a6b419dc70f22c32
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Wed Dec 17 15:49:44 2014 +0100

    monitor: add query-vnc-servers command

    Add new query vnc qmp command, for the lack of better ideas just name it
    "query-vnc-servers".  Changes over query-vnc:

     * It returns a list of vnc servers, so multiple vnc server instances
       are covered.
     * Each vnc server returns a list of server sockets.  Followup patch
       will use that to also report websockets.  In case we add support for
       multiple server sockets server sockets (to better support ipv4+ipv6
       dualstack) we can add them to the list too.

    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] --disable-vnc broken?
  2015-02-09 10:14 [Qemu-devel] --disable-vnc broken? Claudio Fontana
@ 2015-02-09 10:25 ` Gerd Hoffmann
  0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2015-02-09 10:25 UTC (permalink / raw
  To: Claudio Fontana; +Cc: qemu-devel@nongnu.org

On Mo, 2015-02-09 at 11:14 +0100, Claudio Fontana wrote:
> Hello,
> 
> is some #ifdef CONFIG_VNC missing in the latest vnc changes in mainline QEMU?
> 
> I ask because configuring with --disable-vnc and then building now gets me:
> 
> ../qmp-marshal.o: In function `qmp_marshal_input_query_vnc_servers':
> qemu/qmp-marshal.c:2899: undefined reference to `qmp_query_vnc_servers'
> 
> while before it was working fine.

http://patchwork.ozlabs.org/patch/435349/

cheers,
  Gerd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-09 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-09 10:14 [Qemu-devel] --disable-vnc broken? Claudio Fontana
2015-02-09 10:25 ` Gerd Hoffmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.