From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756040AbbEFHlV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 May 2015 03:41:21 -0400
Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:56854 "EHLO
	lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756005AbbEFHlJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 May 2015 03:41:09 -0400
Message-ID: <1430898058.3843.30.camel@x220>
Subject: Re: [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Shobhit Kumar <shobhit.kumar@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        linux-pwm <linux-pwm@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        David Airlie <airlied@linux.ie>, Samuel Ortiz <sameo@linux.intel.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jani Nikula <jani.nikula@intel.com>, Lee Jones <lee.jones@linaro.org>,
        Povilas Staniulis <wdmonster@gmail.com>,
        Chih-Wei Huang <cwhuang@android-x86.org>
Date: Wed, 06 May 2015 09:40:58 +0200
In-Reply-To: <1430818716-27287-1-git-send-email-shobhit.kumar@intel.com>
References: <1430316005-16480-7-git-send-email-shobhit.kumar@intel.com>
	 <1430818716-27287-1-git-send-email-shobhit.kumar@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2015-05-05 at 15:08 +0530, Shobhit Kumar wrote:
> The Crystalcove PMIC controls PWM signals and this driver exports that
> capability as a PWM chip driver. This is platform device implementtaion
> of the drivers/mfd cell device for CRC PMIC
> 
> v2: Use the existing config callback with duty_ns and period_ns(Thierry)
> 
> v3: Correct the subject line (Lee jones)
> 
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>

The same comments can be made as for v2, see
http://lkml.kernel.org/r/1430428322.2187.24.camel@x220 . Maybe you
didn't receive that message.

It could also be that you think my comments were invalid, or too vague,
or whatever. Please say so, because then I don't have to bother you
again when you send out v4.

Thanks,


Paul Bolle


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
Date: Wed, 06 May 2015 09:40:58 +0200
Message-ID: <1430898058.3843.30.camel@x220>
References: <1430316005-16480-7-git-send-email-shobhit.kumar@intel.com>
 <1430818716-27287-1-git-send-email-shobhit.kumar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1430818716-27287-1-git-send-email-shobhit.kumar@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Shobhit Kumar <shobhit.kumar@intel.com>
Cc: linux-pwm <linux-pwm@vger.kernel.org>, Jani Nikula <jani.nikula@intel.com>, Samuel Ortiz <sameo@linux.intel.com>, Alexandre Courbot <gnurou@gmail.com>, Povilas Staniulis <wdmonster@gmail.com>, intel-gfx <intel-gfx@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-gpio <linux-gpio@vger.kernel.org>, Daniel Vetter <daniel.vetter@intel.com>, Lee Jones <lee.jones@linaro.org>
List-Id: linux-gpio@vger.kernel.org

T24gVHVlLCAyMDE1LTA1LTA1IGF0IDE1OjA4ICswNTMwLCBTaG9iaGl0IEt1bWFyIHdyb3RlOgo+
IFRoZSBDcnlzdGFsY292ZSBQTUlDIGNvbnRyb2xzIFBXTSBzaWduYWxzIGFuZCB0aGlzIGRyaXZl
ciBleHBvcnRzIHRoYXQKPiBjYXBhYmlsaXR5IGFzIGEgUFdNIGNoaXAgZHJpdmVyLiBUaGlzIGlz
IHBsYXRmb3JtIGRldmljZSBpbXBsZW1lbnR0YWlvbgo+IG9mIHRoZSBkcml2ZXJzL21mZCBjZWxs
IGRldmljZSBmb3IgQ1JDIFBNSUMKPiAKPiB2MjogVXNlIHRoZSBleGlzdGluZyBjb25maWcgY2Fs
bGJhY2sgd2l0aCBkdXR5X25zIGFuZCBwZXJpb2RfbnMoVGhpZXJyeSkKPiAKPiB2MzogQ29ycmVj
dCB0aGUgc3ViamVjdCBsaW5lIChMZWUgam9uZXMpCj4gCj4gQ0M6IFNhbXVlbCBPcnRpeiA8c2Ft
ZW9AbGludXguaW50ZWwuY29tPgo+IENjOiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxp
bmFyby5vcmc+Cj4gQ2M6IEFsZXhhbmRyZSBDb3VyYm90IDxnbnVyb3VAZ21haWwuY29tPgo+IENj
OiBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYt
Ynk6IFNob2JoaXQgS3VtYXIgPHNob2JoaXQua3VtYXJAaW50ZWwuY29tPgoKVGhlIHNhbWUgY29t
bWVudHMgY2FuIGJlIG1hZGUgYXMgZm9yIHYyLCBzZWUKaHR0cDovL2xrbWwua2VybmVsLm9yZy9y
LzE0MzA0MjgzMjIuMjE4Ny4yNC5jYW1lbEB4MjIwIC4gTWF5YmUgeW91CmRpZG4ndCByZWNlaXZl
IHRoYXQgbWVzc2FnZS4KCkl0IGNvdWxkIGFsc28gYmUgdGhhdCB5b3UgdGhpbmsgbXkgY29tbWVu
dHMgd2VyZSBpbnZhbGlkLCBvciB0b28gdmFndWUsCm9yIHdoYXRldmVyLiBQbGVhc2Ugc2F5IHNv
LCBiZWNhdXNlIHRoZW4gSSBkb24ndCBoYXZlIHRvIGJvdGhlciB5b3UKYWdhaW4gd2hlbiB5b3Ug
c2VuZCBvdXQgdjQuCgpUaGFua3MsCgoKUGF1bCBCb2xsZQoKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2
ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK