All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/3] drm/i915: Only show view type for GGTT VMAs
Date: Wed, 27 May 2015 10:52:32 +0100	[thread overview]
Message-ID: <1432720354-20230-1-git-send-email-tvrtko.ursulin@linux.intel.com> (raw)

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Printing it for PPGTT VMAs only adds noise since we have defined
view types are only applicable for GGTT.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index fece922..9d36be8 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -156,13 +156,13 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
 	if (obj->fence_reg != I915_FENCE_REG_NONE)
 		seq_printf(m, " (fence: %d)", obj->fence_reg);
 	list_for_each_entry(vma, &obj->vma_list, vma_link) {
-		if (!i915_is_ggtt(vma->vm))
-			seq_puts(m, " (pp");
+		seq_printf(m, " (%sgtt offset: %08llx, size: %08llx",
+			   i915_is_ggtt(vma->vm) ? "g" : "pp",
+			   vma->node.start, vma->node.size);
+		if (i915_is_ggtt(vma->vm))
+			seq_printf(m, ", type: %u)", vma->ggtt_view.type);
 		else
-			seq_puts(m, " (g");
-		seq_printf(m, "gtt offset: %08llx, size: %08llx, type: %u)",
-			   vma->node.start, vma->node.size,
-			   vma->ggtt_view.type);
+			seq_puts(m, ")");
 	}
 	if (obj->stolen)
 		seq_printf(m, " (stolen: %08llx)", obj->stolen->start);
-- 
2.4.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-05-27  9:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27  9:52 Tvrtko Ursulin [this message]
2015-05-27  9:52 ` [PATCH 2/3] drm/i915: Show human readable GGTT view name in debugfs Tvrtko Ursulin
2015-05-28 11:11   ` Joonas Lahtinen
2015-05-28 12:05     ` Tvrtko Ursulin
2015-05-27  9:52 ` [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places Tvrtko Ursulin
2015-05-27 21:15   ` Chris Wilson
2015-05-28  8:58     ` Tvrtko Ursulin
2015-05-28 12:24       ` Daniel Vetter
2015-05-28 12:36         ` Chris Wilson
2015-05-28 14:09           ` Daniel Vetter
2015-06-16 10:17             ` Tvrtko Ursulin
2015-06-16 11:02               ` Chris Wilson
2015-06-16 11:06                 ` Chris Wilson
2015-06-16 11:18                 ` Tvrtko Ursulin
2015-06-16 11:22                   ` Chris Wilson
2015-06-16 11:31                     ` Tvrtko Ursulin
2015-06-16 11:48                       ` Chris Wilson
2015-06-16 13:32                         ` Tvrtko Ursulin
2015-06-16 13:53                           ` Chris Wilson
2015-06-16 15:10                             ` Tvrtko Ursulin
2015-06-16 16:07                               ` Chris Wilson
2015-06-17 11:34                                 ` Daniel Vetter
2015-05-28 11:00 ` [PATCH 1/3] drm/i915: Only show view type for GGTT VMAs Joonas Lahtinen
2015-05-28 11:23   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432720354-20230-1-git-send-email-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.