From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: [PATCH v2 14/17] x86/hvm: remove extraneous parameter from hvmtrace_io_assist() Date: Thu, 11 Jun 2015 16:42:58 +0100 Message-ID: <1434037381-10917-15-git-send-email-paul.durrant@citrix.com> References: <1434037381-10917-1-git-send-email-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z34le-0000GS-OP for xen-devel@lists.xenproject.org; Thu, 11 Jun 2015 15:51:46 +0000 In-Reply-To: <1434037381-10917-1-git-send-email-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Paul Durrant , Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org The is_mmio parameter can be inferred from the ioreq type. Signed-off-by: Paul Durrant Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/hvm/emulate.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 016bc79..1eab7bd 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -23,8 +23,9 @@ #include #include -static void hvmtrace_io_assist(int is_mmio, ioreq_t *p) +static void hvmtrace_io_assist(ioreq_t *p) { + bool_t is_mmio = (p->type == IOREQ_TYPE_COPY); unsigned int size, event; unsigned char buffer[12]; @@ -158,7 +159,7 @@ static int hvmemul_do_io( if ( dir == IOREQ_READ ) { - hvmtrace_io_assist(is_mmio, &p); + hvmtrace_io_assist(&p); if ( !data_is_addr ) memcpy(p_data, &p.data, size); @@ -209,7 +210,7 @@ static int hvmemul_do_io( if ( !data_is_addr ) memcpy(&p.data, p_data, size); - hvmtrace_io_assist(is_mmio, &p); + hvmtrace_io_assist(&p); } rc = hvm_io_intercept(&p); -- 1.7.10.4