From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbbFLILP (ORCPT ); Fri, 12 Jun 2015 04:11:15 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:48570 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbbFLILI (ORCPT ); Fri, 12 Jun 2015 04:11:08 -0400 Message-ID: <1434096662.2271.130.camel@x220> Subject: Re: [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND) From: Paul Bolle To: KOBAYASHI Yoshitake Cc: dwmw2@infradead.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 12 Jun 2015 10:11:02 +0200 In-Reply-To: <1434038402-26365-1-git-send-email-yoshitake.kobayashi@toshiba.co.jp> References: <1434038402-26365-1-git-send-email-yoshitake.kobayashi@toshiba.co.jp> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-06-12 at 01:00 +0900, KOBAYASHI Yoshitake wrote: > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 5897d8d..050f0e9 100644 > +config MTD_NAND_BENAND > + tristate > + depends on MTD_NAND_BENAND_ENABLE > + default MTD_NAND > + > +config MTD_NAND_BENAND_ENABLE > + bool "Support for Toshiba BENAND (Built-in ECC NAND)" > + default y Why do you default to 'y'? > + help > + This enables support for Toshiba BENAND. > + Toshiba BENAND is a SLC NAND solution that automatically > + generates ECC inside NAND chip. > + > --- /dev/null > +++ b/drivers/mtd/nand/nand_benand.c > +EXPORT_SYMBOL(nand_benand_status_chk); I didn't spot any users of nand_benand_status_chk() outside of this file. Why is this export needed? Thanks, Paul Bolle From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z3K3l-00065B-A4 for linux-mtd@lists.infradead.org; Fri, 12 Jun 2015 08:11:30 +0000 Message-ID: <1434096662.2271.130.camel@x220> Subject: Re: [PATCH v2] mtd: nand: support for Toshiba BENAND (Built-in ECC NAND) From: Paul Bolle To: KOBAYASHI Yoshitake Date: Fri, 12 Jun 2015 10:11:02 +0200 In-Reply-To: <1434038402-26365-1-git-send-email-yoshitake.kobayashi@toshiba.co.jp> References: <1434038402-26365-1-git-send-email-yoshitake.kobayashi@toshiba.co.jp> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2015-06-12 at 01:00 +0900, KOBAYASHI Yoshitake wrote: > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 5897d8d..050f0e9 100644 > +config MTD_NAND_BENAND > + tristate > + depends on MTD_NAND_BENAND_ENABLE > + default MTD_NAND > + > +config MTD_NAND_BENAND_ENABLE > + bool "Support for Toshiba BENAND (Built-in ECC NAND)" > + default y Why do you default to 'y'? > + help > + This enables support for Toshiba BENAND. > + Toshiba BENAND is a SLC NAND solution that automatically > + generates ECC inside NAND chip. > + > --- /dev/null > +++ b/drivers/mtd/nand/nand_benand.c > +EXPORT_SYMBOL(nand_benand_status_chk); I didn't spot any users of nand_benand_status_chk() outside of this file. Why is this export needed? Thanks, Paul Bolle