From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Pb2-00008E-6I for qemu-devel@nongnu.org; Fri, 12 Jun 2015 10:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Paw-0002Kh-V2 for qemu-devel@nongnu.org; Fri, 12 Jun 2015 10:06:12 -0400 Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:14179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Paw-0002GZ-Oc for qemu-devel@nongnu.org; Fri, 12 Jun 2015 10:06:06 -0400 From: Don Slutz Date: Fri, 12 Jun 2015 10:05:48 -0400 Message-Id: <1434117956-4929-2-git-send-email-dslutz@verizon.com> In-Reply-To: <1434117956-4929-1-git-send-email-dslutz@verizon.com> References: <1434117956-4929-1-git-send-email-dslutz@verizon.com> Subject: [Qemu-devel] [BUGFIX][PATCH v7 1/9] vmport: The io memory region needs to be at least a size of 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Markus Armbruster , Don Slutz , Luiz Capitulino , Don Slutz , Anthony Liguori , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson Before: commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 Author: Peter Crosthwaite Date: Mon Mar 16 22:35:54 2015 -0700 exec: Respect as_tranlsate_internal length clamp it did not matter. Only accept I/O that starts on 1st port. Signed-off-by: Don Slutz CC: Don Slutz --- hw/misc/vmport.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d..51b64bc 100644 --- a/hw/misc/vmport.c +++ b/hw/misc/vmport.c @@ -69,6 +69,10 @@ static uint64_t vmport_ioport_read(void *opaque, hwaddr addr, unsigned char command; uint32_t eax; + /* Only support 1 address */ + if (addr) { + return ~0U; + } cpu_synchronize_state(cs); eax = env->regs[R_EAX]; @@ -159,7 +163,7 @@ static void vmport_realizefn(DeviceState *dev, Error **errp) ISADevice *isadev = ISA_DEVICE(dev); VMPortState *s = VMPORT(dev); - memory_region_init_io(&s->io, OBJECT(s), &vmport_ops, s, "vmport", 1); + memory_region_init_io(&s->io, OBJECT(s), &vmport_ops, s, "vmport", 4); isa_register_ioport(isadev, &s->io, 0x5658); port_state = s; -- 1.8.4