All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <contact@paulk.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts
Date: Sat, 13 Jun 2015 09:27:25 +0200	[thread overview]
Message-ID: <1434180445.2287.2.camel@collins> (raw)
In-Reply-To: <CAPnjgZ3B2rDO6D8i-_8v6CEJ5zuyeZ6Hnr=0f81nTZW4djmaww@mail.gmail.com>

[snip]

> >> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> >
> > This is in my queue and looks like a fix, so I'm picking it up.
> >
> > Applied to u-boot-x86, thanks!
> 
> Unfortunately in my final build test this breaks a number of boards, including:
> 
> am335x_boneblack_vboot
> 
> common/cmd_fastboot.c:36:32: error: ?controller_index? undeclared
> (first use in this function)
>    usb_gadget_handle_interrupts(controller_index);
> 
> Can you please take a look and respin it?

Of course, this makes perfect sense. I didn't think about it until now,
but this patch goes on top of the four fastboot-related dfu patches that
I sent out (again) yesterday.

I think this should be picked up along with those patches.
Lukasz, could you do that?

Thanks

> For now I've dropped it from u-boot-x86.

Makes sense.

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150613/4e3a79c3/attachment.sig>

  reply	other threads:[~2015-06-13  7:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-24  9:41 [U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts Paul Kocialkowski
2015-05-25 14:50 ` Lukasz Majewski
2015-06-07 14:48   ` Simon Glass
2015-06-07 20:48     ` Lukasz Majewski
2015-06-12 21:23     ` Simon Glass
2015-06-13  7:27       ` Paul Kocialkowski [this message]
2015-07-07 12:29   ` Paul Kocialkowski
2015-07-14 12:38     ` Paul Kocialkowski
2015-07-14 15:22       ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434180445.2287.2.camel@collins \
    --to=contact@paulk.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.