* [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol
@ 2015-06-15 16:47 Liam Girdwood
2015-06-15 16:57 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Liam Girdwood @ 2015-06-15 16:47 UTC (permalink / raw
To: alsa-devel; +Cc: Liam Girdwood, Mark Brown
Fix the following error:-
All error/warnings (new ones prefixed by >>):
>
> sound/built-in.o: In function `soc_tplg_dapm_widget_create':
> >> :(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control'
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
---
sound/soc/soc-dapm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 92d57a9..1b4a6eb 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -53,7 +53,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm,
int (*connected)(struct snd_soc_dapm_widget *source,
struct snd_soc_dapm_widget *sink));
-static struct snd_soc_dapm_widget *
+struct snd_soc_dapm_widget *
snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
const struct snd_soc_dapm_widget *widget);
@@ -3270,7 +3270,7 @@ int snd_soc_dapm_put_pin_switch(struct snd_kcontrol *kcontrol,
}
EXPORT_SYMBOL_GPL(snd_soc_dapm_put_pin_switch);
-static struct snd_soc_dapm_widget *
+struct snd_soc_dapm_widget *
snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
const struct snd_soc_dapm_widget *widget)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol
2015-06-15 16:47 [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol Liam Girdwood
@ 2015-06-15 16:57 ` Mark Brown
2015-06-15 17:10 ` Liam Girdwood
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2015-06-15 16:57 UTC (permalink / raw
To: Liam Girdwood; +Cc: alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]
On Mon, Jun 15, 2015 at 05:47:51PM +0100, Liam Girdwood wrote:
> Fix the following error:-
>
> All error/warnings (new ones prefixed by >>):
> >
> > sound/built-in.o: In function `soc_tplg_dapm_widget_create':
> > >> :(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control'
>
> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
This doesn't apply, I appear to have this already?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol
2015-06-15 16:57 ` Mark Brown
@ 2015-06-15 17:10 ` Liam Girdwood
2015-06-15 18:20 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Liam Girdwood @ 2015-06-15 17:10 UTC (permalink / raw
To: Mark Brown, Koul, Vinod; +Cc: alsa-devel
On Mon, 2015-06-15 at 17:57 +0100, Mark Brown wrote:
> On Mon, Jun 15, 2015 at 05:47:51PM +0100, Liam Girdwood wrote:
> > Fix the following error:-
> >
> > All error/warnings (new ones prefixed by >>):
> > >
> > > sound/built-in.o: In function `soc_tplg_dapm_widget_create':
> > > >> :(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control'
> >
> > Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
>
> This doesn't apply, I appear to have this already?
Oh, ok - Vinod reported it was missing earlier and I could not see it in
your topic/topology either ?
Liam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol
2015-06-15 17:10 ` Liam Girdwood
@ 2015-06-15 18:20 ` Mark Brown
2015-06-16 3:47 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2015-06-15 18:20 UTC (permalink / raw
To: Liam Girdwood; +Cc: Koul, Vinod, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]
On Mon, Jun 15, 2015 at 06:10:33PM +0100, Liam Girdwood wrote:
> On Mon, 2015-06-15 at 17:57 +0100, Mark Brown wrote:
> > This doesn't apply, I appear to have this already?
> Oh, ok - Vinod reported it was missing earlier and I could not see it in
> your topic/topology either ?
It's a change for DAPM, it's on the DAPM branch.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol
2015-06-15 18:20 ` Mark Brown
@ 2015-06-16 3:47 ` Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2015-06-16 3:47 UTC (permalink / raw
To: Mark Brown; +Cc: Liam Girdwood, alsa-devel
On Mon, Jun 15, 2015 at 07:20:22PM +0100, Mark Brown wrote:
> On Mon, Jun 15, 2015 at 06:10:33PM +0100, Liam Girdwood wrote:
> > On Mon, 2015-06-15 at 17:57 +0100, Mark Brown wrote:
>
> > > This doesn't apply, I appear to have this already?
>
> > Oh, ok - Vinod reported it was missing earlier and I could not see it in
> > your topic/topology either ?
>
> It's a change for DAPM, it's on the DAPM branch.
Sorry for the noise, let me cherry-pick that one for testing.
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-16 3:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-15 16:47 [PATCH] ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol Liam Girdwood
2015-06-15 16:57 ` Mark Brown
2015-06-15 17:10 ` Liam Girdwood
2015-06-15 18:20 ` Mark Brown
2015-06-16 3:47 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.