From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4qy1-0005ee-Mv for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4qxw-0002yI-Li for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:31:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4qxw-0002y3-Gx for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:31:48 -0400 Message-ID: <1434461505.15692.61.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 16 Jun 2015 15:31:45 +0200 In-Reply-To: <1433404534-12003-1-git-send-email-lma@suse.com> References: <1433404534-12003-1-git-send-email-lma@suse.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: Use usb_bus_find(-1) instead of usb_enabled() in usb_device_add/usb_device_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lin Ma Cc: qemu-devel@nongnu.org On Do, 2015-06-04 at 15:55 +0800, Lin Ma wrote: > Without usb=on machine option, usb_device_add/usb_device_del don't work, > Even if there are virtual usb controllers presented. If you use -device to add your usb host controllers, you should likewise use -device (or device_add monitor cmd) to add your usb devices. -usbdevice is legacy syntax and only there for backward compatibility. cheers, Gerd