From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756592AbbFPNmh (ORCPT ); Tue, 16 Jun 2015 09:42:37 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36850 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756522AbbFPNmd (ORCPT ); Tue, 16 Jun 2015 09:42:33 -0400 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joe Perches , Sudip Mukherjee Subject: [PATCH 3/8] staging: sm7xxfb: add newline Date: Tue, 16 Jun 2015 19:12:06 +0530 Message-Id: <1434462131-15191-3-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org new line was missing in some of the dev_* macros while printing the debug and error messages. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xxfb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index 5667fbf..f18fef9 100644 --- a/drivers/staging/sm7xxfb/sm7xxfb.c +++ b/drivers/staging/sm7xxfb/sm7xxfb.c @@ -741,7 +741,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, int err; unsigned long mmio_base; - dev_info(&pdev->dev, "Silicon Motion display driver."); + dev_info(&pdev->dev, "Silicon Motion display driver.\n"); err = pci_enable_device(pdev); /* enable SMTC chip */ if (err) @@ -815,12 +815,12 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, #ifdef __BIG_ENDIAN if (sfb->fb->var.bits_per_pixel == 32) { sfb->lfb += 0x800000; - dev_info(&pdev->dev, "sfb->lfb=%p", sfb->lfb); + dev_info(&pdev->dev, "sfb->lfb=%p\n", sfb->lfb); } #endif if (!smtc_regbaseaddress) { dev_err(&pdev->dev, - "%s: unable to map memory mapped IO!", + "%s: unable to map memory mapped IO!\n", sfb->fb->fix.id); err = -ENOMEM; goto failed_fb; @@ -854,7 +854,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, break; default: dev_err(&pdev->dev, - "No valid Silicon Motion display chip was detected!"); + "No valid Silicon Motion display chip was detected!\n"); goto failed_fb; } @@ -876,14 +876,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, goto failed; dev_info(&pdev->dev, - "Silicon Motion SM%X Rev%X primary display mode %dx%d-%d Init Complete.", + "Silicon Motion SM%X Rev%X primary display mode %dx%d-%d Init Complete.\n", sfb->chip_id, sfb->chip_rev_id, sfb->fb->var.xres, sfb->fb->var.yres, sfb->fb->var.bits_per_pixel); return 0; failed: - dev_err(&pdev->dev, "Silicon Motion, Inc. primary display init fail."); + dev_err(&pdev->dev, "Silicon Motion, Inc. primary display init fail.\n"); smtc_unmap_smem(sfb); smtc_unmap_mmio(sfb); -- 1.8.1.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Date: Tue, 16 Jun 2015 13:54:06 +0000 Subject: [PATCH 3/8] staging: sm7xxfb: add newline Message-Id: <1434462131-15191-3-git-send-email-sudipm.mukherjee@gmail.com> List-Id: References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joe Perches , Sudip Mukherjee new line was missing in some of the dev_* macros while printing the debug and error messages. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xxfb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index 5667fbf..f18fef9 100644 --- a/drivers/staging/sm7xxfb/sm7xxfb.c +++ b/drivers/staging/sm7xxfb/sm7xxfb.c @@ -741,7 +741,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, int err; unsigned long mmio_base; - dev_info(&pdev->dev, "Silicon Motion display driver."); + dev_info(&pdev->dev, "Silicon Motion display driver.\n"); err = pci_enable_device(pdev); /* enable SMTC chip */ if (err) @@ -815,12 +815,12 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, #ifdef __BIG_ENDIAN if (sfb->fb->var.bits_per_pixel = 32) { sfb->lfb += 0x800000; - dev_info(&pdev->dev, "sfb->lfb=%p", sfb->lfb); + dev_info(&pdev->dev, "sfb->lfb=%p\n", sfb->lfb); } #endif if (!smtc_regbaseaddress) { dev_err(&pdev->dev, - "%s: unable to map memory mapped IO!", + "%s: unable to map memory mapped IO!\n", sfb->fb->fix.id); err = -ENOMEM; goto failed_fb; @@ -854,7 +854,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, break; default: dev_err(&pdev->dev, - "No valid Silicon Motion display chip was detected!"); + "No valid Silicon Motion display chip was detected!\n"); goto failed_fb; } @@ -876,14 +876,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, goto failed; dev_info(&pdev->dev, - "Silicon Motion SM%X Rev%X primary display mode %dx%d-%d Init Complete.", + "Silicon Motion SM%X Rev%X primary display mode %dx%d-%d Init Complete.\n", sfb->chip_id, sfb->chip_rev_id, sfb->fb->var.xres, sfb->fb->var.yres, sfb->fb->var.bits_per_pixel); return 0; failed: - dev_err(&pdev->dev, "Silicon Motion, Inc. primary display init fail."); + dev_err(&pdev->dev, "Silicon Motion, Inc. primary display init fail.\n"); smtc_unmap_smem(sfb); smtc_unmap_mmio(sfb); -- 1.8.1.2