From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 21/27] tools/libxc+libxl+xl: Save v2 streams
Date: Tue, 16 Jun 2015 15:59:25 +0100
Message-ID: <1434466765.13744.210.camel@citrix.com>
References: <1434375880-30914-1-git-send-email-andrew.cooper3@citrix.com>
	<1434375880-30914-22-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1434375880-30914-22-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> This is a complicated set of changes which must be done together for
> bisectability.
> 
>  * libxl-save-helper is updated to unconditionally use libxc migration v2.
>  * libxl compatibility workarounds in libxc are disabled for save operations.
>  * libxl__stream_write_start() is logically spliced into the event location
>    where libxl__xc_domain_save() used to reside.
>  * xl is updated to indicate that the stream is now v2
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> 
> ---
> RFC: What kind of ABI/API indication is appropriate here.  A LIBXL_HAVE*
> isn't apppropriate.

Whether it has "HAVE" in the name or not I think some sort of #define,
or one each for SAVE, RESTORE and perhaps even LEGACY would be
appropriate. We should arrange that we can remove the LEGACY one in the
future without causing applications to think we've reverted to Xen 4.5
era.