From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754472AbbFPReG (ORCPT ); Tue, 16 Jun 2015 13:34:06 -0400 Received: from smtprelay0218.hostedemail.com ([216.40.44.218]:41678 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752332AbbFPReB (ORCPT ); Tue, 16 Jun 2015 13:34:01 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:3868:3872:4321:5007:6261:6996:7904:8957:10004:10400:10848:11658:11914:12517:12519:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: drink12_5b598e459c07 X-Filterd-Recvd-Size: 1315 Message-ID: <1434476037.2689.1.camel@perches.com> Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table From: Joe Perches To: Sudip Mukherjee Cc: Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 16 Jun 2015 10:33:57 -0700 In-Reply-To: <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > move vgamode table from the header file to the C file and mark it > as const. The slightly odd indentation could be fixed here too. > +static const struct ModeInit vgamode[] = { > + { > + /* mode#0: 640 x 480 16Bpp 60Hz */ > + 640, 480, 16, 60, > + /* Init_MISC */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 16 Jun 2015 17:33:57 +0000 Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table Message-Id: <1434476037.2689.1.camel@perches.com> List-Id: References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sudip Mukherjee Cc: Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > move vgamode table from the header file to the C file and mark it > as const. The slightly odd indentation could be fixed here too. > +static const struct ModeInit vgamode[] = { > + { > + /* mode#0: 640 x 480 16Bpp 60Hz */ > + 640, 480, 16, 60, > + /* Init_MISC */