From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755163AbbFQIUm (ORCPT ); Wed, 17 Jun 2015 04:20:42 -0400 Received: from smtprelay0104.hostedemail.com ([216.40.44.104]:45431 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751258AbbFQIUh (ORCPT ); Wed, 17 Jun 2015 04:20:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:4321:5007:6261:7904:10004:10400:10848:11232:11658:11914:12517:12519:12663:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: flag49_223e1b61c0700 X-Filterd-Recvd-Size: 1642 Message-ID: <1434529234.2689.69.camel@perches.com> Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table From: Joe Perches To: Sudip Mukherjee Cc: Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 17 Jun 2015 01:20:34 -0700 In-Reply-To: <20150617081522.GB13043@sudip-PC> References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> <1434476037.2689.1.camel@perches.com> <20150617081522.GB13043@sudip-PC> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-06-17 at 13:45 +0530, Sudip Mukherjee wrote: > On Tue, Jun 16, 2015 at 10:33:57AM -0700, Joe Perches wrote: > > On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > > > move vgamode table from the header file to the C file and mark it > > > as const. > > > > The slightly odd indentation could be fixed here too. > Ok. I am sending v2. But if I am reviewing it I will say > "you are doing too many things in one patch" :( . > so i will fix the indention the other patch which is fixing indention. You could send a follow-up patch to fix it rather than send a v3 of everything. cheers, Joe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Wed, 17 Jun 2015 08:20:34 +0000 Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table Message-Id: <1434529234.2689.69.camel@perches.com> List-Id: References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> <1434476037.2689.1.camel@perches.com> <20150617081522.GB13043@sudip-PC> In-Reply-To: <20150617081522.GB13043@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sudip Mukherjee Cc: Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Wed, 2015-06-17 at 13:45 +0530, Sudip Mukherjee wrote: > On Tue, Jun 16, 2015 at 10:33:57AM -0700, Joe Perches wrote: > > On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > > > move vgamode table from the header file to the C file and mark it > > > as const. > > > > The slightly odd indentation could be fixed here too. > Ok. I am sending v2. But if I am reviewing it I will say > "you are doing too many things in one patch" :( . > so i will fix the indention the other patch which is fixing indention. You could send a follow-up patch to fix it rather than send a v3 of everything. cheers, Joe