From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 16/27] tools/libxl: Infrastructure for
 reading a libxl migration v2 stream
Date: Wed, 17 Jun 2015 11:15:51 +0100
Message-ID: <1434536151.13744.299.camel@citrix.com>
References: <1434375880-30914-1-git-send-email-andrew.cooper3@citrix.com>
	<1434375880-30914-17-git-send-email-andrew.cooper3@citrix.com>
	<5580E4F7.4090705@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5580E4F7.4090705@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>, Ross Lagerwall <ross.lagerwall@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-17 at 11:09 +0800, Wen Congyang wrote:
> > +    if (hdr->options & RESTORE_OPT_BIG_ENDIAN) {
> > +        ret = ERROR_FAIL;
> > +        LOG(ERROR, "Unable to handle big endian streams");
> > +        goto err;
> 
> I think it is better to check if the host is big endian or not.

It's not, there are no big endian ports of Xen today. I think encoding
that here is fine.