From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCHv3 5/6] evtchn: remove the locking when unmasking an event channel
Date: Wed, 17 Jun 2015 13:03:02 +0100 [thread overview]
Message-ID: <1434542583-28073-6-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1434542583-28073-1-git-send-email-david.vrabel@citrix.com>
The event channel lock is no longer required to check if the port is
valid.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
v3:
- Use port_is_valid() again.
---
xen/common/event_channel.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index e7c4445..eabb4c8 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -978,8 +978,6 @@ int evtchn_unmask(unsigned int port)
struct domain *d = current->domain;
struct evtchn *evtchn;
- ASSERT(spin_is_locked(&d->event_lock));
-
if ( unlikely(!port_is_valid(d, port)) )
return -EINVAL;
@@ -1146,9 +1144,7 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
struct evtchn_unmask unmask;
if ( copy_from_guest(&unmask, arg, 1) != 0 )
return -EFAULT;
- spin_lock(¤t->domain->event_lock);
rc = evtchn_unmask(unmask.port);
- spin_unlock(¤t->domain->event_lock);
break;
}
--
1.7.10.4
next prev parent reply other threads:[~2015-06-17 12:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:02 [PATCHv3 0/6] evtchn: Improve scalebility David Vrabel
2015-06-17 12:02 ` [PATCHv3 1/6] evtchn: clear xen_consumer when clearing state David Vrabel
2015-06-18 10:30 ` Jan Beulich
2015-06-17 12:02 ` [PATCHv3 2/6] evtchn: defer freeing struct evtchn's until evtchn_destroy_final() David Vrabel
2015-06-18 10:36 ` Jan Beulich
2015-06-18 10:40 ` David Vrabel
2015-06-18 11:01 ` Jan Beulich
2015-06-19 9:29 ` Jan Beulich
2015-06-19 9:52 ` David Vrabel
2015-06-19 10:55 ` Jan Beulich
2015-06-19 12:23 ` David Vrabel
2015-06-19 13:04 ` Jan Beulich
2015-06-19 16:58 ` David Vrabel
2015-06-17 12:03 ` [PATCHv3 3/6] evtchn: simplify port_is_valid() David Vrabel
2015-06-17 12:03 ` [PATCHv3 4/6] evtchn: use a per-event channel lock for sending events David Vrabel
2015-06-18 11:20 ` Jan Beulich
2015-06-18 11:39 ` David Vrabel
2015-06-17 12:03 ` David Vrabel [this message]
2015-06-18 11:30 ` [PATCHv3 5/6] evtchn: remove the locking when unmasking an event channel Jan Beulich
2015-06-18 11:36 ` David Vrabel
2015-06-18 12:08 ` Jan Beulich
2015-06-18 12:17 ` David Vrabel
2015-06-17 12:03 ` [PATCHv3 6/6] evtchn: pad struct evtchn to 64 bytes David Vrabel
2015-06-18 11:31 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434542583-28073-6-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.