From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Tim Deegan <tim@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH RFC 2/5] blkif: document new blkback path xenstore node
Date: Wed, 17 Jun 2015 14:22:06 +0100 [thread overview]
Message-ID: <1434547326.13744.379.camel@citrix.com> (raw)
In-Reply-To: <20150601132405.GG19403@zion.uk.xensource.com>
On Mon, 2015-06-01 at 14:24 +0100, Wei Liu wrote:
> On Fri, May 22, 2015 at 11:18:55AM +0200, Roger Pau Monne wrote:
> > FreeBSD blkback uses the path xenstore node in order to fetch the path to
> > the underlying backing storage (either a block device or raw image). This
> > node is set by the hotplug scripts.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Jan Beulich <jbeulich@suse.com>
> > Cc: Tim Deegan <tim@xen.org>
> > ---
> > xen/include/public/io/blkif.h | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> > index 6baf7fb..b1e2245 100644
> > --- a/xen/include/public/io/blkif.h
> > +++ b/xen/include/public/io/blkif.h
> > @@ -89,8 +89,15 @@
> > * Values: string
> > *
> > * A free formatted string providing sufficient information for the
> > - * backend driver to open the backing device. (e.g. the path to the
> > - * file or block device representing the backing store.)
> > + * hotplug script to attach the device and provide a suitable
> > + * handler (ie: a block device) for blkback to use.
> > + *
> > + * path
> > + * Values: string
> > + * Notes: 11
> > + *
> > + * A free formatted string that contains the path to the backing device
> > + * for this blkback instance.
>
> Why can't FreeBSD use the same "physical-device" node as Linux and
> NetBSD do? AIUI from reading this doc "physical-device" node already
> covers both "file" and "block device", i.e. it's a superset of the
> proposed "path" node here.
I was about to ask the same thing in response to the first patch.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-06-17 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 9:18 [PATCH RFC 0/5] tools/FreeBSD: enable disk hotplug scripts Roger Pau Monne
2015-05-22 9:18 ` [PATCH RFC 1/5] libxl: only write physical-device on Linux and NetBSD Roger Pau Monne
2015-05-22 9:18 ` [PATCH RFC 2/5] blkif: document new blkback path xenstore node Roger Pau Monne
2015-06-01 13:24 ` Wei Liu
2015-06-02 15:22 ` Roger Pau Monné
2015-06-02 16:57 ` Wei Liu
2015-06-17 13:22 ` Ian Campbell [this message]
2015-05-22 9:18 ` [PATCH RFC 3/5] libxl/FreeBSD: write blkback "path" node Roger Pau Monne
2015-05-22 9:18 ` [PATCH RFC 4/5] hotplug/FreeBSD: add block hotplug script Roger Pau Monne
2015-05-22 9:18 ` [PATCH RFC 5/5] libxl/FreeBSD: add support for disk hotplug scripts Roger Pau Monne
2015-06-17 13:23 ` Ian Campbell
2015-06-17 14:57 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434547326.13744.379.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.