From: "Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: Peter Huewe <PeterHuewe@gmx.de>,
Ashley Lai <ashley@ashleylai.com>,
Vicky Lo <honclo2014@gmail.com>,
linux-kernel@vger.kernel.org,
"Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>,
Joy Latten <jmlatten@linux.vnet.ibm.com>
Subject: [PATCH v4 2/2] TPM: remove unnecessary little endian conversion
Date: Wed, 17 Jun 2015 18:17:09 -0400 [thread overview]
Message-ID: <1434579429-29449-2-git-send-email-honclo@linux.vnet.ibm.com> (raw)
In-Reply-To: <1434579429-29449-1-git-send-email-honclo@linux.vnet.ibm.com>
The base pointer for the event log is allocated in the local
kernel (in prom_instantiate_sml()), therefore it is already in
the host's endian byte order and requires no conversion.
The content of the 'basep' pointer in read_log() stores the
base address of the log. This patch ensures that it is correctly
implemented.
Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com>
Signed-off-by: Joy Latten <jmlatten@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm_of.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index c002d1b..62a22ce 100644
--- a/drivers/char/tpm/tpm_of.c
+++ b/drivers/char/tpm/tpm_of.c
@@ -24,7 +24,7 @@ int read_log(struct tpm_bios_log *log)
{
struct device_node *np;
const u32 *sizep;
- const __be64 *basep;
+ const u64 *basep;
if (log->bios_event_log != NULL) {
pr_err("%s: ERROR - Eventlog already initialized\n", __func__);
@@ -63,7 +63,7 @@ int read_log(struct tpm_bios_log *log)
log->bios_event_log_end = log->bios_event_log + *sizep;
- memcpy(log->bios_event_log, __va(be64_to_cpup(basep)), *sizep);
+ memcpy(log->bios_event_log, __va(*basep), *sizep);
return 0;
--
1.7.1
next prev parent reply other threads:[~2015-06-17 22:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 22:17 [PATCH v4 1/2] vTPM: support little endian guests Hon Ching(Vicky) Lo
2015-06-17 22:17 ` Hon Ching(Vicky) Lo [this message]
2015-06-18 13:23 ` [PATCH v4 2/2] TPM: remove unnecessary little endian conversion Ashley Lai
2015-06-29 18:52 ` Hon Ching(Vicky) Lo
2015-06-18 13:23 ` [PATCH v4 1/2] vTPM: support little endian guests Ashley Lai
2015-06-29 18:43 ` Hon Ching(Vicky) Lo
2015-06-29 18:51 ` Hon Ching(Vicky) Lo
2015-07-13 21:08 ` Peter Hüwe
2015-07-16 17:54 ` Hon Ching(Vicky) Lo
2015-07-16 18:43 ` Peter Hüwe
2015-07-17 20:07 ` Hon Ching(Vicky) Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434579429-29449-2-git-send-email-honclo@linux.vnet.ibm.com \
--to=honclo@linux.vnet.ibm.com \
--cc=PeterHuewe@gmx.de \
--cc=ashley@ashleylai.com \
--cc=honclo2014@gmail.com \
--cc=jmlatten@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.