From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5WuH-0002l8-Ek for qemu-devel@nongnu.org; Thu, 18 Jun 2015 06:18:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5WuE-000465-8y for qemu-devel@nongnu.org; Thu, 18 Jun 2015 06:18:49 -0400 Message-ID: <1434622723.4968.16.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 18 Jun 2015 12:18:43 +0200 In-Reply-To: <834587703.17443662.1434621536154.JavaMail.zimbra@redhat.com> References: <1434028677-26160-1-git-send-email-fziglio@redhat.com> <1434028677-26160-2-git-send-email-fziglio@redhat.com> <5581CA0E.6080906@msgid.tls.msk.ru> <834587703.17443662.1434621536154.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid negative values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frediano Ziglio Cc: qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org On Do, 2015-06-18 at 05:58 -0400, Frediano Ziglio wrote: > For the same reason there is the v >= l test. > The v >= l test state that the value can be out of range so it not always a constant in the range. > Adding the v < 0 check for every invalid value. As these are executed only for logging should not be a performance penalty. > I also hope the compiler is able to optimize > > if (v < 0 || v >= l) > > with > > if ((unsigned) v >= l) Just make v explicitly unsigned? cheers, Gerd