From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752938AbbFRPvQ (ORCPT ); Thu, 18 Jun 2015 11:51:16 -0400 Received: from smtprelay0245.hostedemail.com ([216.40.44.245]:60237 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754089AbbFRPvJ (ORCPT ); Thu, 18 Jun 2015 11:51:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2919:3138:3139:3140:3141:3142:3352:3622:3871:3876:4321:4605:5007:6261:8957:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: son52_6124673283e49 X-Filterd-Recvd-Size: 2140 Message-ID: <1434642666.2689.105.camel@perches.com> Subject: Re: [PATCH 1/5] staging: ft1000-usb: Fixed some issues with lines over 80 characters From: Joe Perches To: Peter Karlsson Cc: greg@kroah.com, marek.belisko@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 18 Jun 2015 08:51:06 -0700 In-Reply-To: <1434635461-24643-2-git-send-email-peter@zapto.se> References: <1434635461-24643-1-git-send-email-peter@zapto.se> <1434635461-24643-2-git-send-email-peter@zapto.se> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-06-18 at 15:50 +0200, Peter Karlsson wrote: > Fix checkpatch warnings about lines over 80 characters. [] > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c [] > @@ -414,12 +414,20 @@ static long ft1000_ioctl(struct file *file, unsigned int command, > unsigned long flags; > struct IOCTL_GET_VER get_ver_data; > struct IOCTL_GET_DSP_STAT get_stat_data; > - u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64, > - 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a, > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > - 0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00, > - 0x00, 0x01, 0x00, 0x00}; > + u8 ConnectionMsg[] = { > + 0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 7 bytes per line is unusual. 8 or 10 is more common.