From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5dYz-000250-NP for qemu-devel@nongnu.org; Thu, 18 Jun 2015 13:25:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5dYw-0007ED-6W for qemu-devel@nongnu.org; Thu, 18 Jun 2015 13:25:17 -0400 Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:35314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5dYw-0007D6-0V for qemu-devel@nongnu.org; Thu, 18 Jun 2015 13:25:14 -0400 Received: by pdbci14 with SMTP id ci14so12456663pdb.2 for ; Thu, 18 Jun 2015 10:25:13 -0700 (PDT) From: Peter Crosthwaite Date: Thu, 18 Jun 2015 10:24:53 -0700 Message-Id: <1434648295-30584-7-git-send-email-crosthwaite.peter@gmail.com> In-Reply-To: <1434648295-30584-1-git-send-email-crosthwaite.peter@gmail.com> References: <1434648295-30584-1-git-send-email-crosthwaite.peter@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v3 6/8] cpus: Change tcg_cpu_exec arg to cpu, not env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Crosthwaite , rth@twiddle.net, ehabkost@redhat.com, aurelien@aurel32.net, afaerber@suse.de The sole caller of this function navigates the cpu->env_ptr only for this function to take it back the cpu pointer straight away. Pass in cpu pointer instead and grab the env pointer locally in the function. Removes a core code usage of ENV_GET_CPU(). Reviewed-by: Andreas Färber Signed-off-by: Peter Crosthwaite --- Changed since v1: Add () to ENV_GET_CPU() in commit message --- cpus.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index b85fb5f..131fa3b 100644 --- a/cpus.c +++ b/cpus.c @@ -1343,9 +1343,9 @@ int vm_stop_force_state(RunState state) } } -static int tcg_cpu_exec(CPUArchState *env) +static int tcg_cpu_exec(CPUState *cpu) { - CPUState *cpu = ENV_GET_CPU(env); + CPUArchState *env = cpu->env_ptr; int ret; #ifdef CONFIG_PROFILER int64_t ti; @@ -1407,13 +1407,12 @@ static void tcg_exec_all(void) } for (; next_cpu != NULL && !exit_request; next_cpu = CPU_NEXT(next_cpu)) { CPUState *cpu = next_cpu; - CPUArchState *env = cpu->env_ptr; qemu_clock_enable(QEMU_CLOCK_VIRTUAL, (cpu->singlestep_enabled & SSTEP_NOTIMER) == 0); if (cpu_can_run(cpu)) { - r = tcg_cpu_exec(env); + r = tcg_cpu_exec(cpu); if (r == EXCP_DEBUG) { cpu_handle_guest_debug(cpu); break; -- 1.9.1