From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST v2 05/19] Refactor pxelinux configuration
Date: Fri, 19 Jun 2015 10:53:32 +0100 [thread overview]
Message-ID: <1434707612.28264.67.camel@citrix.com> (raw)
In-Reply-To: <21891.1204.390933.200005@mariner.uk.xensource.com>
On Thu, 2015-06-18 at 18:49 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 05/19] Refactor pxelinux configuration"):
> > The mechanism used to PXE boot can differ depending on the firmware
> > type. Therefore refactor into Osstest::TestSupport and key off a new
> > host property "firmware".
> >
> > Currently supported is "bios" (the default) and "uboot", both of which
> > use pxelinux.cfg style files.
> >
> > The default for the firmware property is "bios", hence no change for
> > any existing system (including those which use uboot, regardless of
> > whether they are now configured with the firmware proprty or not)
>
> > + return &{"setup_${firmware}_pxeboot"}($ho,$kern,$initrd,$dicmd,$hocmd,%xopts);
>
> Are you expecting to introduce setup_FIRMWARE_SOMETHINGELSE ?
I think initially I was initially expecting to but ended up not needing
to.
I will assume you would also prefer "setup_${firmware}_pxeboot_local" to
become "setup_pxeboot_local_${firmware}" (rather than "setup_pxeboot_
${firmware}_local").
> AFIACT not, in which case this name is quite confusing. Putting the
> variable part at the end would be much clearer:
> setup_pxeboot_${firmware}.
>
> > @@ -287,18 +288,8 @@ END
> > my $dicmd= join ' ', @dicmdline;
> > my $hocmd= join ' ', @hocmdline;
> ...
> > + $xopts{ipappend} = $ipappend;
> > + setup_pxeboot($ho, $kernel, "/$initrd", $dicmd, $hocmd, %xopts);
>
> Perhaps setup_pxeboot (which maybe should be renamed?) should do the
> joining ? You could pass \@dicmdline and \@hocmdline.
Good idea.
Do you think setup_pxeboot maybe ought to be setup_pxeboot_di or
something along those lines?
Ian.
next prev parent reply other threads:[~2015-06-19 9:53 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 16:24 [PATCH OSSTEST v2 00/19] Initial support for ARM64 Ian Campbell
2015-06-18 16:24 ` [PATCH OSSTEST v2 01/19] Introduce mg-pxe-loader-update Ian Campbell
2015-06-18 17:42 ` Ian Jackson
2015-06-19 10:44 ` Ian Campbell
2015-06-18 16:24 ` [PATCH OSSTEST v2 02/19] Debian: Preseed a EFI system partition during host install Ian Campbell
2015-06-18 17:44 ` Ian Jackson
2015-06-18 16:24 ` [PATCH OSSTEST v2 03/19] ts-host-install: Split initrd out of @installcmdline Ian Campbell
2015-06-18 17:53 ` Ian Jackson
2015-06-18 16:24 ` [PATCH OSSTEST v2 04/19] ts-host-install: split the "di" from the "host" command line Ian Campbell
2015-06-18 17:53 ` Ian Jackson
2015-06-18 16:24 ` [PATCH OSSTEST v2 05/19] Refactor pxelinux configuration Ian Campbell
2015-06-18 17:49 ` Ian Jackson
2015-06-19 9:53 ` Ian Campbell [this message]
2015-06-19 10:45 ` Ian Jackson
2015-06-19 10:55 ` Ian Campbell
2015-06-18 16:24 ` [PATCH OSSTEST v2 06/19] ts-host-install: Support UEFI PXE boot using grub.efi Ian Campbell
2015-06-18 17:51 ` Ian Jackson
2015-06-18 16:24 ` [PATCH OSSTEST v2 07/19] Enable chain loading to local disk for UEFI PXE systems Ian Campbell
2015-06-18 17:52 ` Ian Jackson
2015-06-19 9:57 ` Ian Campbell
2015-06-18 16:24 ` [PATCH OSSTEST v2 08/19] Add arm64 build and test jobs Ian Campbell
2015-06-18 17:54 ` Ian Jackson
2015-06-18 16:25 ` [PATCH OSSTEST v2 09/19] ts-kernel-build: Additional kernel options for Mustang Ian Campbell
2015-06-18 17:55 ` Ian Jackson
2015-06-19 10:04 ` Ian Campbell
2015-06-18 16:25 ` [PATCH OSSTEST v2 10/19] ts-host-install: Set dtbs in the non-special kernel case too Ian Campbell
2015-06-18 17:56 ` Ian Jackson
2015-06-19 10:07 ` Ian Campbell
2015-06-19 10:46 ` Ian Jackson
2015-06-18 16:25 ` [PATCH OSSTEST v2 11/19] Debian: Fixup UEFI boot order during install Ian Campbell
2015-06-18 17:57 ` Ian Jackson
2015-06-19 10:22 ` Ian Campbell
2015-06-19 11:02 ` Ian Jackson
2015-06-19 11:15 ` Ian Campbell
2015-06-18 16:25 ` [PATCH OSSTEST v2 12/19] ts-kernel-build: Support --reuse to keep same build tree Ian Campbell
2015-06-18 17:58 ` Ian Jackson
2015-06-19 9:40 ` Ian Campbell
2015-06-18 16:25 ` [PATCH OSSTEST v2 13/19] standalone: Prefer ./standalone.config to $HOME/.xen-osstest/config Ian Campbell
2015-06-18 17:59 ` Ian Jackson
2015-06-19 10:22 ` Ian Campbell
2015-06-19 10:24 ` Ian Campbell
2015-06-19 11:04 ` Ian Jackson
2015-06-19 11:08 ` Ian Campbell
2015-06-18 16:25 ` [PATCH OSSTEST v2 14/19] Debian: grub2: Log full line range of menuentry and submenu entries Ian Campbell
2015-06-18 18:00 ` Ian Jackson
2015-06-18 16:25 ` [PATCH OSSTEST v2 15/19] Debian: grub2: Use GRUB_CMDLINE_LINUX_XEN_REPLACE(_DEFAULT) Ian Campbell
2015-06-18 18:02 ` Ian Jackson
2015-06-18 16:25 ` [PATCH OSSTEST v2 16/19] Collect xen.efi into xendist and install in appropriate place Ian Campbell
2015-06-18 18:04 ` Ian Jackson
2015-06-18 16:25 ` [PATCH OSSTEST v2 17/19] Debian: Ignore xen-syms entries in grub.cfg Ian Campbell
2015-06-18 18:04 ` Ian Jackson
2015-06-19 9:44 ` Ian Campbell
2015-06-18 16:25 ` [PATCH OSSTEST v2 18/19] Debian: Collect kernel command line from grub.cfg Ian Campbell
2015-06-18 18:05 ` Ian Jackson
2015-06-18 16:25 ` [PATCH OSSTEST v2 19/19] Debian: Arrange to be able to chainload a xen.efi from grub2 Ian Campbell
2015-06-18 18:11 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434707612.28264.67.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.