From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 02/11]
 mg-debian-installer-update: updates to better handle Jessie onwards.
Date: Fri, 19 Jun 2015 14:50:34 +0100
Message-ID: <1434721834.28264.133.camel@citrix.com>
References: <1434546404-2036-1-git-send-email-wei.liu2@citrix.com>
	<1434546404-2036-3-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6055698ae=Ian.Campbell@citrix.com>)
	id 1Z5wgp-0004Em-Rp
	for xen-devel@lists.xenproject.org; Fri, 19 Jun 2015 13:50:39 +0000
In-Reply-To: <1434546404-2036-3-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-17 at 14:06 +0100, Wei Liu wrote:
> +case $suite_$arch in

Sorry, this is buggy, it looks for a variable named "suite_" which
doesn't exist and so nothing matches. It needs this:

diff --git a/mg-debian-installer-update b/mg-debian-installer-update
index b9b1146..6a26675 100755
--- a/mg-debian-installer-update
+++ b/mg-debian-installer-update
@@ -102,7 +102,7 @@ done
 # Some platforms require a newer kernel than is in Debian. Construct
 # something suitable from the latest kernel ($bpok=flavour) in
 # backports.
-case $suite_$arch in
+case ${suite}_${arch} in
     wheezy_armhf) bpok=armmp; need_initramfs=y;;
 esac
 if [ x$bpok != x ]; then

Ian.