From: benoar@dolka.fr (Benjamin Cama)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Re: Linkstation Mini and __machine_arch_type problem, not booting since 3.8
Date: Sat, 20 Jun 2015 03:01:59 +0200 [thread overview]
Message-ID: <1434762119.5177.15.camel@dolka.fr> (raw)
In-Reply-To: <20150619154439.GS7557@n2100.arm.linux.org.uk>
Le vendredi 19 juin 2015 ? 16:44 +0100, Russell King - ARM Linux a
?crit :
> On Fri, Jun 19, 2015 at 03:46:45PM +0200, Benjamin Cama wrote:
> > Hi Russell,
> > Do not misunderstand me: I am not at all for keeping the situation like
> > this! What I ask is just for users to be notified of this new requirement:
> > for my case, my board simply couldn't boot anymore, without any
> > explanation.
>
> It's not a new requirement. It's something that's been there all along,
> and is finally starting to bite places where it never used to bite before.
> It's a latent bug in platform code, that's all.
>
> This "IRQ0 is bad" has been known for quite some while - you've already
> been pointed at Linus' rant about it, dated 25 Jan 2007. If you do a bit
> of research, you'll find that the orion code was contributed _after_ that
> date.
Yes, I understand.
> While it's easy to stick a warning into orion_irq_init() (or whatever the
> function is called), it's utterly pointless now that it's been found -
> just fix all the users of orion_irq_init() now and be done with it.
Well, I could do that but I do not have all the hardware to test it on.
> As for "shouldn't this have had a warning in the past", well, maybe, but
> consider this task:
>
> > Please go and look at the other mach-* directories, and find
> > all those which might use IRQ0, and arrange for them to print
> > a warning.
>
> I'm sure you'll see what a task it is that you're asking for.
>
> What you're asking for is actually unreasonable.
I was not at all asking for that, sorry for the misunderstanding again:
I was imagining putting a warning or BUG_ON in e.g.
irq_alloc_generic_chip (and just one place; I am not even sure this is
the right one: I am quite a beginner in kernel code, to put things in
context). I tried that but with bad results (just a hard reboot for
BUG_ON without message) maybe because without earlyprintk, it happens
too early in the boot process to display anything to the user. So this
is a bad idea indeed.
> (I am aware that Dove broke exactly for this reason, and I've been
> carrying a patch since December 2014 to fix Dove - but I just don't have
> the time to get it merged - like most of my other Dove work.)
I tried a quick grep'ing of platforms allocating IRQ0, and all Orion is
indeed doing it, as well as davinci. But apart from them, the rest
seems OK, so the platforms having this problem seem indeed to be very
few.
Regards,
--
benjamin
next prev parent reply other threads:[~2015-06-20 1:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 13:51 Linkstation Mini and __machine_arch_type problem, not booting since 3.8 Benjamin Cama
2015-06-16 9:20 ` Benjamin Cama
2015-06-18 2:12 ` [PATCH] " Benjamin Cama
2015-06-18 7:52 ` Marc Zyngier
2015-06-18 8:14 ` Arnd Bergmann
2015-06-18 13:23 ` Andrew Lunn
2015-06-19 1:38 ` Benjamin Cama
2015-06-19 9:13 ` Marc Zyngier
2015-06-19 12:16 ` Benjamin Cama
2015-06-19 13:01 ` Jason Cooper
2015-06-19 13:13 ` Russell King - ARM Linux
2015-06-19 13:46 ` Benjamin Cama
2015-06-19 15:25 ` Jason Cooper
2015-06-19 15:48 ` Russell King - ARM Linux
2015-06-19 17:13 ` Jason Cooper
2015-06-21 17:37 ` Benjamin Cama
2015-06-22 12:08 ` Jason Cooper
2015-06-22 17:49 ` Benjamin Cama
2015-06-22 17:58 ` Russell King - ARM Linux
2015-06-22 18:04 ` Jason Cooper
[not found] ` <1436710916.5657.169.camel@dolka.fr>
2015-07-14 14:25 ` [PATCH] ARM: orion5x: fix legacy orion5x IRQ numbers Benjamin Cama
2015-07-14 20:50 ` Arnd Bergmann
2015-08-14 15:46 ` Gregory CLEMENT
2015-06-19 15:44 ` [PATCH] Re: Linkstation Mini and __machine_arch_type problem, not booting since 3.8 Russell King - ARM Linux
2015-06-20 1:01 ` Benjamin Cama [this message]
2015-06-18 8:12 ` Gregory CLEMENT
2015-06-19 1:50 ` Benjamin Cama
2015-06-19 9:33 ` Gregory CLEMENT
2015-06-19 11:41 ` Jason Cooper
2015-06-20 0:28 ` Benjamin Cama
2015-06-20 14:36 ` Andrew Lunn
2015-06-21 17:36 ` Benjamin Cama
2015-06-21 20:07 ` Andrew Lunn
[not found] ` <1434995000.5657.42.camel@dolka.fr>
2015-06-22 18:23 ` SERIAL_OF_PLATFORM default setting for DT headless systems Jason Cooper
2015-06-22 19:42 ` Benjamin Cama
2015-06-22 12:00 ` Linkstation Mini and __machine_arch_type problem, not booting since 3.8 Jason Cooper
2015-06-22 17:44 ` Benjamin Cama
2015-06-19 22:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434762119.5177.15.camel@dolka.fr \
--to=benoar@dolka.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.