From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>, Nic Bellinger <nab@daterainc.com>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 5/6] target: Send UA upon LUN RESET tmr completion
Date: Tue, 23 Jun 2015 00:54:40 -0700 [thread overview]
Message-ID: <1435046080.7460.24.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <20150619130601.GB7783@lst.de>
On Fri, 2015-06-19 at 15:06 +0200, Christoph Hellwig wrote:
> On Thu, Jun 11, 2015 at 10:01:28AM +0200, Hannes Reinecke wrote:
> > SAM mandates that an BUS DEVICE RESET FUNCTION OCCURRED
> > UA needs to be send after a LUN RESET tmr has completed.
> >
> > Signed-off-by: Hannes Reinecke <hare@suse.de>
> > ---
> > drivers/target/target_core_transport.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> > index a0e0d3a..bb60c0c4 100644
> > --- a/drivers/target/target_core_transport.c
> > +++ b/drivers/target/target_core_transport.c
> > @@ -3064,6 +3064,17 @@ static void target_tmr_work(struct work_struct *work)
> > ret = core_tmr_lun_reset(dev, tmr, NULL, NULL);
> > tmr->response = (!ret) ? TMR_FUNCTION_COMPLETE :
> > TMR_FUNCTION_REJECTED;
> > + if (tmr->response == TMR_FUNCTION_COMPLETE) {
> > + struct se_dev_entry *deve;
> > +
> > + rcu_read_lock();
> > + deve = target_nacl_find_deve(cmd->se_sess->se_node_acl,
> > + cmd->orig_fe_lun);
> > + if (deve)
> > + core_scsi3_ua_allocate(deve, 0x29,
> > + ASCQ_29H_BUS_DEVICE_RESET_FUNCTION_OCCURRED);
> > + rcu_read_unlock();
>
> This should use the target_ua_allocate_lun helper.
Fixed.
next prev parent reply other threads:[~2015-06-23 7:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:01 [PATCH 0/6] target: Update UA handling Hannes Reinecke
2015-06-11 8:01 ` [PATCH 1/6] target_core_alua: Correct UA handling when switching states Hannes Reinecke
2015-06-11 8:01 ` [PATCH 2/6] target: Remove 'ua_nacl' pointer from se_ua structure Hannes Reinecke
2015-06-11 8:01 ` [PATCH 3/6] target: use 'se_dev_entry' when allocating UAs Hannes Reinecke
2015-06-17 6:06 ` Nicholas A. Bellinger
2015-06-17 6:20 ` Hannes Reinecke
2015-06-11 8:01 ` [PATCH 4/6] target: Send UA on ALUA target port group change Hannes Reinecke
2015-06-19 13:05 ` Christoph Hellwig
2015-06-19 13:09 ` Hannes Reinecke
2015-06-19 13:13 ` Christoph Hellwig
2015-06-23 7:54 ` Nicholas A. Bellinger
2015-06-11 8:01 ` [PATCH 5/6] target: Send UA upon LUN RESET tmr completion Hannes Reinecke
2015-06-19 13:06 ` Christoph Hellwig
2015-06-19 13:07 ` Hannes Reinecke
2015-06-23 7:54 ` Nicholas A. Bellinger [this message]
2015-06-11 8:01 ` [PATCH 6/6] target: Send UA when changing LUN inventory Hannes Reinecke
2015-06-19 13:07 ` Christoph Hellwig
2015-06-19 13:10 ` Hannes Reinecke
2015-06-23 7:56 ` Nicholas A. Bellinger
2015-06-17 6:10 ` [PATCH 0/6] target: Update UA handling Nicholas A. Bellinger
2015-06-17 6:25 ` Hannes Reinecke
2015-06-17 7:01 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435046080.7460.24.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@daterainc.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.