From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963AbbF2Sw6 (ORCPT ); Mon, 29 Jun 2015 14:52:58 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:35850 "EHLO e28smtp03.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbbF2Swv (ORCPT ); Mon, 29 Jun 2015 14:52:51 -0400 X-Helo: d28dlp01.in.ibm.com X-MailFrom: honclo@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] TPM: remove unnecessary little endian conversion From: "Hon Ching(Vicky) Lo" To: tpmdd-devel@lists.sourceforge.net Cc: Peter Huewe , Ashley Lai , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten In-Reply-To: <1434579429-29449-2-git-send-email-honclo@linux.vnet.ibm.com> References: <1434579429-29449-1-git-send-email-honclo@linux.vnet.ibm.com> <1434579429-29449-2-git-send-email-honclo@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 29 Jun 2015 14:52:41 -0400 Message-ID: <1435603961.26255.20.camel@vtpm2014.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15062918-0009-0000-0000-0000063C3F11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, Please also commit this patch, if you accept it as well. Thanks, Vicky -------- Forwarded Message -------- From: Ashley Lai To: Hon Ching(Vicky) Lo Cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Ashley Lai , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten >Subject: Re: [PATCH v4 2/2] TPM: remove unnecessary little endian conversion > Date: Thu, 18 Jun 2015 08:23:33 -0500 (CDT) > Looks good. > Reviewed-by: Ashley Lai > Ashley Lai On Wed, 2015-06-17 at 18:17 -0400, Hon Ching(Vicky) Lo wrote: > The base pointer for the event log is allocated in the local > kernel (in prom_instantiate_sml()), therefore it is already in > the host's endian byte order and requires no conversion. > > The content of the 'basep' pointer in read_log() stores the > base address of the log. This patch ensures that it is correctly > implemented. > > Signed-off-by: Hon Ching(Vicky) Lo > Signed-off-by: Joy Latten > --- > drivers/char/tpm/tpm_of.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c > index c002d1b..62a22ce 100644 > --- a/drivers/char/tpm/tpm_of.c > +++ b/drivers/char/tpm/tpm_of.c > @@ -24,7 +24,7 @@ int read_log(struct tpm_bios_log *log) > { > struct device_node *np; > const u32 *sizep; > - const __be64 *basep; > + const u64 *basep; > > if (log->bios_event_log != NULL) { > pr_err("%s: ERROR - Eventlog already initialized\n", __func__); > @@ -63,7 +63,7 @@ int read_log(struct tpm_bios_log *log) > > log->bios_event_log_end = log->bios_event_log + *sizep; > > - memcpy(log->bios_event_log, __va(be64_to_cpup(basep)), *sizep); > + memcpy(log->bios_event_log, __va(*basep), *sizep); > > return 0; >