From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753879AbbGAJnQ (ORCPT ); Wed, 1 Jul 2015 05:43:16 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:36564 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbbGAJme (ORCPT ); Wed, 1 Jul 2015 05:42:34 -0400 From: Tomeu Vizoso To: linux-kernel@vger.kernel.org Cc: Mark Brown , linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, "Rafael J. Wysocki" , alsa-devel@alsa-project.org, Tomeu Vizoso , Greg Kroah-Hartman Subject: [PATCH v2 02/12] device: property: find dependencies of a firmware node Date: Wed, 1 Jul 2015 11:40:57 +0200 Message-Id: <1435743667-11987-3-git-send-email-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 2.4.1 In-Reply-To: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adds API that allows callers to find out what other firmware nodes a node depends on. Implementors of bindings documentation can register callbacks that return the dependencies of a node. Dependency information can be used to change the order in which devices are probed, or to print a warning when a device node is going to be probed without all its dependencies fulfilled. Signed-off-by: Tomeu Vizoso --- Changes in v2: - Allow bindings implementations register a function instead of using class callbacks, as not only subsystems implement firmware bindings. drivers/base/property.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/fwnode.h | 5 +++ include/linux/property.h | 12 +++++++ 3 files changed, 108 insertions(+) diff --git a/drivers/base/property.c b/drivers/base/property.c index 8ead1ba..9d38ede 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -19,7 +19,13 @@ #include #include +struct dependency_parser { + struct list_head parser; + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps); +}; + static bool fwnode_match_enable = false; +static LIST_HEAD(dependency_parsers); /** * device_add_property_set - Add a collection of properties to a device object. @@ -553,6 +559,27 @@ bool device_dma_is_coherent(struct device *dev) EXPORT_SYMBOL_GPL(device_dma_is_coherent); /** + * fwnode_add_dependency - add firmware node to the passed dependency list + * @fwnode: Firmware node to add to dependency list + * @list: Dependency list to add the fwnode to + */ +void fwnode_add_dependency(struct fwnode_handle *fwnode, + struct list_head *list) +{ + struct fwnode_dependency *dep; + + dep = kzalloc(sizeof(*dep), GFP_KERNEL); + if (!dep) + return; + + INIT_LIST_HEAD(&dep->dependency); + dep->fwnode = fwnode; + + list_add_tail(&dep->dependency, list); +} +EXPORT_SYMBOL_GPL(fwnode_add_dependency); + +/** * fwnode_get_parent - return the parent node of a device node * @fwnode: Device node to find the parent node of */ @@ -600,6 +627,70 @@ bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible) EXPORT_SYMBOL_GPL(fwnode_is_compatible); /** + * fwnode_add_dependency_parser - register dependency parser + * @func: Function that will be called to find out dependencies of a node + * + * Registers a callback that will be called when collecting the dependencies + * of a firmware node. The callback should inspect the properties of the node + * and call fwnode_add_dependency() for each dependency it recognizes, from + * the bindings documentation. + */ +void fwnode_add_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)) +{ + struct dependency_parser *parser; + + parser = kzalloc(sizeof(*parser), GFP_KERNEL); + if (!parser) + return; + + INIT_LIST_HEAD(&parser->parser); + parser->func = func; + + list_add_tail(&parser->parser, &dependency_parsers); +} +EXPORT_SYMBOL_GPL(fwnode_add_dependency_parser); + +/** + * fwnode_remove_dependency_parser - unregister dependency parser + * @func: Function that was to be called to find out dependencies of a node + */ +void fwnode_remove_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)) +{ + struct dependency_parser *parser, *tmp; + + list_for_each_entry_safe(parser, tmp, &dependency_parsers, parser) { + if (parser->func == func) { + list_del(&parser->parser); + kfree(parser); + return; + } + } +} +EXPORT_SYMBOL_GPL(fwnode_remove_dependency_parser); + +/** + * fwnode_get_dependencies - find out what dependencies a firmware node has + * @fwnode: firmware node to find its dependencies + * @deps: list of struct fwnode_dependency in which dependencies will be placed + */ +void fwnode_get_dependencies(struct fwnode_handle *fwnode, + struct list_head *deps) +{ + struct dependency_parser *parser; + struct fwnode_handle *child; + + list_for_each_entry(parser, &dependency_parsers, parser) + parser->func(fwnode, deps); + + /* Some device nodes will have dependencies in non-device sub-nodes */ + fwnode_for_each_child_node(fwnode, child) + if (!fwnode_property_present(child, "compatible")) + fwnode_get_dependencies(child, deps); +} + +/** * fwnode_driver_match_device - Tell if a driver matches a device. * @drv: the device_driver structure to test * @dev: the device structure to match against diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 0408545..68ab558 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -24,4 +24,9 @@ struct fwnode_handle { struct fwnode_handle *secondary; }; +struct fwnode_dependency { + struct fwnode_handle *fwnode; + struct list_head dependency; +}; + #endif diff --git a/include/linux/property.h b/include/linux/property.h index 4e453c4..b8b86ea 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -86,6 +86,18 @@ bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible); bool fwnode_driver_match_device(struct device *dev, const struct device_driver *drv); +void fwnode_add_dependency(struct fwnode_handle *fwnode, + struct list_head *list); + +void fwnode_add_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)); + +void fwnode_remove_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)); + +void fwnode_get_dependencies(struct fwnode_handle *fwnode, + struct list_head *list); + unsigned int device_get_child_node_count(struct device *dev); static inline bool device_property_read_bool(struct device *dev, -- 2.4.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomeu Vizoso Subject: [PATCH v2 02/12] device: property: find dependencies of a firmware node Date: Wed, 1 Jul 2015 11:40:57 +0200 Message-ID: <1435743667-11987-3-git-send-email-tomeu.vizoso@collabora.com> References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Tomeu Vizoso , linux-gpio@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, Mark Brown , linux-pwm@vger.kernel.org List-Id: linux-acpi@vger.kernel.org QWRkcyBBUEkgdGhhdCBhbGxvd3MgY2FsbGVycyB0byBmaW5kIG91dCB3aGF0IG90aGVyIGZpcm13 YXJlIG5vZGVzIGEKbm9kZSBkZXBlbmRzIG9uLgoKSW1wbGVtZW50b3JzIG9mIGJpbmRpbmdzIGRv Y3VtZW50YXRpb24gY2FuIHJlZ2lzdGVyIGNhbGxiYWNrcyB0aGF0CnJldHVybiB0aGUgZGVwZW5k ZW5jaWVzIG9mIGEgbm9kZS4KCkRlcGVuZGVuY3kgaW5mb3JtYXRpb24gY2FuIGJlIHVzZWQgdG8g Y2hhbmdlIHRoZSBvcmRlciBpbiB3aGljaCBkZXZpY2VzCmFyZSBwcm9iZWQsIG9yIHRvIHByaW50 IGEgd2FybmluZyB3aGVuIGEgZGV2aWNlIG5vZGUgaXMgZ29pbmcgdG8gYmUKcHJvYmVkIHdpdGhv dXQgYWxsIGl0cyBkZXBlbmRlbmNpZXMgZnVsZmlsbGVkLgoKU2lnbmVkLW9mZi1ieTogVG9tZXUg Vml6b3NvIDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4KLS0tCgpDaGFuZ2VzIGluIHYyOgot IEFsbG93IGJpbmRpbmdzIGltcGxlbWVudGF0aW9ucyByZWdpc3RlciBhIGZ1bmN0aW9uIGluc3Rl YWQgb2YgdXNpbmcKICBjbGFzcyBjYWxsYmFja3MsIGFzIG5vdCBvbmx5IHN1YnN5c3RlbXMgaW1w bGVtZW50IGZpcm13YXJlIGJpbmRpbmdzLgoKIGRyaXZlcnMvYmFzZS9wcm9wZXJ0eS5jICB8IDkx ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogaW5jbHVk ZS9saW51eC9md25vZGUuaCAgIHwgIDUgKysrCiBpbmNsdWRlL2xpbnV4L3Byb3BlcnR5LmggfCAx MiArKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDEwOCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvZHJpdmVycy9iYXNlL3Byb3BlcnR5LmMgYi9kcml2ZXJzL2Jhc2UvcHJvcGVydHkuYwppbmRl eCA4ZWFkMWJhLi45ZDM4ZWRlIDEwMDY0NAotLS0gYS9kcml2ZXJzL2Jhc2UvcHJvcGVydHkuYwor KysgYi9kcml2ZXJzL2Jhc2UvcHJvcGVydHkuYwpAQCAtMTksNyArMTksMTMgQEAKICNpbmNsdWRl IDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KICNpbmNsdWRlIDxsaW51eC9wcm9wZXJ0eS5oPgog CitzdHJ1Y3QgZGVwZW5kZW5jeV9wYXJzZXIgeworCXN0cnVjdCBsaXN0X2hlYWQgcGFyc2VyOwor CXZvaWQgKCpmdW5jKShzdHJ1Y3QgZndub2RlX2hhbmRsZSAqZndub2RlLCBzdHJ1Y3QgbGlzdF9o ZWFkICpkZXBzKTsKK307CisKIHN0YXRpYyBib29sIGZ3bm9kZV9tYXRjaF9lbmFibGUgPSBmYWxz ZTsKK3N0YXRpYyBMSVNUX0hFQUQoZGVwZW5kZW5jeV9wYXJzZXJzKTsKIAogLyoqCiAgKiBkZXZp Y2VfYWRkX3Byb3BlcnR5X3NldCAtIEFkZCBhIGNvbGxlY3Rpb24gb2YgcHJvcGVydGllcyB0byBh IGRldmljZSBvYmplY3QuCkBAIC01NTMsNiArNTU5LDI3IEBAIGJvb2wgZGV2aWNlX2RtYV9pc19j b2hlcmVudChzdHJ1Y3QgZGV2aWNlICpkZXYpCiBFWFBPUlRfU1lNQk9MX0dQTChkZXZpY2VfZG1h X2lzX2NvaGVyZW50KTsKIAogLyoqCisgKiBmd25vZGVfYWRkX2RlcGVuZGVuY3kgLSBhZGQgZmly bXdhcmUgbm9kZSB0byB0aGUgcGFzc2VkIGRlcGVuZGVuY3kgbGlzdAorICogQGZ3bm9kZTogRmly bXdhcmUgbm9kZSB0byBhZGQgdG8gZGVwZW5kZW5jeSBsaXN0CisgKiBAbGlzdDogRGVwZW5kZW5j eSBsaXN0IHRvIGFkZCB0aGUgZndub2RlIHRvCisgKi8KK3ZvaWQgZndub2RlX2FkZF9kZXBlbmRl bmN5KHN0cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGUsCisJCQkgICBzdHJ1Y3QgbGlzdF9oZWFk ICpsaXN0KQoreworCXN0cnVjdCBmd25vZGVfZGVwZW5kZW5jeSAqZGVwOworCisJZGVwID0ga3ph bGxvYyhzaXplb2YoKmRlcCksIEdGUF9LRVJORUwpOworCWlmICghZGVwKQorCQlyZXR1cm47CisK KwlJTklUX0xJU1RfSEVBRCgmZGVwLT5kZXBlbmRlbmN5KTsKKwlkZXAtPmZ3bm9kZSA9IGZ3bm9k ZTsKKworCWxpc3RfYWRkX3RhaWwoJmRlcC0+ZGVwZW5kZW5jeSwgbGlzdCk7Cit9CitFWFBPUlRf U1lNQk9MX0dQTChmd25vZGVfYWRkX2RlcGVuZGVuY3kpOworCisvKioKICAqIGZ3bm9kZV9nZXRf cGFyZW50IC0gcmV0dXJuIHRoZSBwYXJlbnQgbm9kZSBvZiBhIGRldmljZSBub2RlCiAgKiBAZndu b2RlOiBEZXZpY2Ugbm9kZSB0byBmaW5kIHRoZSBwYXJlbnQgbm9kZSBvZgogICovCkBAIC02MDAs NiArNjI3LDcwIEBAIGJvb2wgZndub2RlX2lzX2NvbXBhdGlibGUoc3RydWN0IGZ3bm9kZV9oYW5k bGUgKmZ3bm9kZSwgY29uc3QgY2hhciAqY29tcGF0aWJsZSkKIEVYUE9SVF9TWU1CT0xfR1BMKGZ3 bm9kZV9pc19jb21wYXRpYmxlKTsKIAogLyoqCisgKiBmd25vZGVfYWRkX2RlcGVuZGVuY3lfcGFy c2VyIC0gcmVnaXN0ZXIgZGVwZW5kZW5jeSBwYXJzZXIKKyAqIEBmdW5jOiBGdW5jdGlvbiB0aGF0 IHdpbGwgYmUgY2FsbGVkIHRvIGZpbmQgb3V0IGRlcGVuZGVuY2llcyBvZiBhIG5vZGUKKyAqCisg KiBSZWdpc3RlcnMgYSBjYWxsYmFjayB0aGF0IHdpbGwgYmUgY2FsbGVkIHdoZW4gY29sbGVjdGlu ZyB0aGUgZGVwZW5kZW5jaWVzCisgKiBvZiBhIGZpcm13YXJlIG5vZGUuIFRoZSBjYWxsYmFjayBz aG91bGQgaW5zcGVjdCB0aGUgcHJvcGVydGllcyBvZiB0aGUgbm9kZQorICogYW5kIGNhbGwgZndu b2RlX2FkZF9kZXBlbmRlbmN5KCkgZm9yIGVhY2ggZGVwZW5kZW5jeSBpdCByZWNvZ25pemVzLCBm cm9tCisgKiB0aGUgYmluZGluZ3MgZG9jdW1lbnRhdGlvbi4KKyAqLwordm9pZCBmd25vZGVfYWRk X2RlcGVuZGVuY3lfcGFyc2VyKAorCXZvaWQgKCpmdW5jKShzdHJ1Y3QgZndub2RlX2hhbmRsZSAq Zndub2RlLCBzdHJ1Y3QgbGlzdF9oZWFkICpkZXBzKSkKK3sKKwlzdHJ1Y3QgZGVwZW5kZW5jeV9w YXJzZXIgKnBhcnNlcjsKKworCXBhcnNlciA9IGt6YWxsb2Moc2l6ZW9mKCpwYXJzZXIpLCBHRlBf S0VSTkVMKTsKKwlpZiAoIXBhcnNlcikKKwkJcmV0dXJuOworCisJSU5JVF9MSVNUX0hFQUQoJnBh cnNlci0+cGFyc2VyKTsKKwlwYXJzZXItPmZ1bmMgPSBmdW5jOworCisJbGlzdF9hZGRfdGFpbCgm cGFyc2VyLT5wYXJzZXIsICZkZXBlbmRlbmN5X3BhcnNlcnMpOworfQorRVhQT1JUX1NZTUJPTF9H UEwoZndub2RlX2FkZF9kZXBlbmRlbmN5X3BhcnNlcik7CisKKy8qKgorICogZndub2RlX3JlbW92 ZV9kZXBlbmRlbmN5X3BhcnNlciAtIHVucmVnaXN0ZXIgZGVwZW5kZW5jeSBwYXJzZXIKKyAqIEBm dW5jOiBGdW5jdGlvbiB0aGF0IHdhcyB0byBiZSBjYWxsZWQgdG8gZmluZCBvdXQgZGVwZW5kZW5j aWVzIG9mIGEgbm9kZQorICovCit2b2lkIGZ3bm9kZV9yZW1vdmVfZGVwZW5kZW5jeV9wYXJzZXIo CisJdm9pZCAoKmZ1bmMpKHN0cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGUsIHN0cnVjdCBsaXN0 X2hlYWQgKmRlcHMpKQoreworCXN0cnVjdCBkZXBlbmRlbmN5X3BhcnNlciAqcGFyc2VyLCAqdG1w OworCisJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHBhcnNlciwgdG1wLCAmZGVwZW5kZW5jeV9w YXJzZXJzLCBwYXJzZXIpIHsKKwkJaWYgKHBhcnNlci0+ZnVuYyA9PSBmdW5jKSB7CisJCQlsaXN0 X2RlbCgmcGFyc2VyLT5wYXJzZXIpOworCQkJa2ZyZWUocGFyc2VyKTsKKwkJCXJldHVybjsKKwkJ fQorCX0KK30KK0VYUE9SVF9TWU1CT0xfR1BMKGZ3bm9kZV9yZW1vdmVfZGVwZW5kZW5jeV9wYXJz ZXIpOworCisvKioKKyAqIGZ3bm9kZV9nZXRfZGVwZW5kZW5jaWVzIC0gZmluZCBvdXQgd2hhdCBk ZXBlbmRlbmNpZXMgYSBmaXJtd2FyZSBub2RlIGhhcworICogQGZ3bm9kZTogZmlybXdhcmUgbm9k ZSB0byBmaW5kIGl0cyBkZXBlbmRlbmNpZXMKKyAqIEBkZXBzOiBsaXN0IG9mIHN0cnVjdCBmd25v ZGVfZGVwZW5kZW5jeSBpbiB3aGljaCBkZXBlbmRlbmNpZXMgd2lsbCBiZSBwbGFjZWQKKyAqLwor dm9pZCBmd25vZGVfZ2V0X2RlcGVuZGVuY2llcyhzdHJ1Y3QgZndub2RlX2hhbmRsZSAqZndub2Rl LAorCQkJICAgICBzdHJ1Y3QgbGlzdF9oZWFkICpkZXBzKQoreworCXN0cnVjdCBkZXBlbmRlbmN5 X3BhcnNlciAqcGFyc2VyOworCXN0cnVjdCBmd25vZGVfaGFuZGxlICpjaGlsZDsKKworCWxpc3Rf Zm9yX2VhY2hfZW50cnkocGFyc2VyLCAmZGVwZW5kZW5jeV9wYXJzZXJzLCBwYXJzZXIpCisJCXBh cnNlci0+ZnVuYyhmd25vZGUsIGRlcHMpOworCisJLyogU29tZSBkZXZpY2Ugbm9kZXMgd2lsbCBo YXZlIGRlcGVuZGVuY2llcyBpbiBub24tZGV2aWNlIHN1Yi1ub2RlcyAqLworCWZ3bm9kZV9mb3Jf ZWFjaF9jaGlsZF9ub2RlKGZ3bm9kZSwgY2hpbGQpCisJCWlmICghZndub2RlX3Byb3BlcnR5X3By ZXNlbnQoY2hpbGQsICJjb21wYXRpYmxlIikpCisJCQlmd25vZGVfZ2V0X2RlcGVuZGVuY2llcyhj aGlsZCwgZGVwcyk7Cit9CisKKy8qKgogICogZndub2RlX2RyaXZlcl9tYXRjaF9kZXZpY2UgLSBU ZWxsIGlmIGEgZHJpdmVyIG1hdGNoZXMgYSBkZXZpY2UuCiAgKiBAZHJ2OiB0aGUgZGV2aWNlX2Ry aXZlciBzdHJ1Y3R1cmUgdG8gdGVzdAogICogQGRldjogdGhlIGRldmljZSBzdHJ1Y3R1cmUgdG8g bWF0Y2ggYWdhaW5zdApkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9md25vZGUuaCBiL2luY2x1 ZGUvbGludXgvZndub2RlLmgKaW5kZXggMDQwODU0NS4uNjhhYjU1OCAxMDA2NDQKLS0tIGEvaW5j bHVkZS9saW51eC9md25vZGUuaAorKysgYi9pbmNsdWRlL2xpbnV4L2Z3bm9kZS5oCkBAIC0yNCw0 ICsyNCw5IEBAIHN0cnVjdCBmd25vZGVfaGFuZGxlIHsKIAlzdHJ1Y3QgZndub2RlX2hhbmRsZSAq c2Vjb25kYXJ5OwogfTsKIAorc3RydWN0IGZ3bm9kZV9kZXBlbmRlbmN5IHsKKwlzdHJ1Y3QgZndu b2RlX2hhbmRsZSAqZndub2RlOworCXN0cnVjdCBsaXN0X2hlYWQgZGVwZW5kZW5jeTsKK307CisK ICNlbmRpZgpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9wcm9wZXJ0eS5oIGIvaW5jbHVkZS9s aW51eC9wcm9wZXJ0eS5oCmluZGV4IDRlNDUzYzQuLmI4Yjg2ZWEgMTAwNjQ0Ci0tLSBhL2luY2x1 ZGUvbGludXgvcHJvcGVydHkuaAorKysgYi9pbmNsdWRlL2xpbnV4L3Byb3BlcnR5LmgKQEAgLTg2 LDYgKzg2LDE4IEBAIGJvb2wgZndub2RlX2lzX2NvbXBhdGlibGUoc3RydWN0IGZ3bm9kZV9oYW5k bGUgKmZ3bm9kZSwgY29uc3QgY2hhciAqY29tcGF0aWJsZSk7CiBib29sIGZ3bm9kZV9kcml2ZXJf bWF0Y2hfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldiwKIAkJCQljb25zdCBzdHJ1Y3QgZGV2aWNl X2RyaXZlciAqZHJ2KTsKIAordm9pZCBmd25vZGVfYWRkX2RlcGVuZGVuY3koc3RydWN0IGZ3bm9k ZV9oYW5kbGUgKmZ3bm9kZSwKKwkJCSAgIHN0cnVjdCBsaXN0X2hlYWQgKmxpc3QpOworCit2b2lk IGZ3bm9kZV9hZGRfZGVwZW5kZW5jeV9wYXJzZXIoCisJdm9pZCAoKmZ1bmMpKHN0cnVjdCBmd25v ZGVfaGFuZGxlICpmd25vZGUsIHN0cnVjdCBsaXN0X2hlYWQgKmRlcHMpKTsKKwordm9pZCBmd25v ZGVfcmVtb3ZlX2RlcGVuZGVuY3lfcGFyc2VyKAorCXZvaWQgKCpmdW5jKShzdHJ1Y3QgZndub2Rl X2hhbmRsZSAqZndub2RlLCBzdHJ1Y3QgbGlzdF9oZWFkICpkZXBzKSk7CisKK3ZvaWQgZndub2Rl X2dldF9kZXBlbmRlbmNpZXMoc3RydWN0IGZ3bm9kZV9oYW5kbGUgKmZ3bm9kZSwKKwkJCSAgICAg c3RydWN0IGxpc3RfaGVhZCAqbGlzdCk7CisKIHVuc2lnbmVkIGludCBkZXZpY2VfZ2V0X2NoaWxk X25vZGVfY291bnQoc3RydWN0IGRldmljZSAqZGV2KTsKIAogc3RhdGljIGlubGluZSBib29sIGRl dmljZV9wcm9wZXJ0eV9yZWFkX2Jvb2woc3RydWN0IGRldmljZSAqZGV2LAotLSAKMi40LjEKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomeu Vizoso Date: Wed, 01 Jul 2015 09:40:57 +0000 Subject: [PATCH v2 02/12] device: property: find dependencies of a firmware node Message-Id: <1435743667-11987-3-git-send-email-tomeu.vizoso@collabora.com> List-Id: References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> In-Reply-To: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Tomeu Vizoso , linux-gpio@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, Mark Brown , linux-pwm@vger.kernel.org Adds API that allows callers to find out what other firmware nodes a node depends on. Implementors of bindings documentation can register callbacks that return the dependencies of a node. Dependency information can be used to change the order in which devices are probed, or to print a warning when a device node is going to be probed without all its dependencies fulfilled. Signed-off-by: Tomeu Vizoso --- Changes in v2: - Allow bindings implementations register a function instead of using class callbacks, as not only subsystems implement firmware bindings. drivers/base/property.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/fwnode.h | 5 +++ include/linux/property.h | 12 +++++++ 3 files changed, 108 insertions(+) diff --git a/drivers/base/property.c b/drivers/base/property.c index 8ead1ba..9d38ede 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -19,7 +19,13 @@ #include #include +struct dependency_parser { + struct list_head parser; + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps); +}; + static bool fwnode_match_enable = false; +static LIST_HEAD(dependency_parsers); /** * device_add_property_set - Add a collection of properties to a device object. @@ -553,6 +559,27 @@ bool device_dma_is_coherent(struct device *dev) EXPORT_SYMBOL_GPL(device_dma_is_coherent); /** + * fwnode_add_dependency - add firmware node to the passed dependency list + * @fwnode: Firmware node to add to dependency list + * @list: Dependency list to add the fwnode to + */ +void fwnode_add_dependency(struct fwnode_handle *fwnode, + struct list_head *list) +{ + struct fwnode_dependency *dep; + + dep = kzalloc(sizeof(*dep), GFP_KERNEL); + if (!dep) + return; + + INIT_LIST_HEAD(&dep->dependency); + dep->fwnode = fwnode; + + list_add_tail(&dep->dependency, list); +} +EXPORT_SYMBOL_GPL(fwnode_add_dependency); + +/** * fwnode_get_parent - return the parent node of a device node * @fwnode: Device node to find the parent node of */ @@ -600,6 +627,70 @@ bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible) EXPORT_SYMBOL_GPL(fwnode_is_compatible); /** + * fwnode_add_dependency_parser - register dependency parser + * @func: Function that will be called to find out dependencies of a node + * + * Registers a callback that will be called when collecting the dependencies + * of a firmware node. The callback should inspect the properties of the node + * and call fwnode_add_dependency() for each dependency it recognizes, from + * the bindings documentation. + */ +void fwnode_add_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)) +{ + struct dependency_parser *parser; + + parser = kzalloc(sizeof(*parser), GFP_KERNEL); + if (!parser) + return; + + INIT_LIST_HEAD(&parser->parser); + parser->func = func; + + list_add_tail(&parser->parser, &dependency_parsers); +} +EXPORT_SYMBOL_GPL(fwnode_add_dependency_parser); + +/** + * fwnode_remove_dependency_parser - unregister dependency parser + * @func: Function that was to be called to find out dependencies of a node + */ +void fwnode_remove_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)) +{ + struct dependency_parser *parser, *tmp; + + list_for_each_entry_safe(parser, tmp, &dependency_parsers, parser) { + if (parser->func = func) { + list_del(&parser->parser); + kfree(parser); + return; + } + } +} +EXPORT_SYMBOL_GPL(fwnode_remove_dependency_parser); + +/** + * fwnode_get_dependencies - find out what dependencies a firmware node has + * @fwnode: firmware node to find its dependencies + * @deps: list of struct fwnode_dependency in which dependencies will be placed + */ +void fwnode_get_dependencies(struct fwnode_handle *fwnode, + struct list_head *deps) +{ + struct dependency_parser *parser; + struct fwnode_handle *child; + + list_for_each_entry(parser, &dependency_parsers, parser) + parser->func(fwnode, deps); + + /* Some device nodes will have dependencies in non-device sub-nodes */ + fwnode_for_each_child_node(fwnode, child) + if (!fwnode_property_present(child, "compatible")) + fwnode_get_dependencies(child, deps); +} + +/** * fwnode_driver_match_device - Tell if a driver matches a device. * @drv: the device_driver structure to test * @dev: the device structure to match against diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 0408545..68ab558 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -24,4 +24,9 @@ struct fwnode_handle { struct fwnode_handle *secondary; }; +struct fwnode_dependency { + struct fwnode_handle *fwnode; + struct list_head dependency; +}; + #endif diff --git a/include/linux/property.h b/include/linux/property.h index 4e453c4..b8b86ea 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -86,6 +86,18 @@ bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible); bool fwnode_driver_match_device(struct device *dev, const struct device_driver *drv); +void fwnode_add_dependency(struct fwnode_handle *fwnode, + struct list_head *list); + +void fwnode_add_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)); + +void fwnode_remove_dependency_parser( + void (*func)(struct fwnode_handle *fwnode, struct list_head *deps)); + +void fwnode_get_dependencies(struct fwnode_handle *fwnode, + struct list_head *list); + unsigned int device_get_child_node_count(struct device *dev); static inline bool device_property_read_bool(struct device *dev, -- 2.4.1