From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755017AbbGGGv3 (ORCPT ); Tue, 7 Jul 2015 02:51:29 -0400 Received: from mail-bn1bon0133.outbound.protection.outlook.com ([157.56.111.133]:60602 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752876AbbGGGvR (ORCPT ); Tue, 7 Jul 2015 02:51:17 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; From: Dongsheng Wang To: CC: , , , Wang Dongsheng Subject: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function Date: Tue, 7 Jul 2015 14:12:56 +0800 Message-ID: <1436249576-23233-1-git-send-email-dongsheng.wang@freescale.com> X-Mailer: git-send-email 2.1.0.27.g96db324 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD023;1:ZpzK81L7zSRYujMCppQZ5FQ6DGbKUHs9uyPVEhu0FQjb2OGRfSRqhj7s7mYMm/lzvZMmp7maOUHyTpjZUD0PVvyIbp3dpXIw+ITttj3XeAEvWclz3ChfdiPg4VfVaLLM+EziSDDeeeuY+hCLxXZzH1oLASzZUP7bkGB7hDfphNUPGOiA32t4LSSj7Mu5SbUoV0OTcpokt7zXBJVBazaZHbWINyoR20C+YBO7PntcwcKjO8N1GZJE7Pid8gzC40RyRsGIy3YKByyt9gGR16MZP2JdFn82XqSItKdmAgCGzS0Wonyd5GPv+tQEyjsZTT+KvrEyvh5E68vg3SRoIqMQ/w== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(339900001)(5003940100001)(36756003)(106466001)(105606002)(19580405001)(85426001)(19580395003)(50466002)(77156002)(62966003)(46102003)(48376002)(92566002)(6806004)(87936001)(86362001)(104016003)(33646002)(50986999)(47776003)(50226001)(575784001)(5001960100002)(107886002)(189998001)(110136002)(77096005)(2351001)(229853001)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR0301MB1603;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB1603;2:M+Gdpx3Aeah2c6x2rkFF4AoWN8/yMPC+sTUNZSyCaN7OTlKlT7xhi3t7oVgz0QQX;3:krOQw0AmR3X+MjBptNSC/WSASrb5N4rsklb/TRdWsLKcImuyf5j4dixaTHgper5u5pvuic0tbxdoWdEVKnp+Nk5FfyBjXP34BqjwtCWbevltxw7a5dRrGxgapzvheT7f3hZN6ZgpTXjWOv5jV8e/woa0kFFWOKbJPlbpB17I3foX4pA5kS249pefFDgehEWHtUTYwxvRsdDxeoPu/qWqNsYlsN810/mUJKsdWPGnOMo=;25:dHD3R2XyMIyqq9OYADQecgnyfC2fnN9gT2ldDrKab0QXcyCJcLuiNh4b3cv96yj5xO+gshjaxkU4TB8QYNTlm0JqhqKjDk2BOjY6Jm40Fi/SDFXZft6maDryUGMFfppgyzit6vtoSLu/3dED44pZb1WwNtcS+ZZJGnfIGvipA/7utDrxCzbJUH9cYmyVDcDtXFaobNvVrAQciPOi7/LEbNWkTUTl4AvjRJZQ4phOdnsmXTk3jP3z9e3ket2Cs7QN;20:v4yBmFabcYqG0LCVGcOrSCq++sDOWUWEASkn154vN/NJGS3q/pDKeYRcn0OCcEVxz5W4v1jYsLzHBL6wOukHgJQmEDgqQLr7tksHyLR36eBxrurKVLgPpc69GbOZRtyh7JriwEoy1yltJCnG3oaPSd7v6TT+BZnHucdpk9QpB10F+L4w4c0AbLnhlKjfIzZAzSDkz7QvRavGDvvpylcU9F66jQfPJLuy6T1HWfKODIp3eiZUbY2tyP+5oqhVblLbsg5Q0asarof1pl+cjDIj4Ioi43nMKed6nx+XLUj9mQeAJsvIXK25Zrbgo7dwQFJuIex36j4Aqn06IZNLgOqGwwf0zK92T/FRSm2/CTBx4Pc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB1603;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB1634; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BLUPR0301MB1603;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB1603; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB1603;4:VAhy5ysZ2FnU2pykpQHpHGyEHpSkWnLJMxRF61cw72fNw2oy7CaESUQrYKFEMn63ls6Xx2BKMX6mvzXnPaskflVJAmUFFYXkvcL47a/x6fGprYL1nMoaF5pBcMWnoPi/slCAzLdDTcS/rCfx0CLj6avzmqb/T6Jwvi6dRhMzE/ZBTT8H1BH1wDLo8Ga/xu2iqiHhOVp54FvmRCeXradO5kr1RAsdpVgzZGkmLTR3xyeH2cJlRi6oH0lM9/1QDJeLmTfy8Tc0nFazVJqqlziOYei24wUoZhGo12y+kdhY7f4= X-Forefront-PRVS: 0630013541 X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB1603;23:4zy8gYh8PY9hO0C/UGBoZpXOm8IVbueQJaRpo4kG6XrLZ9WGOGZcUJPCFHRfI8R7UV5cIv8UXcJhyathNMtQsxrCjahWOF9vzR2bl8c2jTqeMkQyNieYeLlaO71o+rR8Ak9wNMGdHKNdAU4E95EpxNaDfZBBSnVXk2G2+d3KJufBVAxPViICZ0PJgkIU1XIuk2b1lWChByufhfgb2btwHdg88qFvhYCK7LQ2qOXvlGb2wt+ua4WzPxB1rViD6VuzGQfMOdgYiy8dCxHkudJNPITEexVuYx6QhsNLty+yIiofndBPzZ0N/CUESt+WCvwiZR16PLRG+74+dtfYOm13TA0sAACdULS28iWNX6IO5leqsNn3oLiQvh4TFsFln/kkl7Cs8Yok0nVIQXCcB9swJCbFrD/1Y6K7pL9EAfe7hc97OPhZKdeh5LtDhzZxU+gQQwphv/Q2F+RG2di73Q9YePW5k3uNuvcmJFyFAU9Ki9kIPZ6AQqeHwFCU971RC2yFG+2re5LtgdU0uiS6BtzYBMljJtt0R7M8LkxsLn/e6f6OSmNBdDIXtORIeH3USd6kBhAiozOMpCe4/FFyqJ3dsNsLsZK+0Y7xvbQiNmPUdoaIx5V+rtL0dAvybZ7GcneSxFO7S/yECHymxCMVc6sUn2LmjtFoVyoxnfd4dwtarigjYyoXFeJoZlrX9Lo+4yUk6CuTSSgnZOupNsbRxF2Vc4LgYfmWqKH6FgfbmP8iFCH2bCu0Yk9LE7OrWSNYbXIxE918ONeuHO8XSLu5mTwOqQGg8D5B5GRcuy9ACBQdx1Z2jIfH+YHbPFdmmUwXwYIUmgYI9AWpxDaMugeBVg4yc4Cj0jwR144gWezoTSFCD+4oWM1inQhi4fvBsfBKUUiFwR6TwkiAg0mhjTJhjD0D8w== X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB1603;5:61gzQzJwXlTCNzogfTIYfxXFJkWOA5CCkNLjIV7i1RAq6kMCZE0qhz991tgVqz9xwCBAOTNsmn6YeeTNGGlvALOCtjUou58CUGoFK+Fpc4fj0NzSe7BMIa/GJiuPf+2HVKwqKXmpxTk2Cs32TaCUCw==;24:Avl7Pm0yCC3QdXqujDZLQYPhImtd4EsY1XC/z9hQAhKCbL7SNtdHc7DznteFeEYObcedCzW9g2uDxvsrUbBJijdPXaSHNbH/YPyOu7Ph2rU=;20:ziskYgMMZAp1bhbn6yeq/Jpd3MxiVYRf4XztUd8GsEJTCQxD+PY78medkMbHoD47UcCH9PE1J5ihf4PjHwMFZg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2015 06:17:38.4686 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB1603 X-Microsoft-Exchange-Diagnostics: 1;BLUPR0301MB1634;2:u6w2tu48DPVrPhekJnXtbdstG5dWe9pNIDBXDlKYuo67XRCJTWt5CoIWueWk9HXD;3:PxbnoffxKt8JrzkdroMMkXdsitltTGSM5dTJ9+dRkYub6y9zst7aQm1hB1WHkyby0p1rWskRF8IlnssSBZJBWQut/cWrR31Km+f1jbE7Mq/MkP5U3RGn0T8S3ekAUJGg86j/2GEERJkyVZ2epBU2fqUDN5iD1Mad4FhtAvqMXpXzUnzbD24URUQ3lJ2Jrnh/nNgBx86cNg9SW97AKlZlas4HYzavAg/m2k5AX2ZOvDc=;25:3hRNSRf7Nf5HBxPDbdKFbsOMm0/jsLwq64GUIaYyG6icKVf4ZPr4LZkFggCq5Vh/RiLZeOdnXT/mMMASY5Yh3WWwcVUNtS+qF5FBlchP7LLfnXKS+PVBcXNqpnpPBQfmk9dxODh8KAslsMUwbkNk4hrzUpMhH0pFgAL+hSf9evfIU8Y9KdpGAavxqH/huVQXMDXJDDIGaBdQj8NM4UrGgFs6k57mfcJk7A/MdoQODqQYm6eWvwxuaKwaHnTMA+/z;23:tpYfPuRrcGfo4Mqe8xXQCvQ8b1WFDPaaVPfMqxgVg6oSCu6KzD2V/Sjrru5pYHICn98TIreACPeOpR2wz/7L7eXlXg1D4AOi80sy6s/vyA+MjWtpN2jL+1oDmjSLK6UqJE7LBqY3ByhSTz0TBsnxXC2RRwBJayXrV0lFuYU0M77nrHv3eBH9skHS4Nk28AmhW+tbQ84zc/JOPMhIgBaiZ3N7Gz+rFyw5CR08P3TUpou6E4UShHRe2a8oGjAy5ohr X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang Dongsheng If ds3232 work on some platform that is not implementation irq_set_wake, ds3232 will get a WARNING trace in resume. So fix ds3232->suspended state to false when irq_set_irq_wake return error. ------------[ cut here ]------------ WARNING: CPU: 0 PID: 729 at kernel/irq/manage.c:604 irq_set_irq_wake+0x4b/0x8c() Unbalanced IRQ 201 wake disable Modules linked in: CPU: 0 PID: 729 Comm: sh Not tainted 3.12.19-rt30+ #25 [<800107d9>] (unwind_backtrace+0x1/0x88) from [<8000e4ef>] (show_stack+0xb/0xc) [<8000e4ef>] (show_stack+0xb/0xc) from [<802b5fa9>] (dump_stack+0x4d/0x60) [<802b5fa9>] (dump_stack+0x4d/0x60) from [<800186dd>] (warn_slowpath_common+0x45/0x64) [<800186dd>] (warn_slowpath_common+0x45/0x64) from [<80018717>] (warn_slowpath_fmt+0x1b/0x24) [<80018717>] (warn_slowpath_fmt+0x1b/0x24) from [<8003a8d3>] (irq_set_irq_wake+0x4b/0x8c) [<8003a8d3>] (irq_set_irq_wake+0x4b/0x8c) from [<80204fcb>] (ds3232_resume+0x2d/0x36) [<80204fcb>] (ds3232_resume+0x2d/0x36) from [<801954c7>] (dpm_run_callback.isra.13+0xb/0x28) [<801954c7>] (dpm_run_callback.isra.13+0xb/0x28) from [<80195b1b>] (device_resume+0x7b/0xa2) [<80195b1b>] (device_resume+0x7b/0xa2) from [<80195f0f>] (dpm_resume+0xbb/0x19c) [<80195f0f>] (dpm_resume+0xbb/0x19c) from [<801960d9>] (dpm_resume_end+0x9/0x12) [<801960d9>] (dpm_resume_end+0x9/0x12) from [<80037e1d>] (suspend_devices_and_enter+0x17d/0x1d0) [<80037e1d>] (suspend_devices_and_enter+0x17d/0x1d0) from [<80037ee1>] (pm_suspend+0x71/0x128) [<80037ee1>] (pm_suspend+0x71/0x128) from [<80037449>] (state_store+0x6d/0x80) [<80037449>] (state_store+0x6d/0x80) from [<800af4d5>] (sysfs_write_file+0x9f/0xde) [<800af4d5>] (sysfs_write_file+0x9f/0xde) from [<8007a437>] (vfs_write+0x7b/0x104) [<8007a437>] (vfs_write+0x7b/0x104) from [<8007a7f7>] (SyS_write+0x27/0x48) [<8007a7f7>] (SyS_write+0x27/0x48) from [<8000c121>] (ret_fast_syscall+0x1/0x44) ---[ end trace 640959d2e8de6ccc ]--- Signed-off-by: Wang Dongsheng diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index 7e48e53..2081155 100644 --- a/drivers/rtc/rtc-ds3232.c +++ b/drivers/rtc/rtc-ds3232.c @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev) if (device_can_wakeup(dev)) { ds3232->suspended = true; - irq_set_irq_wake(client->irq, 1); + if (irq_set_irq_wake(client->irq, 1)) { + dev_info(dev, "Cannot serve as a wakeup source\n"); + ds3232->suspended = false; + } } return 0; -- 2.1.0.27.g96db324 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0131.outbound.protection.outlook.com. [65.55.169.131]) by gmr-mx.google.com with ESMTPS id s127si2237415ywc.6.2015.07.06.23.17.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Jul 2015 23:17:40 -0700 (PDT) From: Dongsheng Wang To: CC: , , , Wang Dongsheng Subject: [rtc-linux] [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function Date: Tue, 7 Jul 2015 14:12:56 +0800 Message-ID: <1436249576-23233-1-git-send-email-dongsheng.wang@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Wang Dongsheng If ds3232 work on some platform that is not implementation irq_set_wake, ds3232 will get a WARNING trace in resume. So fix ds3232->suspended state to false when irq_set_irq_wake return error. ------------[ cut here ]------------ WARNING: CPU: 0 PID: 729 at kernel/irq/manage.c:604 irq_set_irq_wake+0x4b/0x8c() Unbalanced IRQ 201 wake disable Modules linked in: CPU: 0 PID: 729 Comm: sh Not tainted 3.12.19-rt30+ #25 [<800107d9>] (unwind_backtrace+0x1/0x88) from [<8000e4ef>] (show_stack+0xb/0xc) [<8000e4ef>] (show_stack+0xb/0xc) from [<802b5fa9>] (dump_stack+0x4d/0x60) [<802b5fa9>] (dump_stack+0x4d/0x60) from [<800186dd>] (warn_slowpath_common+0x45/0x64) [<800186dd>] (warn_slowpath_common+0x45/0x64) from [<80018717>] (warn_slowpath_fmt+0x1b/0x24) [<80018717>] (warn_slowpath_fmt+0x1b/0x24) from [<8003a8d3>] (irq_set_irq_wake+0x4b/0x8c) [<8003a8d3>] (irq_set_irq_wake+0x4b/0x8c) from [<80204fcb>] (ds3232_resume+0x2d/0x36) [<80204fcb>] (ds3232_resume+0x2d/0x36) from [<801954c7>] (dpm_run_callback.isra.13+0xb/0x28) [<801954c7>] (dpm_run_callback.isra.13+0xb/0x28) from [<80195b1b>] (device_resume+0x7b/0xa2) [<80195b1b>] (device_resume+0x7b/0xa2) from [<80195f0f>] (dpm_resume+0xbb/0x19c) [<80195f0f>] (dpm_resume+0xbb/0x19c) from [<801960d9>] (dpm_resume_end+0x9/0x12) [<801960d9>] (dpm_resume_end+0x9/0x12) from [<80037e1d>] (suspend_devices_and_enter+0x17d/0x1d0) [<80037e1d>] (suspend_devices_and_enter+0x17d/0x1d0) from [<80037ee1>] (pm_suspend+0x71/0x128) [<80037ee1>] (pm_suspend+0x71/0x128) from [<80037449>] (state_store+0x6d/0x80) [<80037449>] (state_store+0x6d/0x80) from [<800af4d5>] (sysfs_write_file+0x9f/0xde) [<800af4d5>] (sysfs_write_file+0x9f/0xde) from [<8007a437>] (vfs_write+0x7b/0x104) [<8007a437>] (vfs_write+0x7b/0x104) from [<8007a7f7>] (SyS_write+0x27/0x48) [<8007a7f7>] (SyS_write+0x27/0x48) from [<8000c121>] (ret_fast_syscall+0x1/0x44) ---[ end trace 640959d2e8de6ccc ]--- Signed-off-by: Wang Dongsheng diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index 7e48e53..2081155 100644 --- a/drivers/rtc/rtc-ds3232.c +++ b/drivers/rtc/rtc-ds3232.c @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev) if (device_can_wakeup(dev)) { ds3232->suspended = true; - irq_set_irq_wake(client->irq, 1); + if (irq_set_irq_wake(client->irq, 1)) { + dev_info(dev, "Cannot serve as a wakeup source\n"); + ds3232->suspended = false; + } } return 0; -- 2.1.0.27.g96db324 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.