* [PATCH] ixgbe: fix the issue that auto negotiation for flow control cannot be disabled
@ 2015-07-08 1:14 Wenzhuo Lu
2015-07-09 3:34 ` Ouyang, Changchun
0 siblings, 1 reply; 3+ messages in thread
From: Wenzhuo Lu @ 2015-07-08 1:14 UTC (permalink / raw
To: dev
There's a parameter "autoneg on|off" in testpmd CLI "set flow_ctrl ...". This
parameter is used to enable/disable auto negotiation for flow control. But it's
not supported yet.
The auto negotiation is enabled by default, we have no way to disable it. This
patch lets the parameter "autoneg on|off" be supproted.
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index f18550c..b78f8f5 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2549,8 +2549,6 @@ ixgbe_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
PMD_INIT_FUNC_TRACE();
hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- if (fc_conf->autoneg != !hw->fc.disable_fc_autoneg)
- return -ENOTSUP;
rx_buf_size = IXGBE_READ_REG(hw, IXGBE_RXPBSIZE(0));
PMD_INIT_LOG(DEBUG, "Rx packet buffer size = 0x%x", rx_buf_size);
@@ -2571,6 +2569,7 @@ ixgbe_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
hw->fc.high_water[0] = fc_conf->high_water;
hw->fc.low_water[0] = fc_conf->low_water;
hw->fc.send_xon = fc_conf->send_xon;
+ hw->fc.disable_fc_autoneg = !fc_conf->autoneg;
err = ixgbe_fc_enable(hw);
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ixgbe: fix the issue that auto negotiation for flow control cannot be disabled
2015-07-08 1:14 [PATCH] ixgbe: fix the issue that auto negotiation for flow control cannot be disabled Wenzhuo Lu
@ 2015-07-09 3:34 ` Ouyang, Changchun
2015-07-10 16:26 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ouyang, Changchun @ 2015-07-09 3:34 UTC (permalink / raw
To: Lu, Wenzhuo, dev@dpdk.org
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, July 8, 2015 9:14 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: fix the issue that auto negotiation for
> flow control cannot be disabled
>
> There's a parameter "autoneg on|off" in testpmd CLI "set flow_ctrl ...". This
> parameter is used to enable/disable auto negotiation for flow control. But it's
> not supported yet.
> The auto negotiation is enabled by default, we have no way to disable it. This
> patch lets the parameter "autoneg on|off" be supproted.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Changchun Ouyang <changchun.ouyang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ixgbe: fix the issue that auto negotiation for flow control cannot be disabled
2015-07-09 3:34 ` Ouyang, Changchun
@ 2015-07-10 16:26 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-07-10 16:26 UTC (permalink / raw
To: Lu, Wenzhuo; +Cc: dev
> > There's a parameter "autoneg on|off" in testpmd CLI "set flow_ctrl ...". This
> > parameter is used to enable/disable auto negotiation for flow control. But it's
> > not supported yet.
> > The auto negotiation is enabled by default, we have no way to disable it. This
> > patch lets the parameter "autoneg on|off" be supproted.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> Acked-by: Changchun Ouyang <changchun.ouyang@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-10 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-08 1:14 [PATCH] ixgbe: fix the issue that auto negotiation for flow control cannot be disabled Wenzhuo Lu
2015-07-09 3:34 ` Ouyang, Changchun
2015-07-10 16:26 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.