* [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
@ 2015-07-09 5:10 wei.tee.ng
2015-07-09 5:10 ` [PATCH 1/2] recipes-connectivity: Add hostapd configuration for enabling Marvell 8897 WiFi feature wei.tee.ng
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: wei.tee.ng @ 2015-07-09 5:10 UTC (permalink / raw
To: openembedded-core; +Cc: wei.tee.ng
From: Ng Wei Tee <wei.tee.ng@intel.com>
Hi all,
I would like to add hostapd and iw configuration for enabling
Marvell 8897 Wifi feature. Hostapd and iw configuration were
created in the recipes-connectivity layer to enable Marvell 8897
module function in AP mode and STA mode.
Please review and provide feedback if any.
This patch is target to merge in openembedded-core master and dizzy
branch. Thanks.
Regards,
Wei Tee
Ng Shui Lei (2):
recipes-connectivity: Add hostapd configuration for enabling Marvell
8897 WiFi feature
recipes-connectivity: Add iw configuration for enabling Marvell 8897
WiFi feature
.../hostapd/hostapd-2.2/defconfig | 145 ++++++++++++++++++++
.../hostapd/hostapd-2.2/hostapd.service | 11 ++
meta/recipes-connectivity/hostapd/hostapd-2.2/init | 58 ++++++++
meta/recipes-connectivity/hostapd/hostapd_2.2.bb | 48 +++++++
....sh-don-t-use-git-describe-for-versioning.patch | 40 ++++++
meta/recipes-connectivity/iw/iw_3.8.bb | 27 ++++
6 files changed, 329 insertions(+)
create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/defconfig
create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/hostapd.service
create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/init
create mode 100644 meta/recipes-connectivity/hostapd/hostapd_2.2.bb
create mode 100644 meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch
create mode 100644 meta/recipes-connectivity/iw/iw_3.8.bb
--
1.7.9.5
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/2] recipes-connectivity: Add hostapd configuration for enabling Marvell 8897 WiFi feature
2015-07-09 5:10 [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature wei.tee.ng
@ 2015-07-09 5:10 ` wei.tee.ng
2015-07-27 14:03 ` Richard Purdie
2015-07-09 5:10 ` [PATCH 2/2] recipes-connectivity: Add iw " wei.tee.ng
` (3 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: wei.tee.ng @ 2015-07-09 5:10 UTC (permalink / raw
To: openembedded-core; +Cc: wei.tee.ng
From: Ng Shui Lei <shui.lei.ng@intel.com>
Hostapd features was created in the recipes-connectivity
layer to enable Marvell 8897 module in AP mode and STA mode.
Signed-off-by: Ng Shui Lei <shui.lei.ng@intel.com>
Signed-off-by: Ng Wei Tee <wei.tee.ng@intel.com>
---
.../hostapd/hostapd-2.2/defconfig | 145 ++++++++++++++++++++
.../hostapd/hostapd-2.2/hostapd.service | 11 ++
meta/recipes-connectivity/hostapd/hostapd-2.2/init | 58 ++++++++
meta/recipes-connectivity/hostapd/hostapd_2.2.bb | 48 +++++++
4 files changed, 262 insertions(+)
create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/defconfig
create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/hostapd.service
create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/init
create mode 100644 meta/recipes-connectivity/hostapd/hostapd_2.2.bb
diff --git a/meta/recipes-connectivity/hostapd/hostapd-2.2/defconfig b/meta/recipes-connectivity/hostapd/hostapd-2.2/defconfig
new file mode 100644
index 0000000..2789640
--- /dev/null
+++ b/meta/recipes-connectivity/hostapd/hostapd-2.2/defconfig
@@ -0,0 +1,145 @@
+# Example hostapd build time configuration
+#
+# This file lists the configuration options that are used when building the
+# hostapd binary. All lines starting with # are ignored. Configuration option
+# lines must be commented out complete, if they are not to be included, i.e.,
+# just setting VARIABLE=n is not disabling that variable.
+#
+# This file is included in Makefile, so variables like CFLAGS and LIBS can also
+# be modified from here. In most cass, these lines should use += in order not
+# to override previous values of the variables.
+
+# Driver interface for Host AP driver
+CONFIG_DRIVER_HOSTAP=y
+
+# Driver interface for wired authenticator
+CONFIG_DRIVER_WIRED=y
+
+# Driver interface for madwifi driver
+#CONFIG_DRIVER_MADWIFI=y
+#CFLAGS += -I../../madwifi # change to the madwifi source directory
+
+# Driver interface for Prism54 driver
+CONFIG_DRIVER_PRISM54=y
+
+# Driver interface for drivers using the nl80211 kernel interface
+CONFIG_DRIVER_NL80211=y
+CONFIG_LIBNL32=y
+# driver_nl80211.c requires a rather new libnl (version 1.1) which may not be
+# shipped with your distribution yet. If that is the case, you need to build
+# newer libnl version and point the hostapd build to use it.
+#LIBNL=/usr/src/libnl
+#CFLAGS += -I$(LIBNL)/include
+#LIBS += -L$(LIBNL)/lib
+
+# Driver interface for FreeBSD net80211 layer (e.g., Atheros driver)
+#CONFIG_DRIVER_BSD=y
+#CFLAGS += -I/usr/local/include
+#LIBS += -L/usr/local/lib
+
+# Driver interface for no driver (e.g., RADIUS server only)
+#CONFIG_DRIVER_NONE=y
+
+# IEEE 802.11F/IAPP
+CONFIG_IAPP=y
+
+# WPA2/IEEE 802.11i RSN pre-authentication
+CONFIG_RSN_PREAUTH=y
+
+# PeerKey handshake for Station to Station Link (IEEE 802.11e DLS)
+CONFIG_PEERKEY=y
+
+# IEEE 802.11w (management frame protection)
+# This version is an experimental implementation based on IEEE 802.11w/D1.0
+# draft and is subject to change since the standard has not yet been finalized.
+# Driver support is also needed for IEEE 802.11w.
+#CONFIG_IEEE80211W=y
+
+# Integrated EAP server
+CONFIG_EAP=y
+
+# EAP-MD5 for the integrated EAP server
+CONFIG_EAP_MD5=y
+
+# EAP-TLS for the integrated EAP server
+CONFIG_EAP_TLS=y
+
+# EAP-MSCHAPv2 for the integrated EAP server
+CONFIG_EAP_MSCHAPV2=y
+
+# EAP-PEAP for the integrated EAP server
+CONFIG_EAP_PEAP=y
+
+# EAP-GTC for the integrated EAP server
+CONFIG_EAP_GTC=y
+
+# EAP-TTLS for the integrated EAP server
+CONFIG_EAP_TTLS=y
+
+# EAP-SIM for the integrated EAP server
+#CONFIG_EAP_SIM=y
+
+# EAP-AKA for the integrated EAP server
+#CONFIG_EAP_AKA=y
+
+# EAP-AKA' for the integrated EAP server
+# This requires CONFIG_EAP_AKA to be enabled, too.
+#CONFIG_EAP_AKA_PRIME=y
+
+# EAP-PAX for the integrated EAP server
+#CONFIG_EAP_PAX=y
+
+# EAP-PSK for the integrated EAP server (this is _not_ needed for WPA-PSK)
+#CONFIG_EAP_PSK=y
+
+# EAP-SAKE for the integrated EAP server
+#CONFIG_EAP_SAKE=y
+
+# EAP-GPSK for the integrated EAP server
+#CONFIG_EAP_GPSK=y
+# Include support for optional SHA256 cipher suite in EAP-GPSK
+#CONFIG_EAP_GPSK_SHA256=y
+
+# EAP-FAST for the integrated EAP server
+# Note: Default OpenSSL package does not include support for all the
+# functionality needed for EAP-FAST. If EAP-FAST is enabled with OpenSSL,
+# the OpenSSL library must be patched (openssl-0.9.9-session-ticket.patch)
+# to add the needed functions.
+#CONFIG_EAP_FAST=y
+
+# Wi-Fi Protected Setup (WPS)
+CONFIG_WPS=y
+# Enable UPnP support for external WPS Registrars
+#CONFIG_WPS_UPNP=y
+
+# EAP-IKEv2
+#CONFIG_EAP_IKEV2=y
+
+# Trusted Network Connect (EAP-TNC)
+#CONFIG_EAP_TNC=y
+
+# PKCS#12 (PFX) support (used to read private key and certificate file from
+# a file that usually has extension .p12 or .pfx)
+CONFIG_PKCS12=y
+
+# RADIUS authentication server. This provides access to the integrated EAP
+# server from external hosts using RADIUS.
+CONFIG_RADIUS_SERVER=y
+
+# Build IPv6 support for RADIUS operations
+CONFIG_IPV6=y
+
+# IEEE Std 802.11r-2008 (Fast BSS Transition)
+#CONFIG_IEEE80211R=y
+
+# Use the hostapd's IEEE 802.11 authentication (ACL), but without
+# the IEEE 802.11 Management capability (e.g., madwifi or FreeBSD/net80211)
+CONFIG_DRIVER_RADIUS_ACL=y
+
+# IEEE 802.11n (High Throughput) support
+CONFIG_IEEE80211N=y
+
+# Remove debugging code that is printing out debug messages to stdout.
+# This can be used to reduce the size of the hostapd considerably if debugging
+# code is not needed.
+#CONFIG_NO_STDOUT_DEBUG=y
diff --git a/meta/recipes-connectivity/hostapd/hostapd-2.2/hostapd.service b/meta/recipes-connectivity/hostapd/hostapd-2.2/hostapd.service
new file mode 100644
index 0000000..151c050
--- /dev/null
+++ b/meta/recipes-connectivity/hostapd/hostapd-2.2/hostapd.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Hostapd IEEE 802.11 AP, IEEE 802.1X/WPA/WPA2/EAP/RADIUS Authenticator
+After=network.target
+
+[Service]
+Type=forking
+PIDFile=/run/hostapd.pid
+ExecStart=@SBINDIR@/hostapd @SYSCONFDIR@/hostapd.conf -P /run/hostapd.pid -B
+
+[Install]
+WantedBy=multi-user.target
diff --git a/meta/recipes-connectivity/hostapd/hostapd-2.2/init b/meta/recipes-connectivity/hostapd/hostapd-2.2/init
new file mode 100644
index 0000000..8ba4e07
--- /dev/null
+++ b/meta/recipes-connectivity/hostapd/hostapd-2.2/init
@@ -0,0 +1,58 @@
+#!/bin/sh
+DAEMON=/usr/sbin/hostapd
+NAME=hostapd
+DESC="HOSTAP Daemon"
+ARGS="/etc/hostapd.conf -B"
+
+test -f $DAEMON || exit 0
+
+set -e
+
+# source function library
+. /etc/init.d/functions
+
+delay_stop() {
+ count=0
+ while [ $count -lt 9 ] ; do
+ if pidof $DAEMON >/dev/null; then
+ sleep 1
+ else
+ return 0
+ fi
+ count=`expr $count + 1`
+ done
+ echo "Failed to stop $DESC."
+ return 1
+}
+
+case "$1" in
+ start)
+ echo -n "Starting $DESC: "
+ start-stop-daemon -S -x $DAEMON -- $ARGS
+ echo "$NAME."
+ ;;
+ stop)
+ echo -n "Stopping $DESC: "
+ start-stop-daemon -K --oknodo -x $DAEMON
+ echo "$NAME."
+ ;;
+ restart)
+ $0 stop
+ delay_stop && $0 start
+ ;;
+ reload)
+ echo -n "Reloading $DESC: "
+ killall -HUP $(basename ${DAEMON})
+ echo "$NAME."
+ ;;
+ status)
+ status $DAEMON
+ exit $?
+ ;;
+ *)
+ echo "Usage: $0 {start|stop|restart|reload|status}"
+ exit 1
+ ;;
+esac
+
+exit 0
diff --git a/meta/recipes-connectivity/hostapd/hostapd_2.2.bb b/meta/recipes-connectivity/hostapd/hostapd_2.2.bb
new file mode 100644
index 0000000..b75f2b9
--- /dev/null
+++ b/meta/recipes-connectivity/hostapd/hostapd_2.2.bb
@@ -0,0 +1,48 @@
+HOMEPAGE = "http://hostap.epitest.fi"
+SECTION = "kernel/userland"
+LICENSE = "GPLv2 | BSD"
+LIC_FILES_CHKSUM = "file://README;md5=0854a4da34ac3990770794d771fac7fd"
+DEPENDS = "libnl openssl"
+SUMMARY = "User space daemon for extended IEEE 802.11 management"
+
+inherit update-rc.d systemd
+INITSCRIPT_NAME = "hostapd"
+
+SYSTEMD_SERVICE_${PN} = "hostapd.service"
+SYSTEMD_AUTO_ENABLE_${PN} = "disable"
+
+DEFAULT_PREFERENCE = "-1"
+
+SRC_URI = " \
+ http://hostap.epitest.fi/releases/hostapd-${PV}.tar.gz \
+ file://defconfig \
+ file://init \
+ file://hostapd.service \
+"
+
+S = "${WORKDIR}/hostapd-${PV}/hostapd"
+
+
+do_configure() {
+ install -m 0644 ${WORKDIR}/defconfig ${S}/.config
+}
+
+do_compile() {
+ export CFLAGS="-MMD -O2 -Wall -g -I${STAGING_INCDIR}/libnl3"
+ make
+}
+
+do_install() {
+ install -d ${D}${sbindir} ${D}${sysconfdir}/init.d ${D}${systemd_unitdir}/system/
+ install -m 0644 ${S}/hostapd.conf ${D}${sysconfdir}
+ install -m 0755 ${S}/hostapd ${D}${sbindir}
+ install -m 0755 ${S}/hostapd_cli ${D}${sbindir}
+ install -m 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/hostapd
+ install -m 0644 ${WORKDIR}/hostapd.service ${D}${systemd_unitdir}/system/
+ sed -i -e 's,@SBINDIR@,${sbindir},g' -e 's,@SYSCONFDIR@,${sysconfdir},g' ${D}${systemd_unitdir}/system/hostapd.service
+}
+
+CONFFILES_${PN} += "${sysconfdir}/hostapd.conf"
+
+SRC_URI[md5sum] = "23c1f78a693c3288802d516adb7fd289"
+SRC_URI[sha256sum] = "f15b6bcb434378860ea5b88dffed7f54d8cb71fff2146de0f006977a5e25a882"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/2] recipes-connectivity: Add iw configuration for enabling Marvell 8897 WiFi feature
2015-07-09 5:10 [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature wei.tee.ng
2015-07-09 5:10 ` [PATCH 1/2] recipes-connectivity: Add hostapd configuration for enabling Marvell 8897 WiFi feature wei.tee.ng
@ 2015-07-09 5:10 ` wei.tee.ng
2015-07-27 14:07 ` Richard Purdie
2015-07-21 1:32 ` [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature Ng, Wei Tee
` (2 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: wei.tee.ng @ 2015-07-09 5:10 UTC (permalink / raw
To: openembedded-core; +Cc: wei.tee.ng
From: Ng Shui Lei <shui.lei.ng@intel.com>
iw features was created in the recipes-connectivity layer to
enable Marvell 8897 module in AP mode and STA mode. iw is a
new nl80211 based CLI configuration utility for wireless devices.
Signed-off-by: Ng Shui Lei <shui.lei.ng@intel.com>
Signed-off-by: Ng Wei Tee <wei.tee.ng@intel.com>
---
....sh-don-t-use-git-describe-for-versioning.patch | 40 ++++++++++++++++++++
meta/recipes-connectivity/iw/iw_3.8.bb | 27 +++++++++++++
2 files changed, 67 insertions(+)
create mode 100644 meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch
create mode 100644 meta/recipes-connectivity/iw/iw_3.8.bb
diff --git a/meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch b/meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch
new file mode 100644
index 0000000..f4a7ee7
--- /dev/null
+++ b/meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch
@@ -0,0 +1,40 @@
+From: Koen Kooi <koen@dominion.thruhere.net>
+Date: Tue, 29 Nov 2011 17:03:27 +0100
+Subject: [PATCH] iw: version.sh: don't use git describe for versioning
+
+It will detect top-level git repositories like the Angstrom setup-scripts and break.
+
+Upstream-status: Unknown
+
+Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
+---
+ version.sh | 16 +---------------
+ 1 file changed, 1 insertion(+), 15 deletions(-)
+
+diff --git a/version.sh b/version.sh
+index db02f0d..336ce2b 100755
+--- a/version.sh
++++ b/version.sh
+@@ -3,21 +3,7 @@
+ VERSION="3.8"
+ OUT="$1"
+
+-if head=`git rev-parse --verify HEAD 2>/dev/null`; then
+- git update-index --refresh --unmerged > /dev/null
+- descr=$(git describe)
+-
+- # on git builds check that the version number above
+- # is correct...
+- [ "${descr%%-*}" = "v$VERSION" ] || exit 2
+-
+- v="${descr#v}"
+- if git diff-index --name-only HEAD | read dummy ; then
+- v="$v"-dirty
+- fi
+-else
+- v="$VERSION"
+-fi
++v="$VERSION"
+
+ echo '#include "iw.h"' > "$OUT"
+ echo "const char iw_version[] = \"$v\";" >> "$OUT"
diff --git a/meta/recipes-connectivity/iw/iw_3.8.bb b/meta/recipes-connectivity/iw/iw_3.8.bb
new file mode 100644
index 0000000..29dbcd0
--- /dev/null
+++ b/meta/recipes-connectivity/iw/iw_3.8.bb
@@ -0,0 +1,27 @@
+# Copyright (C) 2013 Digi International.
+
+SUMMARY = "nl80211 based CLI configuration utility for wireless devices"
+DESCRIPTION = "iw is a new nl80211 based CLI configuration utility for \
+wireless devices. It supports almost all new drivers that have been added \
+to the kernel recently. "
+HOMEPAGE = "http://linuxwireless.org/en/users/Documentation/iw"
+SECTION = "base"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://COPYING;md5=878618a5c4af25e9b93ef0be1a93f774"
+
+DEPENDS = "libnl pkgconfig"
+
+PR = "${DISTRO}.r0"
+
+SRC_URI = "http://www.kernel.org/pub/software/network/iw/iw-${PV}.tar.bz2 \
+ file://0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch \
+ "
+
+SRC_URI[md5sum] = "618ad1106a196fb1c3d827de96da437c"
+SRC_URI[sha256sum] = "3dae92ca5989cbc21155941fa01907a5536da3c5f6898642440c61484fc7e0f9"
+
+EXTRA_OEMAKE = ""
+
+do_install() {
+ oe_runmake DESTDIR=${D} install
+}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-09 5:10 [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature wei.tee.ng
2015-07-09 5:10 ` [PATCH 1/2] recipes-connectivity: Add hostapd configuration for enabling Marvell 8897 WiFi feature wei.tee.ng
2015-07-09 5:10 ` [PATCH 2/2] recipes-connectivity: Add iw " wei.tee.ng
@ 2015-07-21 1:32 ` Ng, Wei Tee
2015-07-27 5:21 ` Ng, Wei Tee
2015-07-27 16:41 ` Otavio Salvador
4 siblings, 0 replies; 13+ messages in thread
From: Ng, Wei Tee @ 2015-07-21 1:32 UTC (permalink / raw
To: openembedded-core@lists.openembedded.org
Hi, are these included?
Best Regards,
Wei Tee
> -----Original Message-----
> From: Ng, Wei Tee
> Sent: Thursday, July 9, 2015 1:10 PM
> To: openembedded-core@lists.openembedded.org
> Cc: Ng, Wei Tee
> Subject: [PATCH 0/2] [OE-core][master][dizzy] Enable Marvel 8897 Wifi feature
>
> From: Ng Wei Tee <wei.tee.ng@intel.com>
>
> Hi all,
>
> I would like to add hostapd and iw configuration for enabling Marvell 8897 Wifi
> feature. Hostapd and iw configuration were created in the recipes-connectivity
> layer to enable Marvell 8897 module function in AP mode and STA mode.
>
> Please review and provide feedback if any.
>
> This patch is target to merge in openembedded-core master and dizzy branch.
> Thanks.
>
> Regards,
> Wei Tee
>
> Ng Shui Lei (2):
> recipes-connectivity: Add hostapd configuration for enabling Marvell
> 8897 WiFi feature
> recipes-connectivity: Add iw configuration for enabling Marvell 8897
> WiFi feature
>
> .../hostapd/hostapd-2.2/defconfig | 145 ++++++++++++++++++++
> .../hostapd/hostapd-2.2/hostapd.service | 11 ++
> meta/recipes-connectivity/hostapd/hostapd-2.2/init | 58 ++++++++
> meta/recipes-connectivity/hostapd/hostapd_2.2.bb | 48 +++++++
> ....sh-don-t-use-git-describe-for-versioning.patch | 40 ++++++
> meta/recipes-connectivity/iw/iw_3.8.bb | 27 ++++
> 6 files changed, 329 insertions(+)
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-
> 2.2/defconfig
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-
> 2.2/hostapd.service
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/init
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd_2.2.bb
> create mode 100644 meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-
> don-t-use-git-describe-for-versioning.patch
> create mode 100644 meta/recipes-connectivity/iw/iw_3.8.bb
>
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-09 5:10 [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature wei.tee.ng
` (2 preceding siblings ...)
2015-07-21 1:32 ` [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature Ng, Wei Tee
@ 2015-07-27 5:21 ` Ng, Wei Tee
2015-07-27 16:41 ` Otavio Salvador
4 siblings, 0 replies; 13+ messages in thread
From: Ng, Wei Tee @ 2015-07-27 5:21 UTC (permalink / raw
To: openembedded-core@lists.openembedded.org; +Cc: Wold, Saul
Hi,
I've sent 2 patches regarding to enable Marvel 8897 Wifi feature 2 weeks ago and would like to follow up the status.
I am wondering is there any issue on the patches that I submitted because I don't receive any response from anyone.
These 2 patches are targeting to merge in Master branch and port it over to Dizzy branch as well.
Any helps will be appreciated. Thanks.
Regards,
Wei Tee
> -----Original Message-----
> From: Ng, Wei Tee
> Sent: Thursday, July 9, 2015 1:10 PM
> To: openembedded-core@lists.openembedded.org
> Cc: Ng, Wei Tee
> Subject: [PATCH 0/2] [OE-core][master][dizzy] Enable Marvel 8897 Wifi feature
>
> From: Ng Wei Tee <wei.tee.ng@intel.com>
>
> Hi all,
>
> I would like to add hostapd and iw configuration for enabling Marvell 8897 Wifi
> feature. Hostapd and iw configuration were created in the recipes-connectivity
> layer to enable Marvell 8897 module function in AP mode and STA mode.
>
> Please review and provide feedback if any.
>
> This patch is target to merge in openembedded-core master and dizzy branch.
> Thanks.
>
> Regards,
> Wei Tee
>
> Ng Shui Lei (2):
> recipes-connectivity: Add hostapd configuration for enabling Marvell
> 8897 WiFi feature
> recipes-connectivity: Add iw configuration for enabling Marvell 8897
> WiFi feature
>
> .../hostapd/hostapd-2.2/defconfig | 145 ++++++++++++++++++++
> .../hostapd/hostapd-2.2/hostapd.service | 11 ++
> meta/recipes-connectivity/hostapd/hostapd-2.2/init | 58 ++++++++
> meta/recipes-connectivity/hostapd/hostapd_2.2.bb | 48 +++++++
> ....sh-don-t-use-git-describe-for-versioning.patch | 40 ++++++
> meta/recipes-connectivity/iw/iw_3.8.bb | 27 ++++
> 6 files changed, 329 insertions(+)
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-
> 2.2/defconfig
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-
> 2.2/hostapd.service
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/init
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd_2.2.bb
> create mode 100644 meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-
> don-t-use-git-describe-for-versioning.patch
> create mode 100644 meta/recipes-connectivity/iw/iw_3.8.bb
>
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] recipes-connectivity: Add hostapd configuration for enabling Marvell 8897 WiFi feature
2015-07-09 5:10 ` [PATCH 1/2] recipes-connectivity: Add hostapd configuration for enabling Marvell 8897 WiFi feature wei.tee.ng
@ 2015-07-27 14:03 ` Richard Purdie
0 siblings, 0 replies; 13+ messages in thread
From: Richard Purdie @ 2015-07-27 14:03 UTC (permalink / raw
To: wei.tee.ng; +Cc: openembedded-core
On Thu, 2015-07-09 at 13:10 +0800, wei.tee.ng@intel.com wrote:
> From: Ng Shui Lei <shui.lei.ng@intel.com>
>
> Hostapd features was created in the recipes-connectivity
> layer to enable Marvell 8897 module in AP mode and STA mode.
>
> Signed-off-by: Ng Shui Lei <shui.lei.ng@intel.com>
> Signed-off-by: Ng Wei Tee <wei.tee.ng@intel.com>
> ---
> .../hostapd/hostapd-2.2/defconfig | 145 ++++++++++++++++++++
> .../hostapd/hostapd-2.2/hostapd.service | 11 ++
> meta/recipes-connectivity/hostapd/hostapd-2.2/init | 58 ++++++++
> meta/recipes-connectivity/hostapd/hostapd_2.2.bb | 48 +++++++
> 4 files changed, 262 insertions(+)
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/defconfig
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/hostapd.service
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd-2.2/init
> create mode 100644 meta/recipes-connectivity/hostapd/hostapd_2.2.bb
I'm by no means a comms expert which is one of the reasons I've not
replied to this, I'd hoped someone with more knowledge would. Part of
the issue here is that hostapd and connmand have overlapping
functionality, conflicting in some cases.
So the question is why do we need hostapd if we have connman (which is
already in OE-Core)?
Cheers,
Richard
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] recipes-connectivity: Add iw configuration for enabling Marvell 8897 WiFi feature
2015-07-09 5:10 ` [PATCH 2/2] recipes-connectivity: Add iw " wei.tee.ng
@ 2015-07-27 14:07 ` Richard Purdie
0 siblings, 0 replies; 13+ messages in thread
From: Richard Purdie @ 2015-07-27 14:07 UTC (permalink / raw
To: wei.tee.ng; +Cc: openembedded-core
On Thu, 2015-07-09 at 13:10 +0800, wei.tee.ng@intel.com wrote:
> From: Ng Shui Lei <shui.lei.ng@intel.com>
>
> iw features was created in the recipes-connectivity layer to
> enable Marvell 8897 module in AP mode and STA mode. iw is a
> new nl80211 based CLI configuration utility for wireless devices.
>
> Signed-off-by: Ng Shui Lei <shui.lei.ng@intel.com>
> Signed-off-by: Ng Wei Tee <wei.tee.ng@intel.com>
> ---
> ....sh-don-t-use-git-describe-for-versioning.patch | 40 ++++++++++++++++++++
> meta/recipes-connectivity/iw/iw_3.8.bb | 27 +++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch
> create mode 100644 meta/recipes-connectivity/iw/iw_3.8.bb
1. How is this patch specific to the Marvell 8897 chip?
2. Did this recipe come from another layer? If so, saying where it came
from would be good.
3. Why do we want iw in OE-Core. I can see a case for it but you do need
to explain that here in the commit message.
4. There are some cleanliness tweaks needed (see below).
> diff --git a/meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch b/meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch
> new file mode 100644
> index 0000000..f4a7ee7
> --- /dev/null
> +++ b/meta/recipes-connectivity/iw/iw-3.8/0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch
> @@ -0,0 +1,40 @@
> +From: Koen Kooi <koen@dominion.thruhere.net>
> +Date: Tue, 29 Nov 2011 17:03:27 +0100
> +Subject: [PATCH] iw: version.sh: don't use git describe for versioning
> +
> +It will detect top-level git repositories like the Angstrom setup-scripts and break.
> +
> +Upstream-status: Unknown
"Pending" perhaps? or "Inappropriate" looking at what the patch does.
> +Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> +---
> + version.sh | 16 +---------------
> + 1 file changed, 1 insertion(+), 15 deletions(-)
> +
> +diff --git a/version.sh b/version.sh
> +index db02f0d..336ce2b 100755
> +--- a/version.sh
> ++++ b/version.sh
> +@@ -3,21 +3,7 @@
> + VERSION="3.8"
> + OUT="$1"
> +
> +-if head=`git rev-parse --verify HEAD 2>/dev/null`; then
> +- git update-index --refresh --unmerged > /dev/null
> +- descr=$(git describe)
> +-
> +- # on git builds check that the version number above
> +- # is correct...
> +- [ "${descr%%-*}" = "v$VERSION" ] || exit 2
> +-
> +- v="${descr#v}"
> +- if git diff-index --name-only HEAD | read dummy ; then
> +- v="$v"-dirty
> +- fi
> +-else
> +- v="$VERSION"
> +-fi
> ++v="$VERSION"
> +
> + echo '#include "iw.h"' > "$OUT"
> + echo "const char iw_version[] = \"$v\";" >> "$OUT"
> diff --git a/meta/recipes-connectivity/iw/iw_3.8.bb b/meta/recipes-connectivity/iw/iw_3.8.bb
> new file mode 100644
> index 0000000..29dbcd0
> --- /dev/null
> +++ b/meta/recipes-connectivity/iw/iw_3.8.bb
> @@ -0,0 +1,27 @@
> +# Copyright (C) 2013 Digi International.
> +
> +SUMMARY = "nl80211 based CLI configuration utility for wireless devices"
> +DESCRIPTION = "iw is a new nl80211 based CLI configuration utility for \
> +wireless devices. It supports almost all new drivers that have been added \
> +to the kernel recently. "
> +HOMEPAGE = "http://linuxwireless.org/en/users/Documentation/iw"
> +SECTION = "base"
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=878618a5c4af25e9b93ef0be1a93f774"
> +
> +DEPENDS = "libnl pkgconfig"
> +
> +PR = "${DISTRO}.r0"
DISTRO in PR sounds plain wrong.
> +
> +SRC_URI = "http://www.kernel.org/pub/software/network/iw/iw-${PV}.tar.bz2 \
> + file://0001-iw-version.sh-don-t-use-git-describe-for-versioning.patch \
> + "
> +
> +SRC_URI[md5sum] = "618ad1106a196fb1c3d827de96da437c"
> +SRC_URI[sha256sum] = "3dae92ca5989cbc21155941fa01907a5536da3c5f6898642440c61484fc7e0f9"
> +
> +EXTRA_OEMAKE = ""
> +
> +do_install() {
> + oe_runmake DESTDIR=${D} install
> +}
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-09 5:10 [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature wei.tee.ng
` (3 preceding siblings ...)
2015-07-27 5:21 ` Ng, Wei Tee
@ 2015-07-27 16:41 ` Otavio Salvador
2015-07-27 18:15 ` Hugo Vasconcelos Saldanha
4 siblings, 1 reply; 13+ messages in thread
From: Otavio Salvador @ 2015-07-27 16:41 UTC (permalink / raw
To: wei.tee.ng; +Cc: Patches and discussions about the oe-core layer
On Thu, Jul 9, 2015 at 2:10 AM, <wei.tee.ng@intel.com> wrote:
> I would like to add hostapd and iw configuration for enabling
> Marvell 8897 Wifi feature. Hostapd and iw configuration were
> created in the recipes-connectivity layer to enable Marvell 8897
> module function in AP mode and STA mode.
It can be added for master, I think. For Dizzy it makes no sense to
backport this feature.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-27 16:41 ` Otavio Salvador
@ 2015-07-27 18:15 ` Hugo Vasconcelos Saldanha
2015-07-27 18:28 ` Otavio Salvador
0 siblings, 1 reply; 13+ messages in thread
From: Hugo Vasconcelos Saldanha @ 2015-07-27 18:15 UTC (permalink / raw
To: Otavio Salvador
Cc: wei.tee.ng@intel.com,
Patches and discussions about the oe-core layer
On Mon, Jul 27, 2015 at 01:41:45PM -0300, Otavio Salvador wrote:
> On Thu, Jul 9, 2015 at 2:10 AM, <wei.tee.ng@intel.com> wrote:
> > I would like to add hostapd and iw configuration for enabling
> > Marvell 8897 Wifi feature. Hostapd and iw configuration were
> > created in the recipes-connectivity layer to enable Marvell 8897
> > module function in AP mode and STA mode.
>
> It can be added for master, I think. For Dizzy it makes no sense to
> backport this feature.
FWIW, both recipes are available in meta-oe layer, including dizzy
branch.
--
Hugo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-27 18:15 ` Hugo Vasconcelos Saldanha
@ 2015-07-27 18:28 ` Otavio Salvador
2015-07-27 18:45 ` Burton, Ross
2015-07-27 18:47 ` Hugo Vasconcelos Saldanha
0 siblings, 2 replies; 13+ messages in thread
From: Otavio Salvador @ 2015-07-27 18:28 UTC (permalink / raw
To: Hugo Vasconcelos Saldanha
Cc: wei.tee.ng@intel.com,
Patches and discussions about the oe-core layer
On Mon, Jul 27, 2015 at 3:15 PM, Hugo Vasconcelos Saldanha
<hugo.saldanha@aker.com.br> wrote:
> On Mon, Jul 27, 2015 at 01:41:45PM -0300, Otavio Salvador wrote:
>> On Thu, Jul 9, 2015 at 2:10 AM, <wei.tee.ng@intel.com> wrote:
>> > I would like to add hostapd and iw configuration for enabling
>> > Marvell 8897 Wifi feature. Hostapd and iw configuration were
>> > created in the recipes-connectivity layer to enable Marvell 8897
>> > module function in AP mode and STA mode.
>>
>> It can be added for master, I think. For Dizzy it makes no sense to
>> backport this feature.
>
> FWIW, both recipes are available in meta-oe layer, including dizzy
> branch.
Sure but this is not a bugfix. I am opposed to backport features
without a very clear reason and this does not seem to qualify as a
massive need.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-27 18:28 ` Otavio Salvador
@ 2015-07-27 18:45 ` Burton, Ross
2015-07-28 9:24 ` Ng, Wei Tee
2015-07-27 18:47 ` Hugo Vasconcelos Saldanha
1 sibling, 1 reply; 13+ messages in thread
From: Burton, Ross @ 2015-07-27 18:45 UTC (permalink / raw
To: Otavio Salvador
Cc: wei.tee.ng@intel.com,
Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On 27 July 2015 at 19:28, Otavio Salvador <otavio.salvador@ossystems.com.br>
wrote:
> Sure but this is not a bugfix. I am opposed to backport features
> without a very clear reason and this does not seem to qualify as a
> massive need.
>
Indeed, and existence in meta-oe is an even better reason *not* to backport
to oe-core dizzy. If there's a product being built on the dizzy release,
then these can be added to your distro layer (or meta-oe used directly).
Ross
[-- Attachment #2: Type: text/html, Size: 903 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-27 18:28 ` Otavio Salvador
2015-07-27 18:45 ` Burton, Ross
@ 2015-07-27 18:47 ` Hugo Vasconcelos Saldanha
1 sibling, 0 replies; 13+ messages in thread
From: Hugo Vasconcelos Saldanha @ 2015-07-27 18:47 UTC (permalink / raw
To: Otavio Salvador
Cc: wei.tee.ng@intel.com,
Patches and discussions about the oe-core layer
On Mon, Jul 27, 2015 at 03:28:46PM -0300, Otavio Salvador wrote:
> On Mon, Jul 27, 2015 at 3:15 PM, Hugo Vasconcelos Saldanha
> <hugo.saldanha@aker.com.br> wrote:
> > On Mon, Jul 27, 2015 at 01:41:45PM -0300, Otavio Salvador wrote:
> >> On Thu, Jul 9, 2015 at 2:10 AM, <wei.tee.ng@intel.com> wrote:
> >> > I would like to add hostapd and iw configuration for enabling
> >> > Marvell 8897 Wifi feature. Hostapd and iw configuration were
> >> > created in the recipes-connectivity layer to enable Marvell 8897
> >> > module function in AP mode and STA mode.
> >>
> >> It can be added for master, I think. For Dizzy it makes no sense to
> >> backport this feature.
> >
> > FWIW, both recipes are available in meta-oe layer, including dizzy
> > branch.
>
> Sure but this is not a bugfix. I am opposed to backport features
> without a very clear reason and this does not seem to qualify as a
> massive need.
>
Totally agreed. I was just questioning the need to add these recipes to
oe-core since they are available elsewhere.
--
Hugo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
2015-07-27 18:45 ` Burton, Ross
@ 2015-07-28 9:24 ` Ng, Wei Tee
0 siblings, 0 replies; 13+ messages in thread
From: Ng, Wei Tee @ 2015-07-28 9:24 UTC (permalink / raw
To: Burton, Ross, Otavio Salvador
Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
Alright. After getting input from you guys, I will add it in distro layer. Thanks for the time and advice.
Regards,
Wei Tee
From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Tuesday, July 28, 2015 2:46 AM
To: Otavio Salvador
Cc: Hugo Vasconcelos Saldanha; Ng, Wei Tee; Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature
On 27 July 2015 at 19:28, Otavio Salvador <otavio.salvador@ossystems.com.br<mailto:otavio.salvador@ossystems.com.br>> wrote:
Sure but this is not a bugfix. I am opposed to backport features
without a very clear reason and this does not seem to qualify as a
massive need.
Indeed, and existence in meta-oe is an even better reason *not* to backport to oe-core dizzy. If there's a product being built on the dizzy release, then these can be added to your distro layer (or meta-oe used directly).
Ross
[-- Attachment #2: Type: text/html, Size: 4243 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-07-28 9:26 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-09 5:10 [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature wei.tee.ng
2015-07-09 5:10 ` [PATCH 1/2] recipes-connectivity: Add hostapd configuration for enabling Marvell 8897 WiFi feature wei.tee.ng
2015-07-27 14:03 ` Richard Purdie
2015-07-09 5:10 ` [PATCH 2/2] recipes-connectivity: Add iw " wei.tee.ng
2015-07-27 14:07 ` Richard Purdie
2015-07-21 1:32 ` [PATCH 0/2] [master][dizzy] Enable Marvel 8897 Wifi feature Ng, Wei Tee
2015-07-27 5:21 ` Ng, Wei Tee
2015-07-27 16:41 ` Otavio Salvador
2015-07-27 18:15 ` Hugo Vasconcelos Saldanha
2015-07-27 18:28 ` Otavio Salvador
2015-07-27 18:45 ` Burton, Ross
2015-07-28 9:24 ` Ng, Wei Tee
2015-07-27 18:47 ` Hugo Vasconcelos Saldanha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.