* [PATCH lttng-tools] Update comments regarding the requirement of power of 2 for sub-buffer size
@ 2015-07-10 21:50 Jonathan Rajotte
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Rajotte @ 2015-07-10 21:50 UTC (permalink / raw
To: lttng-dev; +Cc: jgalar
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
---
include/lttng/channel.h | 2 +-
src/bin/lttng-sessiond/lttng-ust-abi.h | 2 +-
src/bin/lttng-sessiond/lttng-ust-ctl.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/lttng/channel.h b/include/lttng/channel.h
index 6ab0c7b..2007d06 100644
--- a/include/lttng/channel.h
+++ b/include/lttng/channel.h
@@ -33,7 +33,7 @@ extern "C" {
#define LTTNG_CHANNEL_ATTR_PADDING1 LTTNG_SYMBOL_NAME_LEN + 12
struct lttng_channel_attr {
int overwrite; /* 1: overwrite, 0: discard */
- uint64_t subbuf_size; /* bytes */
+ uint64_t subbuf_size; /* bytes power of 2 */
uint64_t num_subbuf; /* power of 2 */
unsigned int switch_timer_interval; /* usec */
unsigned int read_timer_interval; /* usec */
diff --git a/src/bin/lttng-sessiond/lttng-ust-abi.h b/src/bin/lttng-sessiond/lttng-ust-abi.h
index 81b6149..ae3ac22 100644
--- a/src/bin/lttng-sessiond/lttng-ust-abi.h
+++ b/src/bin/lttng-sessiond/lttng-ust-abi.h
@@ -166,7 +166,7 @@ struct lttng_ust_context {
*/
#define LTTNG_UST_CHANNEL_ATTR_PADDING (LTTNG_UST_SYM_NAME_LEN + 32)
struct lttng_ust_channel_attr {
- uint64_t subbuf_size; /* bytes */
+ uint64_t subbuf_size; /* bytes power of 2 */
uint64_t num_subbuf; /* power of 2 */
int overwrite; /* 1: overwrite, 0: discard */
unsigned int switch_timer_interval; /* usec */
diff --git a/src/bin/lttng-sessiond/lttng-ust-ctl.h b/src/bin/lttng-sessiond/lttng-ust-ctl.h
index 7f59b86..0bb717e 100644
--- a/src/bin/lttng-sessiond/lttng-ust-ctl.h
+++ b/src/bin/lttng-sessiond/lttng-ust-ctl.h
@@ -45,7 +45,7 @@ struct lttng_ust_lib_ring_buffer;
struct ustctl_consumer_channel_attr {
enum lttng_ust_chan_type type;
- uint64_t subbuf_size; /* bytes */
+ uint64_t subbuf_size; /* bytes power of 2 */
uint64_t num_subbuf; /* power of 2 */
int overwrite; /* 1: overwrite, 0: discard */
unsigned int switch_timer_interval; /* usec */
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH lttng-tools] Update comments regarding the requirement of power of 2 for sub-buffer size
[not found] <1436565002-15575-1-git-send-email-jonathan.rajotte-julien@efficios.com>
@ 2015-07-13 15:22 ` Jérémie Galarneau
0 siblings, 0 replies; 2+ messages in thread
From: Jérémie Galarneau @ 2015-07-13 15:22 UTC (permalink / raw
To: Jonathan Rajotte; +Cc: lttng-dev@lists.lttng.org, Jeremie Galarneau
[-- Attachment #1.1: Type: text/plain, Size: 2710 bytes --]
Merged in master, stable-2.6 and stable-2.5.
Thanks!
Jérémie
On Fri, Jul 10, 2015 at 5:50 PM, Jonathan Rajotte <
jonathan.rajotte-julien@efficios.com> wrote:
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
> include/lttng/channel.h | 2 +-
> src/bin/lttng-sessiond/lttng-ust-abi.h | 2 +-
> src/bin/lttng-sessiond/lttng-ust-ctl.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/lttng/channel.h b/include/lttng/channel.h
> index 6ab0c7b..2007d06 100644
> --- a/include/lttng/channel.h
> +++ b/include/lttng/channel.h
> @@ -33,7 +33,7 @@ extern "C" {
> #define LTTNG_CHANNEL_ATTR_PADDING1 LTTNG_SYMBOL_NAME_LEN + 12
> struct lttng_channel_attr {
> int overwrite; /* 1: overwrite, 0: discard */
> - uint64_t subbuf_size; /* bytes */
> + uint64_t subbuf_size; /* bytes power of 2 */
> uint64_t num_subbuf; /* power of 2 */
> unsigned int switch_timer_interval; /* usec */
> unsigned int read_timer_interval; /* usec */
> diff --git a/src/bin/lttng-sessiond/lttng-ust-abi.h
> b/src/bin/lttng-sessiond/lttng-ust-abi.h
> index 81b6149..ae3ac22 100644
> --- a/src/bin/lttng-sessiond/lttng-ust-abi.h
> +++ b/src/bin/lttng-sessiond/lttng-ust-abi.h
> @@ -166,7 +166,7 @@ struct lttng_ust_context {
> */
> #define LTTNG_UST_CHANNEL_ATTR_PADDING (LTTNG_UST_SYM_NAME_LEN + 32)
> struct lttng_ust_channel_attr {
> - uint64_t subbuf_size; /* bytes */
> + uint64_t subbuf_size; /* bytes power of 2 */
> uint64_t num_subbuf; /* power of 2 */
> int overwrite; /* 1: overwrite, 0:
> discard */
> unsigned int switch_timer_interval; /* usec */
> diff --git a/src/bin/lttng-sessiond/lttng-ust-ctl.h
> b/src/bin/lttng-sessiond/lttng-ust-ctl.h
> index 7f59b86..0bb717e 100644
> --- a/src/bin/lttng-sessiond/lttng-ust-ctl.h
> +++ b/src/bin/lttng-sessiond/lttng-ust-ctl.h
> @@ -45,7 +45,7 @@ struct lttng_ust_lib_ring_buffer;
>
> struct ustctl_consumer_channel_attr {
> enum lttng_ust_chan_type type;
> - uint64_t subbuf_size; /* bytes */
> + uint64_t subbuf_size; /* bytes power of 2 */
> uint64_t num_subbuf; /* power of 2 */
> int overwrite; /* 1: overwrite, 0:
> discard */
> unsigned int switch_timer_interval; /* usec */
> --
> 2.1.4
>
>
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
[-- Attachment #1.2: Type: text/html, Size: 3604 bytes --]
[-- Attachment #2: Type: text/plain, Size: 155 bytes --]
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-13 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-10 21:50 [PATCH lttng-tools] Update comments regarding the requirement of power of 2 for sub-buffer size Jonathan Rajotte
[not found] <1436565002-15575-1-git-send-email-jonathan.rajotte-julien@efficios.com>
2015-07-13 15:22 ` Jérémie Galarneau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.