From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 18/28] tools/libxl: Infrastructure to convert a legacy stream Date: Mon, 13 Jul 2015 17:04:09 +0100 Message-ID: <1436803449.25044.15.camel@citrix.com> References: <1436788907-1921-1-git-send-email-andrew.cooper3@citrix.com> <1436788907-1921-19-git-send-email-andrew.cooper3@citrix.com> <21923.53028.222582.402092@mariner.uk.xensource.com> <55A3D476.8040105@citrix.com> <21923.56522.314560.338503@mariner.uk.xensource.com> <55A3DEFA.1020303@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55A3DEFA.1020303@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Wei Liu , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 2015-07-13 at 16:53 +0100, Andrew Cooper wrote: > I could see about doing something based on BITS_PER_LONG which doesn't > have a visible ifdef, but is still ifdefary. Given that it is the reason for the width differences in the old stream using sizeof(unsigned long) wouldn't seem massively inappropriate, indeed. I'm not sure it's especially necessary to launder that through bits_per_long though. Ian.