From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752575AbbGMTub (ORCPT ); Mon, 13 Jul 2015 15:50:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36738 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbbGMTua (ORCPT ); Mon, 13 Jul 2015 15:50:30 -0400 Message-ID: <1436817022.27924.74.camel@stgolabs.net> Subject: Re: [PATCH 3/7] locking/pvqspinlock: Implement wait-early for overcommitted guest From: Davidlohr Bueso To: Waiman Long Cc: Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Scott J Norton , Douglas Hatch Date: Mon, 13 Jul 2015 12:50:22 -0700 In-Reply-To: <1436647018-49734-4-git-send-email-Waiman.Long@hp.com> References: <1436647018-49734-1-git-send-email-Waiman.Long@hp.com> <1436647018-49734-4-git-send-email-Waiman.Long@hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-07-11 at 16:36 -0400, Waiman Long wrote: > /* > + * Queued Spinlock Spin Thresholds > + * ------------------------------- > + * Because of the cacheline contention effect of the ticket spinlock, the > + * same spin threshold for queued spinlock will run a bit faster. So we set > + * a slight larger threshold for the queue head (1.25X) while the other queue > + * nodes will keep the same threshold. How did you come to 1.25x? These sort of magic numbers scare me.