From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754187AbbGNKfJ (ORCPT ); Tue, 14 Jul 2015 06:35:09 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46556 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753498AbbGNKfH (ORCPT ); Tue, 14 Jul 2015 06:35:07 -0400 Message-Id: <1436870105.1513647.323227889.372B7AD8@webmail.messagingengine.com> X-Sasl-Enc: ErHRlkpnfvkvJw775fydbAUJdZRn3g1iD2QBkeNexaDN 1436870105 From: Henrique de Moraes Holschuh To: "Jason A. Donenfeld" , ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-63a5d8c6 In-Reply-To: <1436827609-2255-1-git-send-email-Jason@zx2c4.com> References: <1436827609-2255-1-git-send-email-Jason@zx2c4.com> Subject: Re: [PATCH] thinkpad_acpi: Support micmute LED Date: Tue, 14 Jul 2015 07:35:05 -0300 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NACK. This LED needs to be hooked internally (kernel-side) to the ALSA mixer entry responsible for MIC muting. It should NOT be exposed to userspace directly. The LED state should only be modified when the MIC mute gate state changes. This means a private trigger, directly in ALSA, like the speaker mute led. And it most definately is not supposed to be added to TPACPI_SAFE_LEDS *ever*. On Mon, Jul 13, 2015, at 19:46, Jason A. Donenfeld wrote: > The micmute LED is currently unused. This patch allows it to be hooked > up to various LED triggers. > > Signed-off-by: Jason A. Donenfeld > --- > drivers/platform/x86/thinkpad_acpi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 33e488c..ca4c435 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -5281,8 +5281,10 @@ static const char * const > tpacpi_led_names[TPACPI_LED_NUMLEDS] = { > "tpacpi::unknown_led2", > "tpacpi::unknown_led3", > "tpacpi::thinkvantage", > + "tpacpi::unknown_led4", > + "tpacpi::micmute" > }; > -#define TPACPI_SAFE_LEDS 0x1081U > +#define TPACPI_SAFE_LEDS 0x5081U > t > static inline bool tpacpi_is_led_restricted(const unsigned int led) > { > @@ -5505,7 +5507,7 @@ static const struct tpacpi_quirk > led_useful_qtable[] __initconst = { > { /* Lenovo */ > .vendor = PCI_VENDOR_ID_LENOVO, > .bios = TPACPI_MATCH_ANY, .ec = TPACPI_MATCH_ANY, > - .quirks = 0x1fffU, > + .quirks = 0x5fffU, > }, > { /* IBM ThinkPads with no EC version string */ > .vendor = PCI_VENDOR_ID_IBM, -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh