From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v7 COLO 00/18] COarse-grain LOck-stepping Virtual Machines for Non-stop Service Date: Tue, 14 Jul 2015 16:55:55 +0100 Message-ID: <1436889355.11153.9.camel@citrix.com> References: <1435213872-10698-1-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435213872-10698-1-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-06-25 at 14:30 +0800, Yang Hongyang wrote: > This patchset implemented the COLO feature for Xen. > For detail/install/use of COLO feature, refer to: > http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping > > This patchset is based on: > [PATCH v3 COLOPre 00/26] Prerequisite patches for COLO > and on: > http://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/libxl-migv2-v1 I started going over this but once I got to the meat I realised that it was based on this older version and that quite a bit had changed in migrv2 since (and I think migrv2 v4.1 includes bits of this series already from the looks of it). I tried to do the naive git rebase, but it resulted in more conflicts than I could deal with. So my question is, should I continue to look at this version or should I await a v8 based on the latest migration stuff? Have you been following the review of migrv2? In particular I think some of Ian J's comments there on the state machines and the comments/assumptions about states etc may apply to bits of this series too. I'm thinking in particular of the comments on "tools/libxl: Infrastructure for reading a libxl migration v2 stream" on v2 and v3 or that series. Ian.