All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed

From: Paul Bolle <pebolle@tiscali.nl>
To: Henri Chain <henri.chain@eleves.ec-nantes.fr>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org, sudipm.mukherjee@gmail.com
Subject: Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller
Date: Wed, 15 Jul 2015 11:36:30 +0200	[thread overview]
Message-ID: <1436952990.2679.84.camel@tiscali.nl> (raw)
In-Reply-To: <1436878779-12400-1-git-send-email-henri.chain@eleves.ec-nantes.fr>

On di, 2015-07-14 at 14:59 +0200, Henri Chain wrote:
> --- /dev/null
> +++ b/drivers/staging/fbtft/fb_uc1611.c

> +#define DRVNAME		"fb_uc1611"

> +MODULE_ALIAS("spi:" DRVNAME);
> +MODULE_ALIAS("platform:" DRVNAME);
> +MODULE_ALIAS("spi:uc1611");
> +MODULE_ALIAS("platform:uc1611");

Many of the drivers under drivers/staging/fbtft use a comparable set of
aliases. But I wonder if they are all needed (here, and in the other
drivers).

In this case I think I understand how the "fb_uc1611" .modalias (see
below) will eventually trigger a "MODALIAS=spi:fb_uc1611" uevent. And
that uevent will make userspace load the fb_uc1611.ko module, right?

But is there a similar way that "spi:uc1611" fits into the system?
Because I couldn't spot anything similar for "uc1611".

Likewise, "platform:fb_uc1611" and "platform:uc1611" require struct
platform_device's with "fb_uc1611" and "uc1611" .name's. But I couldn't
spot where platform_device's with those .name's are created. How do
these two aliases fit into the system?

> --- a/drivers/staging/fbtft/fbtft_device.c
> +++ b/drivers/staging/fbtft/fbtft_device.c

> +		.name = "ew24ha0",
> +		.spi = &(struct spi_board_info) {
> +			.modalias = "fb_uc1611",
> +			.max_speed_hz = 32000000,
> +			.mode = SPI_MODE_3,
> +			.platform_data = &(struct fbtft_platform_data) {
> +				.display = {
> +					.buswidth = 8,
> +				},
> +				.gpios = (const struct fbtft_gpio []) {
> +					{ "dc", 24 },
> +					{},
> +				},
> +			}
> +		}
> +	}, {
> +		.name = "ew24ha0_9bit",
> +		.spi = &(struct spi_board_info) {
> +			.modalias = "fb_uc1611",
> +			.max_speed_hz = 32000000,
> +			.mode = SPI_MODE_3,
> +			.platform_data = &(struct fbtft_platform_data) {
> +				.display = {
> +					.buswidth = 9,
> +				},
> +				.gpios = (const struct fbtft_gpio []) {
> +					{},
> +				},
> +			}
> +		}
> +	}, {

Thanks,


Paul Bolle

next prev parent reply	other threads:[~2015-07-15  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 12:59 [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller Henri Chain
2015-07-15  9:36 ` Paul Bolle [this message]
2015-07-23 12:14   ` Noralf Trønnes
2015-07-23 13:06 ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436952990.2679.84.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=henri.chain@eleves.ec-nantes.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.