From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753419AbbGOKa3 (ORCPT ); Wed, 15 Jul 2015 06:30:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:35489 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753316AbbGOKa0 (ORCPT ); Wed, 15 Jul 2015 06:30:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,479,1432623600"; d="asc'?scan'208";a="524644015" Message-ID: <1436956216.13597.8.camel@intel.com> Subject: Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM From: Jeff Kirsher To: Michael Ellerman , "Avargil, Raanan" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, aaron.f.brown@intel.com, yanirx.lubetkin@intel.com, jesse.brandeburg@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com Date: Wed, 15 Jul 2015 03:30:16 -0700 In-Reply-To: <1436846075-29366-1-git-send-email-mpe@ellerman.id.au> References: <1436846075-29366-1-git-send-email-mpe@ellerman.id.au> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-VTmvpgczFj7nlI2vzPPt" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-VTmvpgczFj7nlI2vzPPt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is > inside CONFIG_PM. So when CONFIG_PM=3Dn we get a "defined but not used" > warning for e1000e_disable_aspm_locked(). >=20 > Move it inside the existing CONFIG_PM block to avoid the warning. >=20 > Signed-off-by: Michael Ellerman > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) NACK, this is already fixed in my next-queue tree. Raanan submitted a patch back on July 6th to resolve this issue, see commit id a75787d2246a93d256061db602f252703559af65 in my dev-queue branch of my next-queue tree. --=-VTmvpgczFj7nlI2vzPPt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJVpjY4AAoJEOVv75VaS+3O/W8P/2uoSYqLpIaS+AcDevRk8ZGF sXzubM8BaL6TFWTQmpNXXVXnwl0uusdUP10+p+s2ngmU/0DLNAGVo1TvkAM+MoJ0 9EasSsiNE9+WwSgUnLA8U1MdxXcMsbGA38n7QzBf8YzdVdNPmJ5owaXhO5ipjVyj OPO25UpgoWkERGm8qWgnHIt4jrwPx0GYHU9LR2reUOZALosU4tGzQhprwSDwCmZy m4Nf25h7w59y+PsnrYAiGN0ENsuP8sE8HtE6QekFWDfTP5YBXM43d7uxsUL3TLsl TfwlXkaPpcAQX9bLv7hUD9vifGTY+wlVftBx8JgP5YyXX0BtGZyusD4YT4Go1lnb iv7A7OSA1UYtGAx5trABtvzfkJSUJrgAnoVMUHMk80iqDBUuhOc1RrrNkzCBAFMx vyE8AlZ9V+0GSjgJglYGAbmdVI4iOUu+ptDWwBNpGp8yEf+KpJjnHmKuXlmxgFeq PnlAWm5GaD321BCLDxrMpLe/mtSyeZ8YTpVSZQHumJNMblcMDtykCM56F5ms6AhY SLEB1rR7LXokKkqUeQfX2DxPx//kIjOZRn2IZpuzUIxLtvs1l87HQOJhmqbR+NP8 N2GinMMlzhy4KWMvwZIoiDlzZ8Ul+/OsAJty62LUNwqBVNky0CdQ3jA9T6hVYJT3 DJ4zSfWUtaBw+JI4FP14 =52GT -----END PGP SIGNATURE----- --=-VTmvpgczFj7nlI2vzPPt-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Wed, 15 Jul 2015 03:30:16 -0700 Subject: [Intel-wired-lan] [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM In-Reply-To: <1436846075-29366-1-git-send-email-mpe@ellerman.id.au> References: <1436846075-29366-1-git-send-email-mpe@ellerman.id.au> Message-ID: <1436956216.13597.8.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is > inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used" > warning for e1000e_disable_aspm_locked(). > > Move it inside the existing CONFIG_PM block to avoid the warning. > > Signed-off-by: Michael Ellerman > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) NACK, this is already fixed in my next-queue tree. Raanan submitted a patch back on July 6th to resolve this issue, see commit id a75787d2246a93d256061db602f252703559af65 in my dev-queue branch of my next-queue tree. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: