From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v15 1/4] ethdev: add apis to support access device info Date: Wed, 15 Jul 2015 13:20:30 +0200 Message-ID: <1436962741.PL5XZBfjSs@xps13> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <4907797.WMXsT5lYd9@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Wang, Liang-min" Return-path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C9AC25A0A for ; Wed, 15 Jul 2015 13:21:42 +0200 (CEST) Received: by wgkl9 with SMTP id l9so30889673wgk.1 for ; Wed, 15 Jul 2015 04:21:42 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-15 10:48, Wang, Liang-min: > > > > What means magic? Is it always a device id? > > > This field is the same as defined in kernel ethtool data structure. > > > > Not an excellent argument :) > > Actually you didn't answer. > > > I could not speak for other devices. For igb and ixgbe, it's device id. > Based upon literature search, this field is used by device driver to provide extra information. > What would be your suggestion? I don't have any suggestion. You are defining a new API in DPDK, so our concern must be to check that it will be easily understood by users and PMD developers. If you don't really know what this field will be for, others won't know.