From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 1/3] arm64: Add Xen boot support file Date: Thu, 16 Jul 2015 17:46:12 +0100 Message-ID: <1437065172.32371.261.camel@citrix.com> References: <=fu.wei@linaro.org> <1436777640-31871-1-git-send-email-fu.wei@linaro.org> <1436777640-31871-2-git-send-email-fu.wei@linaro.org> <55A687E5.4070106@gmail.com> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <55A687E5.4070106@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: Vladimir =?UTF-8?Q?=27=CF=86-coder/phcoder=27?= Serbinenko Cc: grub-devel@gnu.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, arvidjaar@gmail.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE1LTA3LTE1IGF0IDE4OjE4ICswMjAwLCBWbGFkaW1pciAnz4YtY29kZXIvcGhj b2RlcicgU2VyYmluZW5rbwp3cm90ZToKPiBPbiAxMy4wNy4yMDE1IDEwOjUzLCBmdS53ZWlAbGlu YXJvLm9yZyB3cm90ZToKPiA+IEZyb206IEZ1IFdlaSA8ZnUud2VpQGxpbmFyby5vcmc+Cj4gPiAK PiA+IFRoaXMgcGF0Y2ggYWRkcyBYZW4gYm9vdCBzdXBwb3J0IGZpbGU6Cj4gPiBncnViLWNvcmUv bG9hZGVyL2FybTY0L3hlbl9ib290LmMKPiA+IGluY2x1ZGUvZ3J1Yi9hcm02NC94ZW5fYm9vdC5o Cj4gPiAKPiA+IFRoaXMgcGF0Y2ggYWxzbyBhZGRzIGNvbW1hbmRzIHJlZ2lzdGVyIGNvZGUgYW5k IGhlYXJkZXIgZmlsZSBpbnRvCj4gPiBncnViLWNvcmUvbG9hZGVyL2FybTY0L2xpbnV4LmMKPiA+ IAo+ID4gICAtIFRoaXMgYWRkcyBzdXBwb3J0IGZvciB0aGUgWGVuIGJvb3Qgb24gQVJNIHNwZWNp ZmljYXRpb24gZm9yIGFybTY0Lgo+ID4gICAtIFRoZSBpbXBsZW1lbnRhdGlvbiBmb3IgWGVuIGlz IGZvbGxvd2luZyAgPE11bHRpYm9vdCBvbiBBUk0gU3BlY2lmaWNhdGlvbj46Cj4gPiAgICAgICBo dHRwOi8vd2lraS54ZW4ub3JnL3dpa2kvWGVuX0FSTV93aXRoX1ZpcnR1YWxpemF0aW9uX0V4dGVu c2lvbnMvTXVsdGlib290Cj4gUGxlYXNlIGRvbid0IHJlZmVyIHRvIHRoaXMgcHJvdG9jb2wgYXMg bXVsdGlib290IGFueXdoZXJlIGluIGdydWIgb3IKPiBhcm91bmQgYmVjYXVzZSBpdCdzIE5PVCBt dWx0aWJvb3QgYW5kIHdlIGRvbid0IHdhbnQgdG8gY29uZnVzZSB0aG9zZSAyCj4gcHJvdG9jb2xz LgoKVGhhdCdzIGZhaXIgZW5vdWdoLCBteSBob3BlIHdhcyB0aGF0IHRoZSBkb2NzIGFuZCBjb21t dW5hbCBrbm93bGVkZ2UKYWJvdXQgaG93IHRvIHdyaXRlIGEgZ3J1Yi5jZmcgZm9yIFhlbiB4ODYv bXVsdGlib290IGNvdWxkIHJlbWFpbgp1bmNoYW5nZWQgZm9yIFhlbiBvbiBhcm0gKGUuZy4gYnkg dXNpbmcgdGhlIHNhbWUgbXVsdGlib290MSBjb21tYW5kCm5hbWVzLCB3aGljaCBzdXJlbHkgd29u J3QgYmUgcmV1c2VkIG9uIGFybSksIGJ1dCBJIGNhbiBzZWUgd2h5IHlvdSB3b3VsZApvYmplY3Qg dG8gdGhhdCBhbmQgdXBkYXRpbmcgMjBfbGludXhfeGVuIHRvIERUUlQgb24gYm90aCBhcmNoZXMg c29sdmVzCnRoZSBtYWpvcml0eSBvZiB0aGF0IGNvbmNlcm4uCgpXUlQgdG8gd2hhdCB0byBjYWxs IGl0IGluc3RlYWQ6IEkgZGlkIHRyeSBhbmQgZGVzaWduIGl0WzBdIHRvIG5vdCBiZSBYZW4Kc3Bl Y2lmaWMsIHNvIGl0IHdvdWxkIGJlIG5pY2UgdG8gYXZvaWQgbWFraW5nIGl0IHNvIGluIHRoZSBj b21tYW5kIG5hbWVzCmlmIHBvc3NpYmxlLiBJIHN1c3BlY3QgdGhpcyBtYXkgbGVhZCB0byBhIGNl cnRhaW4gYW1vdW50IG9mCmJpa2VzaGVkZGluZywgaWYgc28gd2Ugc2hvdWxkIGp1c3QgY2FsbCBp dCBzb21ldGhpbmcgWGVuIHNwZWNpZmljIGFuZAptb3ZlIG9uIEkgdGhpbmsuCgpGb3IgYSBub24t WGVuIHNwZWNpZmljIG5hbWUgaG93IGFib3V0ICJmYm0gLS0gZmR0IGJvb3QgbW9kdWxlIiBwcm90 b2NvbAphbmQgYXNzb2NpYXRlZCBjb21tYW5kcyBmYm1fa2VybmVsICsgZmJtX21vZHVsZT8KCklh bi4KClswXQpodHRwOi8vd2lraS54ZW4ub3JnL3dpa2kvWGVuX0FSTV93aXRoX1ZpcnR1YWxpemF0 aW9uX0V4dGVuc2lvbnMvTXVsdGlib290CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KR3J1Yi1kZXZlbCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUu b3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZFmIo-0001b0-1n for mharc-grub-devel@gnu.org; Thu, 16 Jul 2015 12:46:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFmIl-0001Zx-Hw for grub-devel@gnu.org; Thu, 16 Jul 2015 12:46:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFmIf-0002Sk-OQ for grub-devel@gnu.org; Thu, 16 Jul 2015 12:46:27 -0400 Received: from smtp.citrix.com ([66.165.176.89]:62143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFmIf-0002SW-Jc for grub-devel@gnu.org; Thu, 16 Jul 2015 12:46:21 -0400 X-IronPort-AV: E=Sophos;i="5.15,488,1432598400"; d="scan'208";a="281679056" Message-ID: <1437065172.32371.261.camel@citrix.com> Subject: Re: [PATCH v2 1/3] arm64: Add Xen boot support file From: Ian Campbell To: Vladimir =?UTF-8?Q?=27=CF=86-coder/phcoder=27?= Serbinenko Date: Thu, 16 Jul 2015 17:46:12 +0100 In-Reply-To: <55A687E5.4070106@gmail.com> References: <=fu.wei@linaro.org> <1436777640-31871-1-git-send-email-fu.wei@linaro.org> <1436777640-31871-2-git-send-email-fu.wei@linaro.org> <55A687E5.4070106@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DLP: MIA2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.89 Cc: grub-devel@gnu.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, arvidjaar@gmail.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 16:46:29 -0000 On Wed, 2015-07-15 at 18:18 +0200, Vladimir '=CF=86-coder/phcoder' Serbinen= ko wrote: > On 13.07.2015 10:53, fu.wei@linaro.org wrote: > > From: Fu Wei > >=20 > > This patch adds Xen boot support file: > > grub-core/loader/arm64/xen_boot.c > > include/grub/arm64/xen_boot.h > >=20 > > This patch also adds commands register code and hearder file into > > grub-core/loader/arm64/linux.c > >=20 > > - This adds support for the Xen boot on ARM specification for arm64. > > - The implementation for Xen is following : > > http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/M= ultiboot > Please don't refer to this protocol as multiboot anywhere in grub or > around because it's NOT multiboot and we don't want to confuse those 2 > protocols. That's fair enough, my hope was that the docs and communal knowledge about how to write a grub.cfg for Xen x86/multiboot could remain unchanged for Xen on arm (e.g. by using the same multiboot1 command names, which surely won't be reused on arm), but I can see why you would object to that and updating 20_linux_xen to DTRT on both arches solves the majority of that concern. WRT to what to call it instead: I did try and design it[0] to not be Xen specific, so it would be nice to avoid making it so in the command names if possible. I suspect this may lead to a certain amount of bikeshedding, if so we should just call it something Xen specific and move on I think. For a non-Xen specific name how about "fbm -- fdt boot module" protocol and associated commands fbm_kernel + fbm_module? Ian. [0] http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot