From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:53196 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbbGQOu6 (ORCPT ); Fri, 17 Jul 2015 10:50:58 -0400 Message-ID: <1437144656.1933.28.camel@sipsolutions.net> (sfid-20150717_165101_409386_E34EFA5C) Subject: Re: [PATCH v3 5/5] mac80211: select an AID when creating new mesh STAs From: Johannes Berg To: Bob Copeland Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org Date: Fri, 17 Jul 2015 16:50:56 +0200 In-Reply-To: <1437144483.1933.27.camel@sipsolutions.net> (sfid-20150717_164811_113789_A7C6D03E) References: <1436877119-17577-1-git-send-email-me@bobcopeland.com> <1436877119-17577-6-git-send-email-me@bobcopeland.com> (sfid-20150714_143227_832790_AC27A2F3) <1437140910.1933.25.camel@sipsolutions.net> (sfid-20150717_154838_591136_E99D8286) <1437144483.1933.27.camel@sipsolutions.net> (sfid-20150717_164811_113789_A7C6D03E) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2015-07-17 at 16:48 +0200, Johannes Berg wrote: > On Fri, 2015-07-17 at 15:48 +0200, Johannes Berg wrote: > > On Tue, 2015-07-14 at 08:31 -0400, Bob Copeland wrote: > > > Instead of using peer link id for AID, generate a new > > > AID when creating mesh STAs in the kernel peering manager. > > > This enables smaller TIM elements and more closely follows > > > the standard, and it also enables mesh to work on drivers > > > that require a valid AID when the STA is inserted (ath10k > > > firmware has this requirement, for example). > > > > > > In the case of userspace-managed stations, we use the AID > > > from NL80211_CMD_NEW_STATION. > > > > > Applied the remaining 3 patches to mac80211-next (after merging > > mac80211) > > > > Actually, I'm dropping this one (the 5th) as it broke all the wpa_s > mesh test cases. Perhaps wpa_s isn't assigning an AID and mac80211 > needs a fallback? > Actually, it also fails without any of your patches, so I guess it's some other issue. I'll keep these and sort it out when I'm back. johannes