* [PATCH] btrfs: its btrfs_err() instead of btrfs_error()
@ 2015-07-17 15:45 Anand Jain
2015-07-19 3:25 ` Liu Bo
2015-07-20 11:33 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Anand Jain @ 2015-07-17 15:45 UTC (permalink / raw
To: linux-btrfs; +Cc: dsterba, clm
sorry I indented to use btrfs_err() and I have no idea
how btrfs_error() got there.
infact I was thinking about these kind of oversights
since these two func are too closely named.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
fs/btrfs/dev-replace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index 862fbc2..564a7de 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -378,7 +378,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
ret = btrfs_kobj_add_device(tgt_device->fs_devices, tgt_device);
if (ret)
- btrfs_error(root->fs_info, ret, "kobj add dev failed");
+ btrfs_err(root->fs_info, "kobj add dev failed %d\n", ret);
printk_in_rcu(KERN_INFO
"BTRFS: dev_replace from %s (devid %llu) to %s started\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: its btrfs_err() instead of btrfs_error()
2015-07-17 15:45 [PATCH] btrfs: its btrfs_err() instead of btrfs_error() Anand Jain
@ 2015-07-19 3:25 ` Liu Bo
2015-07-20 11:33 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Liu Bo @ 2015-07-19 3:25 UTC (permalink / raw
To: Anand Jain; +Cc: linux-btrfs, dsterba, clm
On Fri, Jul 17, 2015 at 11:45:23PM +0800, Anand Jain wrote:
> sorry I indented to use btrfs_err() and I have no idea
> how btrfs_error() got there.
> infact I was thinking about these kind of oversights
> since these two func are too closely named.
Good catch.
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Thanks,
-liubo
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> fs/btrfs/dev-replace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index 862fbc2..564a7de 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -378,7 +378,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
>
> ret = btrfs_kobj_add_device(tgt_device->fs_devices, tgt_device);
> if (ret)
> - btrfs_error(root->fs_info, ret, "kobj add dev failed");
> + btrfs_err(root->fs_info, "kobj add dev failed %d\n", ret);
>
> printk_in_rcu(KERN_INFO
> "BTRFS: dev_replace from %s (devid %llu) to %s started\n",
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: its btrfs_err() instead of btrfs_error()
2015-07-17 15:45 [PATCH] btrfs: its btrfs_err() instead of btrfs_error() Anand Jain
2015-07-19 3:25 ` Liu Bo
@ 2015-07-20 11:33 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2015-07-20 11:33 UTC (permalink / raw
To: Anand Jain; +Cc: linux-btrfs, clm
On Fri, Jul 17, 2015 at 11:45:23PM +0800, Anand Jain wrote:
> sorry I indented to use btrfs_err() and I have no idea
> how btrfs_error() got there.
> infact I was thinking about these kind of oversights
> since these two func are too closely named.
Indeed, it's confusing. I suggest to convert btrfs_errror to
btrfs_std_error and change the prototype to
#define btrfs_std_error(fs_info, errno, fmt, args...)
and switch all btrfs_error users to pass NULL for 'fmt'.
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-20 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-17 15:45 [PATCH] btrfs: its btrfs_err() instead of btrfs_error() Anand Jain
2015-07-19 3:25 ` Liu Bo
2015-07-20 11:33 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.