From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932848AbbGTOvW (ORCPT ); Mon, 20 Jul 2015 10:51:22 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:57448 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932321AbbGTOvS (ORCPT ); Mon, 20 Jul 2015 10:51:18 -0400 X-Listener-Flag: 11101 Message-ID: <1437403873.15139.5.camel@mtksdaap41> Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 From: Yingjoe Chen To: chunfeng yun CC: Daniel Kurtz , Mark Rutland , "open list:OPEN FIRMWARE AND..." , Mathias Nyman , Sascha Hauer , , "linux-kernel@vger.kernel.org" , Felipe Balbi , Rob Herring , , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" , Roger Quadros Date: Mon, 20 Jul 2015 22:51:13 +0800 In-Reply-To: <1437403179.11518.10.camel@mhfsdcap03> References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-6-git-send-email-chunfeng.yun@mediatek.com> <1437403179.11518.10.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Chunfeng, On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote: > Hi, > > On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote: <...> > > > + > > > + usb_p1_vbus: fixedregulator@0 { > > > > Why @0 ? > It is the first fixed regulator, so set it to 0 as a index. > I will remove it later Since this name should be unique, I think we should use gpio number as address for fixedregulator in case we need other fixedregulators. So this could be: usb_p1_vbus: fixedregulator@130 { Also, we should sort according to the address(gpio number) for these nodes. Does this make sense? Joe.C > > > > > + compatible = "regulator-fixed"; > > > + regulator-name = "usb_vbus"; > > > + regulator-min-microvolt = <5000000>; > > > + regulator-max-microvolt = <5000000>; > > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; > > > + enable-active-high; > > > + }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yingjoe Chen Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Date: Mon, 20 Jul 2015 22:51:13 +0800 Message-ID: <1437403873.15139.5.camel@mtksdaap41> References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-6-git-send-email-chunfeng.yun@mediatek.com> <1437403179.11518.10.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437403179.11518.10.camel@mhfsdcap03> Sender: linux-kernel-owner@vger.kernel.org To: chunfeng yun Cc: Daniel Kurtz , Mark Rutland , "open list:OPEN FIRMWARE AND..." , Mathias Nyman , Sascha Hauer , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" , Felipe Balbi , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , "linux-arm-kernel@lists.infradead.org" , Roger Quadros List-Id: linux-mediatek@lists.infradead.org Hi Daniel, Chunfeng, On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote: > Hi, > > On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote: <...> > > > + > > > + usb_p1_vbus: fixedregulator@0 { > > > > Why @0 ? > It is the first fixed regulator, so set it to 0 as a index. > I will remove it later Since this name should be unique, I think we should use gpio number as address for fixedregulator in case we need other fixedregulators. So this could be: usb_p1_vbus: fixedregulator@130 { Also, we should sort according to the address(gpio number) for these nodes. Does this make sense? Joe.C > > > > > + compatible = "regulator-fixed"; > > > + regulator-name = "usb_vbus"; > > > + regulator-min-microvolt = <5000000>; > > > + regulator-max-microvolt = <5000000>; > > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; > > > + enable-active-high; > > > + }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: yingjoe.chen@mediatek.com (Yingjoe Chen) Date: Mon, 20 Jul 2015 22:51:13 +0800 Subject: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 In-Reply-To: <1437403179.11518.10.camel@mhfsdcap03> References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-6-git-send-email-chunfeng.yun@mediatek.com> <1437403179.11518.10.camel@mhfsdcap03> Message-ID: <1437403873.15139.5.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Daniel, Chunfeng, On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote: > Hi, > > On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote: <...> > > > + > > > + usb_p1_vbus: fixedregulator at 0 { > > > > Why @0 ? > It is the first fixed regulator, so set it to 0 as a index. > I will remove it later Since this name should be unique, I think we should use gpio number as address for fixedregulator in case we need other fixedregulators. So this could be: usb_p1_vbus: fixedregulator at 130 { Also, we should sort according to the address(gpio number) for these nodes. Does this make sense? Joe.C > > > > > + compatible = "regulator-fixed"; > > > + regulator-name = "usb_vbus"; > > > + regulator-min-microvolt = <5000000>; > > > + regulator-max-microvolt = <5000000>; > > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; > > > + enable-active-high; > > > + };