From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v4 for Xen 4.6 2/4] libxc: enable per-VCPU
 parameter settings for RTDS scheduler
Date: Mon, 27 Jul 2015 18:11:06 +0200
Message-ID: <1438013466.5036.219.camel@citrix.com>
References: <1436590356-3706-1-git-send-email-chong.li@wustl.edu>
	<1436590356-3706-3-git-send-email-chong.li@wustl.edu>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4098856265618284422=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436590356-3706-3-git-send-email-chong.li@wustl.edu>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chong Li <lichong659@gmail.com>
Cc: Chong Li <chong.li@wustl.edu>, wei.liu2@citrix.com, Sisu Xi <xisisu@gmail.com>, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, Meng Xu <mengxu@cis.upenn.edu>, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============4098856265618284422==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-MY/48+KXe8wY8C0tMrmf"

--=-MY/48+KXe8wY8C0tMrmf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-07-10 at 23:52 -0500, Chong Li wrote:

> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.=
h
> index d1d2ab3..58f1a7a 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -915,6 +915,15 @@ int xc_sched_rtds_domain_get(xc_interface *xch,
>                              uint32_t domid,
>                              struct xen_domctl_sched_rtds *sdom);
> =20
So, here in the header, you're not changing the prototype of
xc_sched_rtds_domain_{get,set} to use the typedef.

However...

> +int xc_sched_rtds_vcpu_set(xc_interface *xch,
> +                            uint32_t domid,
> +                            xen_domctl_schedparam_vcpu_t *vcpus,
> +                            uint16_t num_vcpus);
>
... you hare using the typedef for the newly introduced functions
xc_sched_rtds_vcpu_{get,set}(), and...

> --- a/tools/libxc/xc_rt.c
> +++ b/tools/libxc/xc_rt.c
> @@ -27,7 +27,7 @@
> =20
>  int xc_sched_rtds_domain_set(xc_interface *xch,
>                             uint32_t domid,
> -                           struct xen_domctl_sched_rtds *sdom)
> +                           xen_domctl_sched_rtds_t *sdom)
>
...you are actually changing the _implementation_ of
xc_sched_rtds_domain_{get,set}().

That's all rather inconsistent.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

--=-MY/48+KXe8wY8C0tMrmf
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlW2WBoACgkQk4XaBE3IOsQWTACgopp6Ok76SkImvysuchvoHs1u
SrQAnRMoSjfq7IXbE7oOXZsZmc6wIEUY
=MITh
-----END PGP SIGNATURE-----

--=-MY/48+KXe8wY8C0tMrmf--


--===============4098856265618284422==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4098856265618284422==--