From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v6 01/31] xen/dt: Handle correctly node with interrupt-map in dt_for_each_irq_map Date: Wed, 2 Sep 2015 16:28:02 +0100 Message-ID: <1441207682.26292.253.camel@citrix.com> References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com> <1441019208-2764-2-git-send-email-vijay.kilari@gmail.com> <55E462A1.9010307@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55E462A1.9010307@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org, Wei Liu Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-08-31 at 15:20 +0100, Julien Grall wrote: > Hi Vijay, > > On 31/08/2015 12:06, vijay.kilari@gmail.com wrote: > > From: Vijaya Kumar K > > > > dt_for_each_irq_map() returns error if no irq mapping is found. > > With this patch, Ignore error and return success > > NIT: s/Ignore/ignore/ > > > > > Signed-off-by: Vijaya Kumar K > > I think this could go in Xen 4.6 as it's a bug fix: > > Reviewed-by: Julien Grall I replied to v5, forgetting I had a v6 in my hand too. I also forgot to CC Wei. Lets try again here... Acked-by: Ian Campbell Wei -- I think this fix would be good to have for 4.6. It is not an error to process a zero-length (==non-existent) array I think. I think the title should be s/with/without/, Julien was that what you meant when you suggested it? Ian.