From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v6 00/31] Add ITS support
Date: Wed, 2 Sep 2015 16:52:02 +0100
Message-ID: <1441209122.26292.260.camel@citrix.com>
References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com>
	<1441208280.26292.255.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1441208280.26292.255.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, julien.grall@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-09-02 at 16:38 +0100, Ian Campbell wrote:
> > 
> > Changes in v6:
> > 
> >  - Rebased to latest staging branch.
> >  - Compiled all the patches individually for both arm32 and arm64
> >  - Split the patch "xen/arm: ITS: Allocate irq descriptors for LPIs" 
> > into 
> > two.
> >    One for allocating LPI irq_desc and other patch for allocating 
> > pending_irq desc
> >    for LPIs
> >  - Following new patches are introduced
> >      1) xen/arm: Rename NR_IRQs and vgic_num_irqs helper function
> >      2) xen/arm: ITS: Introduce msi_desc for LPIs
> >      3) xen/arm: Move vgic locking inside get_irq_priority callback
> >      4) xen/arm: ITS: Store LPIs allocated and IRQ ID bits per domain
> >      5) xen/arm: ITS: Introduce helper to get number of event IDs
> >      6) xen/arm: ITS: Add virtual ITS availability check helper
> >      7) xen/arm: ITS: Add 32-bit access to GICR_TYPER) 
> >      8) xen/arm: ITS: Allocate pending_lpi descriptors for LPIs
> > 
> >  - Based on below patch set
> >      http://lists.xen.org/archives/html/xen-devel/2015-08/msg00168.html
> > 
> >  Some Major TODOs:
> >    1) Avoid making vits_process_cmd() static in later point of time
> >    2) How to handle LPI that does not have LPI config table entry.
> >    3) Enable/disable ITS to Dom0
> 
> http://article.gmane.org/gmane.comp.emulators.xen.devel/258198 doesn't 
> seem
> to be reflected here as either a change/new-patch or a Major TODO, and it
> is pretty Major I think.

I was reminded by Julien's response to patch #29 that this is only really a
problem once we are exposing the ITS to domU, and I concur with his request
for a big fat warning comment (the existing ASSERT I think is sufficient to
avoid runtime problems).

Ian.