From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 09 Sep 2015 23:01:37 +0000 Subject: Re: [PATCH] powerpc/e500: move qemu machine spec together with the rest Message-Id: <1441839697.2623.21.camel@freescale.com> List-Id: References: <55E992AE.3010605@freescale.com> In-Reply-To: <55E992AE.3010605@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Fri, 2015-09-04 at 15:46 +0300, Laurentiu Tudor wrote: > This way we get rid of an entire file with mostly > duplicated code plus a Kconfig option that you always > had to take care to check it in order for kvm to work. > > Signed-off-by: Laurentiu Tudor > --- > arch/powerpc/platforms/85xx/Kconfig | 15 ----- > arch/powerpc/platforms/85xx/Makefile | 1 - > arch/powerpc/platforms/85xx/corenet_generic.c | 1 + > arch/powerpc/platforms/85xx/qemu_e500.c | 85 ------------------------ qemu_e500 is not only for corenet chips. We can add it to the defconfig (in fact I've been meaning to do so). > -static void __init qemu_e500_setup_arch(void) > -{ > - ppc_md.progress("qemu_e500_setup_arch()", 0); > - > - fsl_pci_assign_primary(); > - swiotlb_detect_4g(); Where is fsl_pci_assign_primary() in corenet_generic.c? At one point this was needed for QEMU's PCI implementation -- have you tested QEMU PCI without it? -Scott