From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38394)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Za3Jt-0000p0-Ec
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 10:59:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Za3Jq-0006nA-9B
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 10:59:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Za3Jq-0006my-4K
	for qemu-devel@nongnu.org; Thu, 10 Sep 2015 10:59:22 -0400
Message-ID: <1441897159.11233.29.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 10 Sep 2015 16:59:19 +0200
In-Reply-To: <CAJ+F1CJULVxetPWrJXRwNzdRHCPuUNbuszZhOF1PPO4AX1Bg1A@mail.gmail.com>
References: <1441797654-15350-1-git-send-email-kraxel@redhat.com>
	<1441797654-15350-2-git-send-email-kraxel@redhat.com>
	<CAJ+F1C+YRwG0yjat4p+rKmGdj0uu0wHN8rtQPBQyZOU2AADiAA@mail.gmail.com>
	<1441891346.11233.1.camel@redhat.com>
	<CAJ+F1CJULVxetPWrJXRwNzdRHCPuUNbuszZhOF1PPO4AX1Bg1A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>

On Do, 2015-09-10 at 15:42 +0200, Marc-Andr=C3=A9 Lureau wrote:
> Hi
>=20
> On Thu, Sep 10, 2015 at 3:22 PM, Gerd Hoffmann <kraxel@redhat.com> wrot=
e:
> >> > +    glBindBuffer (GL_ARRAY_BUFFER, 0);
> >> > +    glBindVertexArray (0);
> >> > +    glDeleteBuffers (1, &buffer);
> >> > +
> >>
> >> extra space before (
> >
> > Fixed.
> >
> >> Is the unbinding necessary?
> >
> > Unbinding?  Do you mam the DeleteBuffers?
> >
>=20
> The glBind..(.., 0)
>=20
> I think they shouldn't be necessary unless you have some other gl
> context sensitive code.

Just good style copied from sample code.
Probably it's not really needed here.

cheers,
  Gerd