All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: speakup: Changed simple_strtoul to kstrtoul
@ 2015-09-11 15:17 Aparna Karuthodi
  2015-09-12  2:57 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Aparna Karuthodi @ 2015-09-11 15:17 UTC (permalink / raw
  To: gregkh; +Cc: kirk, linux-kernel, devel, speakup, Aparna Karuthodi

Used kstrtoul instead of simple_strtoul to remove a warning detected by
checkpatch.The warning is given below:
drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
obsolete, use kstrtoul instead

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/speakup/varhandlers.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 1b0d1c0..00fd67e 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
 {
 	int val = 0;
 
-	val = simple_strtoul(skip_spaces(start), &start, 10);
+	val = kstrtoul(skip_spaces(start), &start, 10);
 	if (*start == ',')
 		start++;
 	*dest = (u_char)val;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: speakup: Changed simple_strtoul to kstrtoul
  2015-09-11 15:17 [PATCH] staging: speakup: Changed simple_strtoul to kstrtoul Aparna Karuthodi
@ 2015-09-12  2:57 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-09-12  2:57 UTC (permalink / raw
  To: Aparna Karuthodi; +Cc: kirk, linux-kernel, devel, speakup

On Fri, Sep 11, 2015 at 08:47:20PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul to remove a warning detected by
> checkpatch.The warning is given below:
> drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/speakup/varhandlers.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
> index 1b0d1c0..00fd67e 100644
> --- a/drivers/staging/speakup/varhandlers.c
> +++ b/drivers/staging/speakup/varhandlers.c
> @@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
>  {
>  	int val = 0;
>  
> -	val = simple_strtoul(skip_spaces(start), &start, 10);
> +	val = kstrtoul(skip_spaces(start), &start, 10);
>  	if (*start == ',')
>  		start++;
>  	*dest = (u_char)val;

You obviously did not even compile this patch, which is quite rude,
don't you think?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-12  4:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-11 15:17 [PATCH] staging: speakup: Changed simple_strtoul to kstrtoul Aparna Karuthodi
2015-09-12  2:57 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.