From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dannenberg Subject: [PATCH v3 09/10] power: bq24257: Add various device-specific sysfs properties Date: Fri, 11 Sep 2015 15:26:41 -0500 Message-ID: <1442003202-1430-10-git-send-email-dannenberg@ti.com> References: <1442003202-1430-1-git-send-email-dannenberg@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1442003202-1430-1-git-send-email-dannenberg@ti.com> Sender: linux-pm-owner@vger.kernel.org To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Laurentiu Palcu , Krzysztof Kozlowski Cc: Ramakrishna Pallala , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Andreas Dannenberg List-Id: devicetree@vger.kernel.org This patch adds support to enable/disable some device specific features through device properties at boot time or sysfs properties at runtime depending on whether they should be accessible during runtime or not. The use of those features is be optional however they might be helpful in certain scenarios: * High-impedance mode enable/disable (through sysfs r/w) * Sysoff enable/disable (through sysfs r/w) * 2X Timer enable/disable (through "ti,safety-timer-2x-enable" dev property) If not explicitly modified those settings are left at their device- specific power-on defaults. Refer to the respectice device datasheets for more information: http://www.ti.com/product/bq24250 http://www.ti.com/product/bq24251 http://www.ti.com/product/bq24257 Signed-off-by: Andreas Dannenberg --- drivers/power/bq24257_charger.c | 67 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/drivers/power/bq24257_charger.c b/drivers/power/bq24257_charger.c index 517a522..6d73736 100644 --- a/drivers/power/bq24257_charger.c +++ b/drivers/power/bq24257_charger.c @@ -77,6 +77,7 @@ struct bq24257_init_data { u8 in_ilimit; /* input current limit */ u8 vovp; /* over voltage protection voltage */ u8 vindpm; /* VDMP input threshold voltage */ + bool timer2x_enable; /* slow down safety timer by 2x */ }; struct bq24257_state { @@ -699,6 +700,7 @@ static int bq24257_hw_init(struct bq24257_device *bq) {F_ITERM, bq->init_data.iterm}, {F_VOVP, bq->init_data.vovp}, {F_VINDPM, bq->init_data.vindpm}, + {F_X2_TMR_EN, bq->init_data.timer2x_enable}, }; /* @@ -794,12 +796,70 @@ static ssize_t bq24257_show_in_dpm_voltage(struct device *dev, bq24257_vindpm_map[bq->init_data.vindpm]); } +static ssize_t bq24257_sysfs_show_enable(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct power_supply *psy = dev_get_drvdata(dev); + struct bq24257_device *bq = power_supply_get_drvdata(psy); + int ret; + + if (strcmp(attr->attr.name, "high_impedance_enable") == 0) + ret = bq24257_field_read(bq, F_HZ_MODE); + else if (strcmp(attr->attr.name, "sysoff_enable") == 0) + ret = bq24257_field_read(bq, F_SYSOFF); + else if (strcmp(attr->attr.name, "timer2x_enable") == 0) + ret = bq->init_data.timer2x_enable; + else + return -EINVAL; + + if (ret < 0) + return ret; + + return scnprintf(buf, PAGE_SIZE, "%d\n", ret); +} + +static ssize_t bq24257_sysfs_set_enable(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t count) +{ + struct power_supply *psy = dev_get_drvdata(dev); + struct bq24257_device *bq = power_supply_get_drvdata(psy); + long val; + int ret; + + if (kstrtol(buf, 10, &val) < 0) + return -EINVAL; + + if (strcmp(attr->attr.name, "high_impedance_enable") == 0) + ret = bq24257_field_write(bq, F_HZ_MODE, val); + else if (strcmp(attr->attr.name, "sysoff_enable") == 0) + ret = bq24257_field_write(bq, F_SYSOFF, val); + else + return -EINVAL; + + if (ret < 0) + return ret; + + return count; +} + static DEVICE_ATTR(ovp_voltage, S_IRUGO, bq24257_show_ovp_voltage, NULL); static DEVICE_ATTR(in_dpm_voltage, S_IRUGO, bq24257_show_in_dpm_voltage, NULL); +static DEVICE_ATTR(high_impedance_enable, S_IWUSR | S_IRUGO, + bq24257_sysfs_show_enable, bq24257_sysfs_set_enable); +static DEVICE_ATTR(sysoff_enable, S_IWUSR | S_IRUGO, + bq24257_sysfs_show_enable, bq24257_sysfs_set_enable); +static DEVICE_ATTR(timer2x_enable, S_IRUGO, + bq24257_sysfs_show_enable, NULL); static struct attribute *bq24257_charger_attr[] = { &dev_attr_ovp_voltage.attr, &dev_attr_in_dpm_voltage.attr, + &dev_attr_high_impedance_enable.attr, + &dev_attr_sysoff_enable.attr, + &dev_attr_timer2x_enable.attr, NULL, }; @@ -912,6 +972,13 @@ static int bq24257_fw_probe(struct bq24257_device *bq) bq24257_vindpm_map, BQ24257_VINDPM_MAP_SIZE); + ret = device_property_read_u32(bq->dev, "ti,safety-timer-2x-enable", + &property); + if (ret < 0) + bq->init_data.timer2x_enable = false; + else + bq->init_data.timer2x_enable = property; + return 0; } -- 1.9.1