From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters Date: Mon, 14 Sep 2015 11:25:25 +0100 Message-ID: <1442226325.3549.134.camel__38917.8486112089$1442226414$gmane$org@citrix.com> References: <20150910112418.GC29293@leverpostej> <20150910121514.GE29293@leverpostej> <20150910144938.GI29293@leverpostej> <20150910162302.GN29293@leverpostej> <20150911124643.GB4530@olila.local.net-space.pl> <20150911162559.GA8726@leverpostej> <20150912113655.GG4530@olila.local.net-space.pl> <20150914092518.GA10307@leverpostej> <1442224673.3549.131.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ard Biesheuvel Cc: Mark Rutland , "linux-efi@vger.kernel.org" , Stefano Stabellini , Daniel Kiper , "peter.huangpeng@huawei.com" , "leif.lindholm@linaro.org" , "xen-devel@lists.xen.org" , "julien.grall@citrix.com" , "matt.fleming@intel.com" , "linux-arm-kernel@lists.infradead.org" , "jbeulich@suse.com" , Shannon Zhao , "christoffer.dall@linaro.org" , "shannon.zhao@linaro.org" List-Id: xen-devel@lists.xenproject.org On Mon, 2015-09-14 at 12:02 +0200, Ard Biesheuvel wrote: > On 14 September 2015 at 11:57, Ian Campbell wrote: > > > or SetVirtualAddressMap/ConvertPointer, and > > > > These two are RTS, so in principal it could. > > > > (I'm not sure about ConvertPointer, is it useful for OS kernels, or > > just > > for "UEFI components" mentioned at > > http://wiki.phoenix.com/wiki/index.php/E > > FI_RUNTIME_SERVICES#ConvertPointer.28.29 ?) > > > > No, there is no point. The stub calls SetVirtualAddressMap, so the > kernel proper can never call it, since it can only be called once. I see. And changing this such that it was delayed until the kernel proper would be a _major_ shift in the policy of separation between the UEFI stub and the kernel proper. > ConvertPointer has little utility outside of the UEFI runtime > components that are invoked during SetVirtualAddressMap, That's the impression I was getting too. Thanks for confirming. > so I don't see a reason to supply that either. Ack. Ian.